* [PATCH v2] wifi: brcmfmac: clarify unmodifiable headroom log message
@ 2024-12-13 8:14 Alex Shumsky
2024-12-13 13:32 ` Arend van Spriel
2024-12-18 18:04 ` Kalle Valo
0 siblings, 2 replies; 3+ messages in thread
From: Alex Shumsky @ 2024-12-13 8:14 UTC (permalink / raw)
To: linux-wireless
Cc: Alex Shumsky, Al Viro, Arend van Spriel, Kalle Valo,
brcm80211-dev-list.pdl, brcm80211, linux-kernel
Replace misleading log "insufficient headroom (0)" with more clear
"unmodifiable headroom".
Signed-off-by: Alex Shumsky <alexthreed@gmail.com>
---
Changes in v2:
- don't remove log completely, but reword it
drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c
index da72fd2d541f..c3a57e30c855 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c
@@ -327,8 +327,8 @@ static netdev_tx_t brcmf_netdev_start_xmit(struct sk_buff *skb,
if (skb_headroom(skb) < drvr->hdrlen || skb_header_cloned(skb)) {
head_delta = max_t(int, drvr->hdrlen - skb_headroom(skb), 0);
- brcmf_dbg(INFO, "%s: insufficient headroom (%d)\n",
- brcmf_ifname(ifp), head_delta);
+ brcmf_dbg(INFO, "%s: %s headroom\n", brcmf_ifname(ifp),
+ head_delta ? "insufficient" : "unmodifiable");
atomic_inc(&drvr->bus_if->stats.pktcowed);
ret = pskb_expand_head(skb, ALIGN(head_delta, NET_SKB_PAD), 0,
GFP_ATOMIC);
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2] wifi: brcmfmac: clarify unmodifiable headroom log message
2024-12-13 8:14 [PATCH v2] wifi: brcmfmac: clarify unmodifiable headroom log message Alex Shumsky
@ 2024-12-13 13:32 ` Arend van Spriel
2024-12-18 18:04 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Arend van Spriel @ 2024-12-13 13:32 UTC (permalink / raw)
To: Alex Shumsky, linux-wireless
Cc: Al Viro, Kalle Valo, brcm80211-dev-list.pdl, brcm80211,
linux-kernel
On 12/13/2024 9:14 AM, Alex Shumsky wrote:
> Replace misleading log "insufficient headroom (0)" with more clear
> "unmodifiable headroom".
Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
> Signed-off-by: Alex Shumsky <alexthreed@gmail.com>
> ---
>
> Changes in v2:
> - don't remove log completely, but reword it
>
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] wifi: brcmfmac: clarify unmodifiable headroom log message
2024-12-13 8:14 [PATCH v2] wifi: brcmfmac: clarify unmodifiable headroom log message Alex Shumsky
2024-12-13 13:32 ` Arend van Spriel
@ 2024-12-18 18:04 ` Kalle Valo
1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2024-12-18 18:04 UTC (permalink / raw)
To: Alex Shumsky
Cc: linux-wireless, Alex Shumsky, Al Viro, Arend van Spriel,
brcm80211-dev-list.pdl, brcm80211, linux-kernel
Alex Shumsky <alexthreed@gmail.com> wrote:
> Replace misleading log "insufficient headroom (0)" with more clear
> "unmodifiable headroom".
>
> Signed-off-by: Alex Shumsky <alexthreed@gmail.com>
> Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Patch applied to wireless-next.git, thanks.
aeda9245c7ce wifi: brcmfmac: clarify unmodifiable headroom log message
--
https://patchwork.kernel.org/project/linux-wireless/patch/20241213081402.625003-1-alexthreed@gmail.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-12-18 18:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-13 8:14 [PATCH v2] wifi: brcmfmac: clarify unmodifiable headroom log message Alex Shumsky
2024-12-13 13:32 ` Arend van Spriel
2024-12-18 18:04 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox