From: Vlad Drukker <vlad@storewiz.com>
To: shemminger@osdl.org
Cc: bridge@osdl.org
Subject: [Bridge] [PATCH] fix 802.3ad multicast
Date: Thu, 06 Apr 2006 19:15:06 +0300 [thread overview]
Message-ID: <1144340106.17145.8.camel@quant> (raw)
[-- Attachment #1: Type: text/plain, Size: 165 bytes --]
Hi Stephen,
there was a bug in bridging bonds.
multicast packets needed for 802.3ad netif_carrier_ok() were dropped.
attached patch works for me.
Cheers,
Vlad.
[-- Attachment #2: fix_br_multicast.patch --]
[-- Type: text/x-patch, Size: 1344 bytes --]
Signed-off-by: Vlad Drukker <vlad@storewiz.com>
---
[BRIDGE] fix 802.3ad multicast frame handling
core netif code does handle_bridge before calling protocol handler
for ETH_P_SLOW packet_type. when BR_STATE_DISABLED is set for
bonded port, netif_carrier_ok() will always fail for 802.3ad bond,
because 'partner' (multicast) packet has to be received via
_disabled_ port, causing bond to stay in BR_STATE_DISABLED forever.
---
commit e78e0ecc216f934662ae0a10df61c9e2ade44647
tree d491d94f3f043fa698e25cde863b97adc34693b2
parent e77d1795d3eb2999e271cee8957240f161a5461c
author Vlad Drukker <vlad@storewiz.com> Thu, 06 Apr 2006 18:56:51 +0300
committer Vlad Drukker <vlad@storewiz.com> Thu, 06 Apr 2006 18:56:51 +0300
net/bridge/br_input.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/net/bridge/br_input.c b/net/bridge/br_input.c
index b776656..6c72c5e 100644
--- a/net/bridge/br_input.c
+++ b/net/bridge/br_input.c
@@ -125,7 +125,9 @@ int br_handle_frame(struct net_bridge_po
struct sk_buff *skb = *pskb;
const unsigned char *dest = eth_hdr(skb)->h_dest;
- if (p->state == BR_STATE_DISABLED)
+ if (p->state == BR_STATE_DISABLED
+ && !(skb->dev->priv_flags & IFF_MASTER_8023AD
+ && skb->protocol == __constant_htons(ETH_P_SLOW)))
goto err;
if (!is_valid_ether_addr(eth_hdr(skb)->h_source))
next reply other threads:[~2006-04-06 16:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-06 16:15 Vlad Drukker [this message]
2006-04-07 23:59 ` [Bridge] [PATCH] fix 802.3ad multicast Stephen Hemminger
2006-04-09 14:42 ` Vlad Drukker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1144340106.17145.8.camel@quant \
--to=vlad@storewiz.com \
--cc=bridge@osdl.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox