From: Vlad Drukker <vlad@storewiz.com>
To: Stephen Hemminger <shemminger@osdl.org>
Cc: bridge@osdl.org
Subject: Re: [Bridge] [PATCH] fix 802.3ad multicast
Date: Sun, 09 Apr 2006 17:42:54 +0300 [thread overview]
Message-ID: <1144593774.23360.16.camel@quant> (raw)
In-Reply-To: <20060407165928.022d4ad8@dxpl.pdx.osdl.net>
On Fri, 2006-04-07 at 16:59 -0700, Stephen Hemminger wrote:
> On Thu, 06 Apr 2006 19:15:06 +0300
> Vlad Drukker <vlad@storewiz.com> wrote:
>
> > Hi Stephen,
> >
> > there was a bug in bridging bonds.
> > multicast packets needed for 802.3ad netif_carrier_ok() were dropped.
> > attached patch works for me.
> >
> > Cheers,
> > Vlad.
> >
> >
> >
>
> Making a bonding specific hack like this seems wrong. The
> port could also be disabled during shutdown (for RCU removal),
> and in that case we need to drop the packet.
>
> There must be a better solution.
>
you probably right,
skb_bond() looks like a proper place for this, because
netif_receive_skb() needs to call ETH_P_SLOW hadler instead of
hadle_bridge hook.
the fix is moving to linux-net .
prev parent reply other threads:[~2006-04-09 14:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-06 16:15 [Bridge] [PATCH] fix 802.3ad multicast Vlad Drukker
2006-04-07 23:59 ` Stephen Hemminger
2006-04-09 14:42 ` Vlad Drukker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1144593774.23360.16.camel@quant \
--to=vlad@storewiz.com \
--cc=bridge@osdl.org \
--cc=shemminger@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox