* [Bridge] [PATCH 01/31] bridge: Auto-load bridge module when socket opened. [not found] <cover.1236702228.git.scott@canonical.com> @ 2009-03-02 16:40 ` Scott James Remnant 2009-03-10 17:26 ` Stephen Hemminger 2009-03-13 21:27 ` David Miller 0 siblings, 2 replies; 6+ messages in thread From: Scott James Remnant @ 2009-03-02 16:40 UTC (permalink / raw) To: linux-kernel; +Cc: bridge The bridge module is missing the net-pf-7 alias that would cause it to be auto-loaded when a socket of that type is opened. This patch adds the alias. Signed-off-by: Scott James Remnant <scott@canonical.com> Signed-off-by: Tim Gardner <tim.gardner@canonical.com> --- net/bridge/br.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/net/bridge/br.c b/net/bridge/br.c index 4d2c1f1..229daee 100644 --- a/net/bridge/br.c +++ b/net/bridge/br.c @@ -16,6 +16,7 @@ #include <linux/netdevice.h> #include <linux/etherdevice.h> #include <linux/init.h> +#include <linux/net.h> #include <linux/llc.h> #include <net/llc.h> #include <net/stp.h> @@ -108,3 +109,4 @@ module_init(br_init) module_exit(br_deinit) MODULE_LICENSE("GPL"); MODULE_VERSION(BR_VERSION); +MODULE_ALIAS_NETPROTO(PF_BRIDGE); -- 1.6.0.5 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Bridge] [PATCH 01/31] bridge: Auto-load bridge module when socket opened. 2009-03-02 16:40 ` [Bridge] [PATCH 01/31] bridge: Auto-load bridge module when socket opened Scott James Remnant @ 2009-03-10 17:26 ` Stephen Hemminger 2009-03-13 21:27 ` David Miller 1 sibling, 0 replies; 6+ messages in thread From: Stephen Hemminger @ 2009-03-10 17:26 UTC (permalink / raw) To: Scott James Remnant; +Cc: bridge, linux-kernel On Mon, 2 Mar 2009 16:40:10 +0000 Scott James Remnant <scott@canonical.com> wrote: > The bridge module is missing the net-pf-7 alias that would cause it to > be auto-loaded when a socket of that type is opened. This patch adds > the alias. > > Signed-off-by: Scott James Remnant <scott@canonical.com> > Signed-off-by: Tim Gardner <tim.gardner@canonical.com> > --- > net/bridge/br.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/net/bridge/br.c b/net/bridge/br.c > index 4d2c1f1..229daee 100644 > --- a/net/bridge/br.c > +++ b/net/bridge/br.c > @@ -16,6 +16,7 @@ > #include <linux/netdevice.h> > #include <linux/etherdevice.h> > #include <linux/init.h> > +#include <linux/net.h> > #include <linux/llc.h> > #include <net/llc.h> > #include <net/stp.h> > @@ -108,3 +109,4 @@ module_init(br_init) > module_exit(br_deinit) > MODULE_LICENSE("GPL"); > MODULE_VERSION(BR_VERSION); > +MODULE_ALIAS_NETPROTO(PF_BRIDGE); Hmm. It looks okay, but there is not real direct socket interface for PF_BRIDGE/AF_BRIDGE. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Bridge] [PATCH 01/31] bridge: Auto-load bridge module when socket opened. 2009-03-02 16:40 ` [Bridge] [PATCH 01/31] bridge: Auto-load bridge module when socket opened Scott James Remnant 2009-03-10 17:26 ` Stephen Hemminger @ 2009-03-13 21:27 ` David Miller 2009-03-13 22:12 ` Stephen Hemminger 2009-03-14 10:36 ` Scott James Remnant 1 sibling, 2 replies; 6+ messages in thread From: David Miller @ 2009-03-13 21:27 UTC (permalink / raw) To: scott; +Cc: bridge, linux-kernel From: Scott James Remnant <scott@canonical.com> Date: Mon, 2 Mar 2009 16:40:10 +0000 > The bridge module is missing the net-pf-7 alias that would cause it to > be auto-loaded when a socket of that type is opened. This patch adds > the alias. > > Signed-off-by: Scott James Remnant <scott@canonical.com> > Signed-off-by: Tim Gardner <tim.gardner@canonical.com> Bridging has no sockets, so this patch won't do anything. Did you verify that these changes actually do something? Or did you blindly run around peppering source files with these annotations? ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Bridge] [PATCH 01/31] bridge: Auto-load bridge module when socket opened. 2009-03-13 21:27 ` David Miller @ 2009-03-13 22:12 ` Stephen Hemminger 2009-03-13 22:28 ` David Miller 2009-03-14 10:36 ` Scott James Remnant 1 sibling, 1 reply; 6+ messages in thread From: Stephen Hemminger @ 2009-03-13 22:12 UTC (permalink / raw) To: David Miller; +Cc: scott, bridge, linux-kernel On Fri, 13 Mar 2009 14:27:18 -0700 (PDT) David Miller <davem@davemloft.net> wrote: > From: Scott James Remnant <scott@canonical.com> > Date: Mon, 2 Mar 2009 16:40:10 +0000 > > > The bridge module is missing the net-pf-7 alias that would cause it to > > be auto-loaded when a socket of that type is opened. This patch adds > > the alias. > > > > Signed-off-by: Scott James Remnant <scott@canonical.com> > > Signed-off-by: Tim Gardner <tim.gardner@canonical.com> > > Bridging has no sockets, so this patch won't do anything. > > Did you verify that these changes actually do something? > Or did you blindly run around peppering source files with > these annotations? I think this all started when I was debugging a problem where LLC was not getting autoloaded properly. It turned out that distro's like Debian (and therefore Ubuntu) had incorrect modprobe.d/alias file entries. I raised the bug that, "hey you have wrong data and you really don't need these alias entries at all anymore". There was some comparison of what was being shipped versus what was in the kernel and the Debian/Ubuntu guys stepped in to try and unify this. Let's be supportive of Ubuntu maintainers actually working on upstream resolution for a change. The normal distro maintainer is "patch and ignore". In this case, many of these are correct, but several of them are cases where there is no point in having a module alias because there is no functiona user visible API. You can try and open a PF_BRIDGE socket, there just is no point. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Bridge] [PATCH 01/31] bridge: Auto-load bridge module when socket opened. 2009-03-13 22:12 ` Stephen Hemminger @ 2009-03-13 22:28 ` David Miller 0 siblings, 0 replies; 6+ messages in thread From: David Miller @ 2009-03-13 22:28 UTC (permalink / raw) To: shemminger; +Cc: scott, bridge, linux-kernel From: Stephen Hemminger <shemminger@linux-foundation.org> Date: Fri, 13 Mar 2009 15:12:00 -0700 > Let's be supportive of Ubuntu maintainers actually working on > upstream resolution for a change. The normal distro maintainer is > "patch and ignore". This has nothing to do with being supportive or not. If the changes are wrong, many of these in fact were, and they were not even tested on top of it, I cannot be happy at all about that. And that goes for anyone submitting patches here. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Bridge] [PATCH 01/31] bridge: Auto-load bridge module when socket opened. 2009-03-13 21:27 ` David Miller 2009-03-13 22:12 ` Stephen Hemminger @ 2009-03-14 10:36 ` Scott James Remnant 1 sibling, 0 replies; 6+ messages in thread From: Scott James Remnant @ 2009-03-14 10:36 UTC (permalink / raw) To: David Miller; +Cc: bridge, linux-kernel [-- Attachment #1: Type: text/plain, Size: 882 bytes --] On Fri, 2009-03-13 at 14:27 -0700, David Miller wrote: > Did you verify that these changes actually do something? > Or did you blindly run around peppering source files with > these annotations? > I converted existing modprobe aliases that most distributions are carrying around into the one-line kernel patches. I tested the important ones such as the floppy and ch changes. If the patches are wrong, which I personally suspected many of them were, then it's a good example as to why distributions shouldn't hack around the kernel in userspace, or keep their own patches. So yes, they're a bit stinky (hell, I even fluffed up the covering mail subject line <g>) - but distros including Ubuntu were trying to do these aliases in modprobe rules, so it's a good thing to find out that they're wrong; no? Scott -- Scott James Remnant scott@canonical.com [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 197 bytes --] ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2009-03-14 10:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1236702228.git.scott@canonical.com>
2009-03-02 16:40 ` [Bridge] [PATCH 01/31] bridge: Auto-load bridge module when socket opened Scott James Remnant
2009-03-10 17:26 ` Stephen Hemminger
2009-03-13 21:27 ` David Miller
2009-03-13 22:12 ` Stephen Hemminger
2009-03-13 22:28 ` David Miller
2009-03-14 10:36 ` Scott James Remnant
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox