* [Bridge] brigde does not relay BPDU multicast pkgs
@ 2009-05-08 8:33 Joakim Tjernlund
2009-05-08 12:14 ` Ross Vandegrift
2009-05-08 16:02 ` Stephen Hemminger
0 siblings, 2 replies; 11+ messages in thread
From: Joakim Tjernlund @ 2009-05-08 8:33 UTC (permalink / raw)
To: bridge
Hi List
We have noticed that when STP is off in the linux bridge, it won't
relay STP pkts received from other bridges.
This feels like a bug(a bad one too). I hope this isn't
intentional behaviour?
Jocke
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Bridge] brigde does not relay BPDU multicast pkgs
2009-05-08 8:33 [Bridge] brigde does not relay BPDU multicast pkgs Joakim Tjernlund
@ 2009-05-08 12:14 ` Ross Vandegrift
2009-05-08 12:27 ` Joakim Tjernlund
2009-05-08 16:02 ` Stephen Hemminger
1 sibling, 1 reply; 11+ messages in thread
From: Ross Vandegrift @ 2009-05-08 12:14 UTC (permalink / raw)
To: Joakim Tjernlund; +Cc: bridge
On Fri, May 08, 2009 at 10:33:37AM +0200, Joakim Tjernlund wrote:
> We have noticed that when STP is off in the linux bridge, it won't
> relay STP pkts received from other bridges.
> This feels like a bug(a bad one too). I hope this isn't
> intentional behaviour?
IEEE 802.1D specifies that no bridge should ever forward packets
destined to the bridge multicast groups. See requirement 7.12.6 in
802.1D-2004.
--
Ross Vandegrift
ross@kallisti.us
"If the fight gets hot, the songs get hotter. If the going gets tough,
the songs get tougher."
--Woody Guthrie
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Bridge] brigde does not relay BPDU multicast pkgs
2009-05-08 12:14 ` Ross Vandegrift
@ 2009-05-08 12:27 ` Joakim Tjernlund
0 siblings, 0 replies; 11+ messages in thread
From: Joakim Tjernlund @ 2009-05-08 12:27 UTC (permalink / raw)
To: Ross Vandegrift; +Cc: bridge
Ross Vandegrift <ross@kallisti.us> wrote on 08/05/2009 14:14:39:
> On Fri, May 08, 2009 at 10:33:37AM +0200, Joakim Tjernlund wrote:
> > We have noticed that when STP is off in the linux bridge, it won't
> > relay STP pkts received from other bridges.
> > This feels like a bug(a bad one too). I hope this isn't
> > intentional behaviour?
>
> IEEE 802.1D specifies that no bridge should ever forward packets
> destined to the bridge multicast groups. See requirement 7.12.6 in
> 802.1D-2004.
uhh, that was a surprise. My impression is that normal switches
do forward the bridge multicast group, is this true? If so
can we add an option to the linux bridge to allow forwarding of
bridge multicast groups?
Jocke
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Bridge] brigde does not relay BPDU multicast pkgs
2009-05-08 8:33 [Bridge] brigde does not relay BPDU multicast pkgs Joakim Tjernlund
2009-05-08 12:14 ` Ross Vandegrift
@ 2009-05-08 16:02 ` Stephen Hemminger
2009-05-08 16:43 ` richardvoigt
` (2 more replies)
1 sibling, 3 replies; 11+ messages in thread
From: Stephen Hemminger @ 2009-05-08 16:02 UTC (permalink / raw)
To: Joakim Tjernlund; +Cc: bridge
On Fri, 8 May 2009 10:33:37 +0200
Joakim Tjernlund <joakim.tjernlund@transmode.se> wrote:
>
> Hi List
>
> We have noticed that when STP is off in the linux bridge, it won't
> relay STP pkts received from other bridges.
> This feels like a bug(a bad one too). I hope this isn't
> intentional behaviour?
>
> Jocke
>
> _______________________________________________
> Bridge mailing list
> Bridge@lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/bridge
It is a debatable whether this is correct behaviour.
My current opinion is that it needs to forward STP packets if
STP is off. This would allow for loop detection by other bridges
doing STP.
Longer term, RSTP needs to be fully integrated and default to on.
That way the average user will be safe from loops.
--
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [Bridge] brigde does not relay BPDU multicast pkgs
2009-05-08 16:02 ` Stephen Hemminger
@ 2009-05-08 16:43 ` richardvoigt
2009-05-10 17:47 ` Joakim Tjernlund
[not found] ` <OFD8A6DCB5.C299BC0C-ONC12575B2.006169DD-C12575B2.0061B705@LocalDomain>
2 siblings, 0 replies; 11+ messages in thread
From: richardvoigt @ 2009-05-08 16:43 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: bridge, Joakim Tjernlund
On Fri, May 8, 2009 at 11:02 AM, Stephen Hemminger
<shemminger@vyatta.com> wrote:
> On Fri, 8 May 2009 10:33:37 +0200
> Joakim Tjernlund <joakim.tjernlund@transmode.se> wrote:
>
>>
>> Hi List
>>
>> We have noticed that when STP is off in the linux bridge, it won't
>> relay STP pkts received from other bridges.
>> This feels like a bug(a bad one too). I hope this isn't
>> intentional behaviour?
>>
>> Jocke
>>
>> _______________________________________________
>> Bridge mailing list
>> Bridge@lists.linux-foundation.org
>> https://lists.linux-foundation.org/mailman/listinfo/bridge
>
> It is a debatable whether this is correct behaviour.
> My current opinion is that it needs to forward STP packets if
> STP is off. This would allow for loop detection by other bridges
> doing STP.
Also, if the bridge code forwards them, it's trivially easy to block
these packets with ebtables if that's the desired behavior. It's not
so easy to forward them if the bridge code drops them.
>
> Longer term, RSTP needs to be fully integrated and default to on.
> That way the average user will be safe from loops.
>
> --
> _______________________________________________
> Bridge mailing list
> Bridge@lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/bridge
>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [Bridge] brigde does not relay BPDU multicast pkgs
2009-05-08 16:02 ` Stephen Hemminger
2009-05-08 16:43 ` richardvoigt
@ 2009-05-10 17:47 ` Joakim Tjernlund
[not found] ` <OFD8A6DCB5.C299BC0C-ONC12575B2.006169DD-C12575B2.0061B705@LocalDomain>
2 siblings, 0 replies; 11+ messages in thread
From: Joakim Tjernlund @ 2009-05-10 17:47 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: bridge
Stephen Hemminger <shemminger@vyatta.com> wrote on 08/05/2009 18:02:26:
> On Fri, 8 May 2009 10:33:37 +0200
> Joakim Tjernlund <joakim.tjernlund@transmode.se> wrote:
>
> >
> > Hi List
> >
> > We have noticed that when STP is off in the linux bridge, it won't
> > relay STP pkts received from other bridges.
> > This feels like a bug(a bad one too). I hope this isn't
> > intentional behaviour?
> >
> > Jocke
> >
> > _______________________________________________
> > Bridge mailing list
> > Bridge@lists.linux-foundation.org
> > https://lists.linux-foundation.org/mailman/listinfo/bridge
>
> It is a debatable whether this is correct behaviour.
> My current opinion is that it needs to forward STP packets if
> STP is off. This would allow for loop detection by other bridges
> doing STP.
Exactly, I had a look at the bride code and it wasn't obvious
too me where to add the code to make this happen. Any pointers?
>
> Longer term, RSTP needs to be fully integrated and default to on.
> That way the average user will be safe from loops.
yes, please :)
Jocke
^ permalink raw reply [flat|nested] 11+ messages in thread[parent not found: <OFD8A6DCB5.C299BC0C-ONC12575B2.006169DD-C12575B2.0061B705@LocalDomain>]
* Re: [Bridge] brigde does not relay BPDU multicast pkgs
[not found] ` <OFD8A6DCB5.C299BC0C-ONC12575B2.006169DD-C12575B2.0061B705@LocalDomain>
@ 2009-05-12 9:43 ` Joakim Tjernlund
2009-05-12 13:06 ` Ross Vandegrift
0 siblings, 1 reply; 11+ messages in thread
From: Joakim Tjernlund @ 2009-05-12 9:43 UTC (permalink / raw)
Cc: Stephen Hemminger, bridge
Joakim Tjernlund/Transmode wrote on 10/05/2009 19:47:19:
>
> Stephen Hemminger <shemminger@vyatta.com> wrote on 08/05/2009 18:02:26:
>
> > On Fri, 8 May 2009 10:33:37 +0200
> > Joakim Tjernlund <joakim.tjernlund@transmode.se> wrote:
> >
> > >
> > > Hi List
> > >
> > > We have noticed that when STP is off in the linux bridge, it won't
> > > relay STP pkts received from other bridges.
> > > This feels like a bug(a bad one too). I hope this isn't
> > > intentional behaviour?
> > >
> > > Jocke
> > >
> > > _______________________________________________
> > > Bridge mailing list
> > > Bridge@lists.linux-foundation.org
> > > https://lists.linux-foundation.org/mailman/listinfo/bridge
> >
> > It is a debatable whether this is correct behaviour.
> > My current opinion is that it needs to forward STP packets if
> > STP is off. This would allow for loop detection by other bridges
> > doing STP.
>
> Exactly, I had a look at the bride code and it wasn't obvious
> too me where to add the code to make this happen. Any pointers?
Looking into this I got a question:
Should the bridge forward the whole bridge multicast group except PAUSE
or only the STP multicast address?
Jocke
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [Bridge] brigde does not relay BPDU multicast pkgs
2009-05-12 9:43 ` Joakim Tjernlund
@ 2009-05-12 13:06 ` Ross Vandegrift
2009-05-12 13:44 ` richardvoigt
2009-05-12 14:03 ` Joakim Tjernlund
0 siblings, 2 replies; 11+ messages in thread
From: Ross Vandegrift @ 2009-05-12 13:06 UTC (permalink / raw)
To: Joakim Tjernlund; +Cc: Stephen Hemminger, bridge
On Tue, May 12, 2009 at 11:43:17AM +0200, Joakim Tjernlund wrote:
> Looking into this I got a question:
> Should the bridge forward the whole bridge multicast group except PAUSE
> or only the STP multicast address?
If you're implementing that, it should only forward the STP address.
802.1X and LACP will be very suprised (and very broken) when their
PDUs start being forwarded to entities on other bridges...
Ross
--
Ross Vandegrift
ross@kallisti.us
"If the fight gets hot, the songs get hotter. If the going gets tough,
the songs get tougher."
--Woody Guthrie
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Bridge] brigde does not relay BPDU multicast pkgs
2009-05-12 13:06 ` Ross Vandegrift
@ 2009-05-12 13:44 ` richardvoigt
2009-05-12 13:52 ` Ross Vandegrift
2009-05-12 14:03 ` Joakim Tjernlund
1 sibling, 1 reply; 11+ messages in thread
From: richardvoigt @ 2009-05-12 13:44 UTC (permalink / raw)
To: Ross Vandegrift; +Cc: Stephen Hemminger, bridge, Joakim Tjernlund
On Tue, May 12, 2009 at 8:06 AM, Ross Vandegrift <ross@kallisti.us> wrote:
> On Tue, May 12, 2009 at 11:43:17AM +0200, Joakim Tjernlund wrote:
>> Looking into this I got a question:
>> Should the bridge forward the whole bridge multicast group except PAUSE
>> or only the STP multicast address?
>
> If you're implementing that, it should only forward the STP address.
>
> 802.1X and LACP will be very suprised (and very broken) when their
> PDUs start being forwarded to entities on other bridges...
They break when there's a simple hub on the network?
>
> Ross
>
> --
> Ross Vandegrift
> ross@kallisti.us
>
> "If the fight gets hot, the songs get hotter. If the going gets tough,
> the songs get tougher."
> --Woody Guthrie
> _______________________________________________
> Bridge mailing list
> Bridge@lists.linux-foundation.org
> https://lists.linux-foundation.org/mailman/listinfo/bridge
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Bridge] brigde does not relay BPDU multicast pkgs
2009-05-12 13:44 ` richardvoigt
@ 2009-05-12 13:52 ` Ross Vandegrift
0 siblings, 0 replies; 11+ messages in thread
From: Ross Vandegrift @ 2009-05-12 13:52 UTC (permalink / raw)
To: richardvoigt@gmail.com; +Cc: Stephen Hemminger, bridge, Joakim Tjernlund
On Tue, May 12, 2009 at 08:44:44AM -0500, richardvoigt@gmail.com wrote:
> > If you're implementing that, it should only forward the STP address.
> >
> > 802.1X and LACP will be very suprised (and very broken) when their
> > PDUs start being forwarded to entities on other bridges...
>
> They break when there's a simple hub on the network?
Correct. Both technologies depend on being run over point-to-point
ethernet links - they are communications between entities that manage
individual bridge port roles.
--
Ross Vandegrift
ross@kallisti.us
"If the fight gets hot, the songs get hotter. If the going gets tough,
the songs get tougher."
--Woody Guthrie
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [Bridge] brigde does not relay BPDU multicast pkgs
2009-05-12 13:06 ` Ross Vandegrift
2009-05-12 13:44 ` richardvoigt
@ 2009-05-12 14:03 ` Joakim Tjernlund
1 sibling, 0 replies; 11+ messages in thread
From: Joakim Tjernlund @ 2009-05-12 14:03 UTC (permalink / raw)
To: Ross Vandegrift; +Cc: Stephen Hemminger, bridge
Ross Vandegrift <ross@kallisti.us> wrote on 12/05/2009 15:06:22:
>
> On Tue, May 12, 2009 at 11:43:17AM +0200, Joakim Tjernlund wrote:
> > Looking into this I got a question:
> > Should the bridge forward the whole bridge multicast group except PAUSE
> > or only the STP multicast address?
>
> If you're implementing that, it should only forward the STP address.
>
> 802.1X and LACP will be very suprised (and very broken) when their
> PDUs start being forwarded to entities on other bridges...
>
> Ross
I just sent a patch "bridge: relay bridge multicast pkgs if !STP" to
the list. Let me know what you think.
Jocke
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2009-05-12 14:03 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-08 8:33 [Bridge] brigde does not relay BPDU multicast pkgs Joakim Tjernlund
2009-05-08 12:14 ` Ross Vandegrift
2009-05-08 12:27 ` Joakim Tjernlund
2009-05-08 16:02 ` Stephen Hemminger
2009-05-08 16:43 ` richardvoigt
2009-05-10 17:47 ` Joakim Tjernlund
[not found] ` <OFD8A6DCB5.C299BC0C-ONC12575B2.006169DD-C12575B2.0061B705@LocalDomain>
2009-05-12 9:43 ` Joakim Tjernlund
2009-05-12 13:06 ` Ross Vandegrift
2009-05-12 13:44 ` richardvoigt
2009-05-12 13:52 ` Ross Vandegrift
2009-05-12 14:03 ` Joakim Tjernlund
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox