From: Stephen Hemminger <shemminger@vyatta.com>
To: "Christian Benvenuti (benve)" <benve@cisco.com>
Cc: bridge@linux-foundation.org, Ed Swierk <eswierk@bigswitch.com>,
Nick Carter <ncarter100@gmail.com>,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
David Lamparter <equinox@diac24.net>
Subject: Re: [Bridge] [RFC] bridge: add netfilter hook for forwarding 802.1D group addresses
Date: Fri, 19 Aug 2011 15:24:15 -0700 [thread overview]
Message-ID: <20110819152415.00e1c795@nehalam.ftrdhcpuser.net> (raw)
In-Reply-To: <184D23435BECB444AB6B9D4630C8EC830258A300@XMB-RCD-303.cisco.com>
On Fri, 19 Aug 2011 17:18:04 -0500
"Christian Benvenuti (benve)" <benve@cisco.com> wrote:
> The patch description and the code are clearly saying that STP is
> an exception, but I am just worried about the users.
> Maybe a proper description in the iptables help is sufficient.
>
> Users may otherwise try to use this new hook for STP too
> (for example to generate logs or produce statistics/counters
> or divert STP traffic to userspace, etc).
STP traffic already goes to userspace. And gets processed
by the LOCAL_IN chain. So I don't think it is needed.
> Out of curiosity, ... if this gets accepted, shouldn't you provide
> NF_BR_LINK_LOCAL_OUT too?
> Or maybe you should call it NF_BR_LINK_LOCAL_FWD instead of
> NF_BR_LINK_LOCAL_IN?
Thanks, that is a better name, I'll change it in next version.
next prev parent reply other threads:[~2011-08-19 22:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAF5U64C+WgQhfJL3zfVnvzE7p=G61humQCObHGUxAvY2-MGAFQ@mail.gmail.com>
[not found] ` <CAF5U64CJTWDn8E9+XVLFsdaSbiu-4Rd9XmxZq7ReziRNZviO6Q@mail.gmail.com>
[not found] ` <20110812154545.79d8313f@nehalam.ftrdhcpuser.net>
[not found] ` <CAF5U64B_fb2tFMLHmK+zw3n6gmq+bYDyFnXhLE0ayssK5m+THA@mail.gmail.com>
2011-08-15 22:05 ` [Bridge] [RFC] bridge: allow passing link-local multicast Stephen Hemminger
2011-08-18 15:06 ` Nick Carter
2011-08-18 15:10 ` Stephen Hemminger
2011-08-18 15:52 ` Nick Carter
2011-08-18 16:39 ` Stephen Hemminger
2011-08-19 2:27 ` David Lamparter
2011-08-19 20:58 ` [Bridge] [RFC] bridge: add netfilter hook for forwarding 802.1D group addresses Stephen Hemminger
2011-08-19 22:18 ` Christian Benvenuti (benve)
2011-08-19 22:24 ` Stephen Hemminger [this message]
2011-08-20 15:31 ` Bart De Schuymer
2011-08-22 13:59 ` David Lamparter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110819152415.00e1c795@nehalam.ftrdhcpuser.net \
--to=shemminger@vyatta.com \
--cc=benve@cisco.com \
--cc=bridge@linux-foundation.org \
--cc=equinox@diac24.net \
--cc=eswierk@bigswitch.com \
--cc=ncarter100@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox