Ethernet Bridge development
 help / color / mirror / Atom feed
From: David Lamparter <equinox@diac24.net>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: bridge@linux-foundation.org, Ed Swierk <eswierk@bigswitch.com>,
	Nick Carter <ncarter100@gmail.com>,
	netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
	David Miller <davem@davemloft.net>,
	David Lamparter <equinox@diac24.net>
Subject: Re: [Bridge] [RFC] bridge: add netfilter hook for forwarding 802.1D group addresses
Date: Mon, 22 Aug 2011 15:59:29 +0200	[thread overview]
Message-ID: <20110822135929.GA611458@jupiter.n2.diac24.net> (raw)
In-Reply-To: <20110819135810.1a529ab2@nehalam.ftrdhcpuser.net>

On Fri, Aug 19, 2011 at 01:58:10PM -0700, Stephen Hemminger wrote:
> The IEEE standard expects that link local multicast packets will not
> be forwarded by a bridge. But there are cases like 802.1X which may
> require that packets be forwarded. For maximum flexibilty implement
> this via netfilter.
> 
> The netfilter chain is slightly different from other chains in that
> if packet is ACCEPTED by the chain, it means it should be forwarded.
> And if the packet verdict result is DROP, the packet is processed
> as a local packet.

Exactly this functionality already exists by way of the BROUTING chain
in the broute table. Currently, link-local packets are hardcodedly
treated as local before they even reach that chain. Nick's patch, in
conjunction with BROUTING, provides exactly what you're trying to do.

Now, without bridge netfilter, your patch becomes rather useless while
Nick's patch still allows per-group (and therefore per-protocol)
control.

Further, Nick's patch is considerably less intrusive.

I would therefore ask for Nick's patch to be merged.


-David


P.S.: this whole issue is starting to get rather annoying

      parent reply	other threads:[~2011-08-22 13:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAF5U64C+WgQhfJL3zfVnvzE7p=G61humQCObHGUxAvY2-MGAFQ@mail.gmail.com>
     [not found] ` <CAF5U64CJTWDn8E9+XVLFsdaSbiu-4Rd9XmxZq7ReziRNZviO6Q@mail.gmail.com>
     [not found]   ` <20110812154545.79d8313f@nehalam.ftrdhcpuser.net>
     [not found]     ` <CAF5U64B_fb2tFMLHmK+zw3n6gmq+bYDyFnXhLE0ayssK5m+THA@mail.gmail.com>
2011-08-15 22:05       ` [Bridge] [RFC] bridge: allow passing link-local multicast Stephen Hemminger
2011-08-18 15:06         ` Nick Carter
2011-08-18 15:10           ` Stephen Hemminger
2011-08-18 15:52             ` Nick Carter
2011-08-18 16:39               ` Stephen Hemminger
2011-08-19  2:27                 ` David Lamparter
2011-08-19 20:58                   ` [Bridge] [RFC] bridge: add netfilter hook for forwarding 802.1D group addresses Stephen Hemminger
2011-08-19 22:18                     ` Christian Benvenuti (benve)
2011-08-19 22:24                       ` Stephen Hemminger
2011-08-20 15:31                     ` Bart De Schuymer
2011-08-22 13:59                     ` David Lamparter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110822135929.GA611458@jupiter.n2.diac24.net \
    --to=equinox@diac24.net \
    --cc=bridge@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=eswierk@bigswitch.com \
    --cc=ncarter100@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox