* Re: [Bridge] [PATCH] bridge: return boolean instead of integer in br_multicast_is_router
[not found] <20180118233745.GA23355@embeddedor.com>
@ 2018-01-19 0:22 ` Stephen Hemminger
2018-01-22 21:13 ` David Miller
1 sibling, 0 replies; 2+ messages in thread
From: Stephen Hemminger @ 2018-01-19 0:22 UTC (permalink / raw)
To: Gustavo A. R. Silva; +Cc: netdev, bridge, David S. Miller, linux-kernel
On Thu, 18 Jan 2018 17:37:45 -0600
"Gustavo A. R. Silva" <garsilva@embeddedor.com> wrote:
> Return statements in functions returning bool should use
> true/false instead of 1/0.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
LGTM
Fixes: 85b352693264 ("bridge: Fix build error when IGMP_SNOOPING is not enabled")
Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Bridge] [PATCH] bridge: return boolean instead of integer in br_multicast_is_router
[not found] <20180118233745.GA23355@embeddedor.com>
2018-01-19 0:22 ` [Bridge] [PATCH] bridge: return boolean instead of integer in br_multicast_is_router Stephen Hemminger
@ 2018-01-22 21:13 ` David Miller
1 sibling, 0 replies; 2+ messages in thread
From: David Miller @ 2018-01-22 21:13 UTC (permalink / raw)
To: garsilva; +Cc: netdev, bridge, linux-kernel
From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Date: Thu, 18 Jan 2018 17:37:45 -0600
> Return statements in functions returning bool should use
> true/false instead of 1/0.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Applied to net-next.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-22 21:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20180118233745.GA23355@embeddedor.com>
2018-01-19 0:22 ` [Bridge] [PATCH] bridge: return boolean instead of integer in br_multicast_is_router Stephen Hemminger
2018-01-22 21:13 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox