* [PATCH] net: bridge: avoid redundant strlen() in show_backup_port()
@ 2026-11-17 16:51 Dmitry Antipov
2026-11-17 17:49 ` Joe Damato
2026-11-18 10:19 ` David Laight
0 siblings, 2 replies; 4+ messages in thread
From: Dmitry Antipov @ 2026-11-17 16:51 UTC (permalink / raw)
To: Nikolay Aleksandrov, Ido Schimmel; +Cc: bridge, netdev, Dmitry Antipov
In store_backup_port(), prefer strchrnul() over strchr() to
avoid redundant call to strlen().
Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
---
net/bridge/br_sysfs_if.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/net/bridge/br_sysfs_if.c b/net/bridge/br_sysfs_if.c
index 621d62a063d9..03205b3f465f 100644
--- a/net/bridge/br_sysfs_if.c
+++ b/net/bridge/br_sysfs_if.c
@@ -231,12 +231,12 @@ static ssize_t show_backup_port(struct net_bridge_port *p, char *buf)
static int store_backup_port(struct net_bridge_port *p, char *buf)
{
struct net_device *backup_dev = NULL;
- char *nl = strchr(buf, '\n');
+ char *nl = strchrnul(buf, '\n');
- if (nl)
+ if (*nl != '\0')
*nl = '\0';
- if (strlen(buf) > 0) {
+ if (nl - buf > 0) {
backup_dev = __dev_get_by_name(dev_net(p->dev), buf);
if (!backup_dev)
return -ENOENT;
--
2.56.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] net: bridge: avoid redundant strlen() in show_backup_port()
2026-11-17 16:51 [PATCH] net: bridge: avoid redundant strlen() in show_backup_port() Dmitry Antipov
@ 2026-11-17 17:49 ` Joe Damato
2026-11-17 17:56 ` Ido Schimmel
2026-11-18 10:19 ` David Laight
1 sibling, 1 reply; 4+ messages in thread
From: Joe Damato @ 2026-11-17 17:49 UTC (permalink / raw)
To: Dmitry Antipov; +Cc: Nikolay Aleksandrov, Ido Schimmel, bridge, netdev
On Tue, Nov 17, 2026 at 07:51:06PM +0300, Dmitry Antipov wrote:
> In store_backup_port(), prefer strchrnul() over strchr() to
> avoid redundant call to strlen().
a couple things:
- i dont't think the change is worth it because it feels like unnecessary
churn in a path that isn't a hot path. how many bytes are we really avoiding
counting here?
- commit message mentions store_backup_port but subject line says
show_backup_port, so commit would need to be respun
but imho i think this should be dropped
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: bridge: avoid redundant strlen() in show_backup_port()
2026-11-17 17:49 ` Joe Damato
@ 2026-11-17 17:56 ` Ido Schimmel
0 siblings, 0 replies; 4+ messages in thread
From: Ido Schimmel @ 2026-11-17 17:56 UTC (permalink / raw)
To: Joe Damato, Dmitry Antipov, Nikolay Aleksandrov, bridge, netdev
On Tue, Nov 17, 2026 at 09:49:18AM -0800, Joe Damato wrote:
> On Tue, Nov 17, 2026 at 07:51:06PM +0300, Dmitry Antipov wrote:
> > In store_backup_port(), prefer strchrnul() over strchr() to
> > avoid redundant call to strlen().
>
> a couple things:
>
> - i dont't think the change is worth it because it feels like unnecessary
> churn in a path that isn't a hot path. how many bytes are we really avoiding
> counting here?
>
> - commit message mentions store_backup_port but subject line says
> show_backup_port, so commit would need to be respun
>
> but imho i think this should be dropped
Yep.
pw-bot: rejected
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: bridge: avoid redundant strlen() in show_backup_port()
2026-11-17 16:51 [PATCH] net: bridge: avoid redundant strlen() in show_backup_port() Dmitry Antipov
2026-11-17 17:49 ` Joe Damato
@ 2026-11-18 10:19 ` David Laight
1 sibling, 0 replies; 4+ messages in thread
From: David Laight @ 2026-11-18 10:19 UTC (permalink / raw)
To: Dmitry Antipov; +Cc: Nikolay Aleksandrov, Ido Schimmel, bridge, netdev
On Tue, 17 Nov 2026 19:51:06 +0300
Dmitry Antipov <dmantipov@yandex.ru> wrote:
> In store_backup_port(), prefer strchrnul() over strchr() to
> avoid redundant call to strlen().
For most architectures I think the compiler optimises that strlen()
to a check of buf[0].
So you don't get the function call at all.
David
>
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
> ---
> net/bridge/br_sysfs_if.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/net/bridge/br_sysfs_if.c b/net/bridge/br_sysfs_if.c
> index 621d62a063d9..03205b3f465f 100644
> --- a/net/bridge/br_sysfs_if.c
> +++ b/net/bridge/br_sysfs_if.c
> @@ -231,12 +231,12 @@ static ssize_t show_backup_port(struct net_bridge_port *p, char *buf)
> static int store_backup_port(struct net_bridge_port *p, char *buf)
> {
> struct net_device *backup_dev = NULL;
> - char *nl = strchr(buf, '\n');
> + char *nl = strchrnul(buf, '\n');
>
> - if (nl)
> + if (*nl != '\0')
> *nl = '\0';
>
> - if (strlen(buf) > 0) {
> + if (nl - buf > 0) {
> backup_dev = __dev_get_by_name(dev_net(p->dev), buf);
> if (!backup_dev)
> return -ENOENT;
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-11-18 10:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-17 16:51 [PATCH] net: bridge: avoid redundant strlen() in show_backup_port() Dmitry Antipov
2026-11-17 17:49 ` Joe Damato
2026-11-17 17:56 ` Ido Schimmel
2026-11-18 10:19 ` David Laight
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox