From: netdev@kapio-technology.com
To: Ido Schimmel <idosch@idosch.org>
Cc: "Andrew Lunn" <andrew@lunn.ch>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Nikolay Aleksandrov" <razor@blackwall.org>,
"Kurt Kanzenbach" <kurt@linutronix.de>,
"Eric Dumazet" <edumazet@google.com>,
"Ivan Vecera" <ivecera@redhat.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"moderated list:ETHERNET BRIDGE"
<bridge@lists.linux-foundation.org>,
"Russell King" <linux@armlinux.org.uk>,
"Roopa Prabhu" <roopa@nvidia.com>,
kuba@kernel.org, "Paolo Abeni" <pabeni@redhat.com>,
"Clément Léger" <clement.leger@bootlin.com>,
"Christian Marangi" <ansuelsmth@gmail.com>,
"Woojung Huh" <woojung.huh@microchip.com>,
"Landen Chao" <Landen.Chao@mediatek.com>,
"Jiri Pirko" <jiri@resnulli.us>,
"Hauke Mehrtens" <hauke@hauke-m.de>,
"Sean Wang" <sean.wang@mediatek.com>,
"DENG Qingfang" <dqfext@gmail.com>,
"Claudiu Manoil" <claudiu.manoil@nxp.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
netdev@vger.kernel.org,
"open list" <linux-kernel@vger.kernel.org>,
"maintainer:MICROCHIP KSZ SERIES ETHERNET SWITCH DRIVER"
<UNGLinuxDriver@microchip.com>,
"open list:RENESAS RZ/N1 A5PSW SWITCH DRIVER"
<linux-renesas-soc@vger.kernel.org>,
"Vladimir Oltean" <olteanv@gmail.com>,
davem@davemloft.net
Subject: Re: [Bridge] [PATCH net-next 1/5] net: bridge: add dynamic flag to switchdev notifier
Date: Fri, 03 Feb 2023 17:27:43 +0100 [thread overview]
Message-ID: <4188a35c3c260d8ea2b5f8b2ac0ae6b2@kapio-technology.com> (raw)
In-Reply-To: <Y90y9u+4PxWk4b9E@shredder>
On 2023-02-03 17:14, Ido Schimmel wrote:
>
> OK, so can't this hunk:
>
> ```
> if (fdb_info->is_dyn)
> fdb_flags |= DSA_FDB_FLAG_DYNAMIC;
> ```
>
> Become:
>
> ```
> if (fdb_info->is_dyn && !fdb_info->added_by_user)
> fdb_flags |= DSA_FDB_FLAG_DYNAMIC;
> ```
>
> ?
>
> Then there is no need to fold 'added_by_user' into 'is_dyn' in the
> bridge driver. I *think* this is the change Vladimir asked you to do.
I suppose you mean?:
if (fdb_info->is_dyn && fdb_info->added_by_user)
fdb_flags |= DSA_FDB_FLAG_DYNAMIC;
next prev parent reply other threads:[~2023-02-03 16:27 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-30 17:34 [Bridge] [PATCH net-next 0/5] ATU and FDB synchronization on locked ports Hans J. Schultz
2023-01-30 17:34 ` [Bridge] [PATCH net-next 1/5] net: bridge: add dynamic flag to switchdev notifier Hans J. Schultz
2023-02-01 18:10 ` Ido Schimmel
2023-02-02 7:28 ` netdev
2023-02-02 16:11 ` Ido Schimmel
2023-02-02 16:38 ` netdev
2023-02-03 16:14 ` Ido Schimmel
2023-02-03 16:26 ` Vladimir Oltean
2023-02-03 16:27 ` netdev [this message]
2023-02-03 17:06 ` Ido Schimmel
2023-01-30 17:34 ` [Bridge] [PATCH net-next 2/5] net: dsa: propagate flags down towards drivers Hans J. Schultz
2023-01-30 17:34 ` [Bridge] [PATCH net-next 3/5] drivers: net: dsa: add fdb entry flags incoming to switchcore drivers Hans J. Schultz
2023-01-31 18:54 ` Simon Horman
2023-02-02 16:45 ` netdev
2023-02-03 8:17 ` Simon Horman
2023-02-03 18:41 ` netdev
2023-01-30 17:34 ` [Bridge] [PATCH net-next 4/5] net: bridge: ensure FDB offloaded flag is handled as needed Hans J. Schultz
2023-02-01 18:24 ` Ido Schimmel
2023-02-02 7:32 ` netdev
2023-01-30 17:34 ` [Bridge] [PATCH net-next 5/5] net: dsa: mv88e6xxx: implementation of dynamic ATU entries Hans J. Schultz
2023-01-31 18:56 ` Simon Horman
2023-02-02 17:00 ` netdev
2023-02-03 8:20 ` Simon Horman
2023-02-03 20:44 ` Vladimir Oltean
2023-02-04 8:12 ` Simon Horman
2023-02-04 8:48 ` netdev
2023-02-06 16:02 ` Simon Horman
2023-02-14 21:14 ` Hans Schultz
2023-02-17 17:44 ` Vladimir Oltean
2023-02-20 14:11 ` Simon Horman
2023-01-31 19:25 ` [Bridge] [PATCH net-next 0/5] ATU and FDB synchronization on locked ports Ido Schimmel
2023-02-02 7:37 ` netdev
2023-02-02 15:43 ` Ido Schimmel
2023-02-02 16:19 ` netdev
2023-02-02 16:36 ` Ido Schimmel
2023-02-03 21:14 ` Vladimir Oltean
2023-02-02 17:18 ` netdev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4188a35c3c260d8ea2b5f8b2ac0ae6b2@kapio-technology.com \
--to=netdev@kapio-technology.com \
--cc=Landen.Chao@mediatek.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=bridge@lists.linux-foundation.org \
--cc=claudiu.manoil@nxp.com \
--cc=clement.leger@bootlin.com \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=hauke@hauke-m.de \
--cc=idosch@idosch.org \
--cc=ivecera@redhat.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=kurt@linutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
--cc=sean.wang@mediatek.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox