From: Petr Machata <petrm@nvidia.com>
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: <netdev@vger.kernel.org>, <idosch@nvidia.com>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <horms@kernel.org>, <roopa@nvidia.com>,
<bridge@lists.linux.dev>, <andrew+netdev@lunn.ch>,
<dlstevens@us.ibm.com>, <amwang@redhat.com>
Subject: Re: [PATCH net v2 2/2] vxlan: fix reading neigh ha
Date: Wed, 19 Aug 2026 10:32:54 +0200 [thread overview]
Message-ID: <87o6ey7bnt.fsf@pmachata.org> (raw)
In-Reply-To: <20260818150756.890025-3-razor@blackwall.org> (Nikolay Aleksandrov's message of "Tue, 18 Aug 2026 18:07:56 +0300")
Nikolay Aleksandrov <razor@blackwall.org> writes:
> Currently arp/neigh_reduce read neigh ha directly which can lead to
> partial reads while the neigh is being updated. Use neigh_ha_snapshot to
> take a stable snapshot of the address similar to route_shortcircuit which
> already does the right thing.
>
> Fixes: e4f67addf158 ("add DOVE extensions for VXLAN")
> Fixes: f564f45c4518 ("vxlan: add ipv6 proxy support")
> Signed-off-by: Nikolay Aleksandrov <razor@blackwall.org>
Reviewed-by: Petr Machata <petrm@nvidia.com>
> @@ -1935,7 +1938,8 @@ static int arp_reduce(struct net_device *dev, struct sk_buff *skb, __be32 vni)
>
> #if IS_ENABLED(CONFIG_IPV6)
> static struct sk_buff *vxlan_na_create(struct sk_buff *request,
> - struct neighbour *n, bool isrouter)
> + struct neighbour *n, u8 *ha,
(Likewise, I think this could be const u8 *ha.)
> + bool isrouter)
> {
> struct net_device *dev = request->dev;
> struct sk_buff *reply;
prev parent reply other threads:[~2026-08-19 8:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 15:07 [PATCH net v2 0/2] bridge/vxlan: fix reading neigh ha without synchronization Nikolay Aleksandrov
2026-08-18 15:07 ` [PATCH net v2 1/2] net: bridge: arp/nd proxy: fix reading neigh ha Nikolay Aleksandrov
2026-08-19 8:31 ` Petr Machata
2026-08-18 15:07 ` [PATCH net v2 2/2] vxlan: " Nikolay Aleksandrov
2026-08-19 8:32 ` Petr Machata [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o6ey7bnt.fsf@pmachata.org \
--to=petrm@nvidia.com \
--cc=amwang@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=bridge@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=dlstevens@us.ibm.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox