From: Petr Machata <petrm@nvidia.com>
To: Nikolay Aleksandrov <razor@blackwall.org>
Cc: <netdev@vger.kernel.org>, <idosch@nvidia.com>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <horms@kernel.org>, <roopa@nvidia.com>,
<bridge@lists.linux.dev>, <andrew+netdev@lunn.ch>,
<dlstevens@us.ibm.com>, <amwang@redhat.com>
Subject: Re: [PATCH net v2 1/2] net: bridge: arp/nd proxy: fix reading neigh ha
Date: Wed, 19 Aug 2026 10:31:52 +0200 [thread overview]
Message-ID: <87tsoq7bpj.fsf@pmachata.org> (raw)
In-Reply-To: <20260818150756.890025-2-razor@blackwall.org> (Nikolay Aleksandrov's message of "Tue, 18 Aug 2026 18:07:55 +0300")
Nikolay Aleksandrov <razor@blackwall.org> writes:
> Currently neigh ha address is read directly, but that can result in
> torn/partial reads if the neigh is being updated. Use neigh_ha_snapshot
> to take a stable snapshot of the address.
>
> Fixes: 057658cb33fb ("bridge: suppress arp pkts on BR_NEIGH_SUPPRESS ports")
> Fixes: ed842faeb2bd ("bridge: suppress nd pkts on BR_NEIGH_SUPPRESS ports")
> Signed-off-by: Nikolay Aleksandrov <razor@blackwall.org>
Reviewed-by: Petr Machata <petrm@nvidia.com>
> @@ -252,7 +254,7 @@ struct nd_msg *br_is_nd_neigh_msg(const struct sk_buff *skb, struct nd_msg *msg)
> }
>
> static void br_nd_send(struct net_bridge *br, struct net_bridge_port *p,
> - struct sk_buff *request, struct neighbour *n,
> + struct sk_buff *request, struct neighbour *n, u8 *ha,
(This looks like it could be const u8 *ha though.)
> __be16 vlan_proto, u16 vlan_tci)
> {
> struct net_device *dev = request->dev;
next prev parent reply other threads:[~2026-08-19 8:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 15:07 [PATCH net v2 0/2] bridge/vxlan: fix reading neigh ha without synchronization Nikolay Aleksandrov
2026-08-18 15:07 ` [PATCH net v2 1/2] net: bridge: arp/nd proxy: fix reading neigh ha Nikolay Aleksandrov
2026-08-19 8:31 ` Petr Machata [this message]
2026-08-18 15:07 ` [PATCH net v2 2/2] vxlan: " Nikolay Aleksandrov
2026-08-19 8:32 ` Petr Machata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tsoq7bpj.fsf@pmachata.org \
--to=petrm@nvidia.com \
--cc=amwang@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=bridge@lists.linux.dev \
--cc=davem@davemloft.net \
--cc=dlstevens@us.ibm.com \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox