[Buildroot] [bug] undefined symbol BR2_PACKAGE_LIBDAEMON

[Buildroot] [bug] undefined symbol BR2_PACKAGE_LIBDAEMON

[Cristian Ionescu-Idbohrn]

package/avahi/Config.in:3:warning: 'select' used by config symbol
'BR2_PACKAGE_AVAHI' refer to undefined symbol 'BR2_PACKAGE_LIBDAEMON'


Cheers,

-- 
Cristian

[Buildroot] [PATCH] undefined symbol BR2_PACKAGE_LIBDAEMON

[Rick Foos]

Had the same problem here. Attached is a simple patch to fix it preserving 
the current function.

The libdaemon Config.in was never included in the past, but the libdaemon.mk 
file was in place.

Avahi.mk refereces the libdaemon make target.

Now that the select dependency is in avahi/Config.in, the missing source 
libdaemon/Config.in is a problem.

Cheers,
Rick

----- Original Message ----- 
From: "Cristian Ionescu-Idbohrn" <cristian.ionescu-idbohrn@axis.com>
To: <buildroot@uclibc.org>
Sent: Friday, August 03, 2007 2:20 PM
Subject: [Buildroot] [bug] undefined symbol BR2_PACKAGE_LIBDAEMON


> package/avahi/Config.in:3:warning: 'select' used by config symbol
> 'BR2_PACKAGE_AVAHI' refer to undefined symbol 'BR2_PACKAGE_LIBDAEMON'
>
>
> Cheers,
>
> -- 
> Cristian
> _______________________________________________
> buildroot mailing list
> buildroot at uclibc.org
> http://busybox.net/mailman/listinfo/buildroot
>
>
>
> -- 
> No virus found in this incoming message.
> Checked by AVG Free Edition.
> Version: 7.5.476 / Virus Database: 269.11.2/933 - Release Date: 8/2/2007 
> 2:22 PM
>
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libdaemon-avahi.patch
Type: application/octet-stream
Size: 423 bytes
Desc: not available
Url : http://busybox.net/lists/buildroot/attachments/20070803/c4b11665/attachment.obj 

[Buildroot] [PATCH] undefined symbol BR2_PACKAGE_LIBDAEMON

[Cristian Ionescu-Idbohrn]

On Fri, 3 Aug 2007, Rick Foos wrote:

> Had the same problem here. Attached is a simple patch to fix it
> preserving the current function.

Thanks.

> The libdaemon Config.in was never included in the past, but the
> libdaemon.mk file was in place.
>
> Avahi.mk refereces the libdaemon make target.
>
> Now that the select dependency is in avahi/Config.in, the missing source
> libdaemon/Config.in is a problem.

Right.  That was a miss.
libdaemon is not "networking" related in any way, AFAIK.  I would think
a better place is among the "Other stuff", one level above networking
(next to the other libs).

Index: package/Config.in
===================================================================
--- package/Config.in   (revision 19307)
+++ package/Config.in   (working copy)
@@ -63,6 +63,7 @@
 if !BR2_PACKAGE_BUSYBOX_HIDE_OTHERS
 source "package/less/Config.in"
 endif
+source "package/libdaemon/Config.in"
 source "package/libelf/Config.in"
 source "package/libevent/Config.in"
 source "package/libfloat/Config.in"


Cheers,

-- 
Cristian

[Buildroot] [PATCH] undefined symbol BR2_PACKAGE_LIBDAEMON

[Rick Foos]

> On Fri, 3 Aug 2007, Rick Foos wrote:
>
>> Had the same problem here. Attached is a simple patch to fix it
>> preserving the current function.
>
> Thanks.
>
>> The libdaemon Config.in was never included in the past, but the
>> libdaemon.mk file was in place.
>>
>> Avahi.mk refereces the libdaemon make target.
>>
>> Now that the select dependency is in avahi/Config.in, the missing source
>> libdaemon/Config.in is a problem.
>
> Right.  That was a miss.
> libdaemon is not "networking" related in any way, AFAIK.  I would think
> a better place is among the "Other stuff", one level above networking
> (next to the other libs).

I knew that either place I put it would be wrong:)

avahi appears to be the only package that depends on libdaemon. A minimalist 
approach, only allowing libdaemon if it was required would place it with 
avahi.

As a general service, it should go in a general category like other, but to 
the minimalist it then can take up space when it is not really required.

I chose the minimalist approach. Whomever commits this to the tree can 
decide.

>
> Index: package/Config.in
> ===================================================================
> --- package/Config.in   (revision 19307)
> +++ package/Config.in   (working copy)
> @@ -63,6 +63,7 @@
> if !BR2_PACKAGE_BUSYBOX_HIDE_OTHERS
> source "package/less/Config.in"
> endif
> +source "package/libdaemon/Config.in"
> source "package/libelf/Config.in"
> source "package/libevent/Config.in"
> source "package/libfloat/Config.in"
>
>
> Cheers,
>
> -- 
> Cristian
> _______________________________________________
> buildroot mailing list
> buildroot at uclibc.org
> http://busybox.net/mailman/listinfo/buildroot
>
>