[Buildroot] svn commit: trunk/buildroot: package target/device/Atmel

[Buildroot] svn commit: trunk/buildroot: package target/device/Atmel

[ulf at uclibc.org]

Author: ulf
Date: 2007-07-22 10:17:03 -0700 (Sun, 22 Jul 2007)
New Revision: 19194

Log:
ATMEL_MIRROR needs to be available before toolchain is built

Modified:
   trunk/buildroot/package/Makefile.in
   trunk/buildroot/target/device/Atmel/Makefile.in


Changeset:
Modified: trunk/buildroot/package/Makefile.in
===================================================================
--- trunk/buildroot/package/Makefile.in	2007-07-22 17:04:11 UTC (rev 19193)
+++ trunk/buildroot/package/Makefile.in	2007-07-22 17:17:03 UTC (rev 19194)
@@ -106,6 +106,11 @@
 TOOL_BUILD_DIR=$(BASE_DIR)/$(TOPDIR_PREFIX)toolchain_build_$(TOOLCHAIN_EXTERNAL_PREFIX)
 TARGET_PATH="$(STAGING_DIR)/bin:$(TOOL_BUILD_DIR)/bin:$(TOOLCHAIN_EXTERNAL_PATH)/bin:$(PATH)"
 IMAGE:=$(BINARIES_DIR)/rootfs.$(TOOLCHAIN_EXTERNAL_PREFIX)
+
+# ATMEL_MIRROR Needs to be available before toolchain is built
+ATMEL_MIRROR:=$(strip  $(subst ",, $(BR2_ATMEL_MIRROR)))
+#"))
+
 REAL_GNU_TARGET_NAME=$(TOOLCHAIN_EXTERNAL_PREFIX)
 GNU_TARGET_NAME=$(TOOLCHAIN_EXTERNAL_PREFIX)
 KERNEL_CROSS=$(TOOLCHAIN_EXTERNAL_PATH)/bin/$(TOOLCHAIN_EXTERNAL_PREFIX)-

Modified: trunk/buildroot/target/device/Atmel/Makefile.in
===================================================================
--- trunk/buildroot/target/device/Atmel/Makefile.in	2007-07-22 17:04:11 UTC (rev 19193)
+++ trunk/buildroot/target/device/Atmel/Makefile.in	2007-07-22 17:17:03 UTC (rev 19194)
@@ -1,6 +1,4 @@
 # *******************************************************************
-ATMEL_MIRROR:=$(strip  $(subst ",, $(BR2_ATMEL_MIRROR)))
-#"))
 
 ifeq ($(strip $(BR2_TARGET_ATMEL)),y)
 ATMEL_PATH:=target/device/Atmel

[Buildroot] svn commit: trunk/buildroot: package target/device/Atmel

[Steven J. Hill]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

ulf at uclibc.org wrote:
> Author: ulf
> Date: 2007-07-22 10:17:03 -0700 (Sun, 22 Jul 2007)
> New Revision: 19194
> 
> Log:
> ATMEL_MIRROR needs to be available before toolchain is built
> 
> Modified:
>    trunk/buildroot/package/Makefile.in
>    trunk/buildroot/target/device/Atmel/Makefile.in
> 
Ulf,

Please do not put any platform dependent code in the 'package/Makefile.in'
file. It does not belong there. I will revert your change.

- -Steve
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGo7dmgyK5H2Ic36cRAu2iAKCdcOpB0Xwv+lWdW8SuSmcFuoZfTQCgikWJ
r4Y8vsk7v8Pj3yK/JivwQ+E=
=ev7a
-----END PGP SIGNATURE-----

[Buildroot] svn commit: trunk/buildroot: packagetarget/device/Atmel

[Ulf Samuelsson]

> ulf at uclibc.org wrote:
>> Author: ulf
>> Date: 2007-07-22 10:17:03 -0700 (Sun, 22 Jul 2007)
>> New Revision: 19194
>> 
>> Log:
>> ATMEL_MIRROR needs to be available before toolchain is built
>> 
>> Modified:
>>    trunk/buildroot/package/Makefile.in
>>    trunk/buildroot/target/device/Atmel/Makefile.in
>> 
> Ulf,
> 
> Please do not put any platform dependent code in the 'package/Makefile.in'
> file. It does not belong there. I will revert your change.
> 


While it is used for target/device/Atmel files, it is also needed
to download binutils/gcc/gdb tarballs for AVR32 architecture support.
If it is defined in target/device/Atmel, then it is not defined during
the toolchain build. causing this to fail.

The alternative is to submit a 7-10 MB patch+ for the buildroot tree
with all the AVR32 architecture patches, which I thought was a bad idea.

If you don't like that location, you need to come up with a location
where to put the definition of ATMEL_MIRROR *before*
"include toolchain/*/*.mk" in the main Makefile

The main Makefile seems to be the only other suitable location.


Best Regards
Ulf Samuelsson

[Buildroot] svn commit: trunk/buildroot: packagetarget/device/Atmel

[Steven J. Hill]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Ulf Samuelsson wrote:
> 
> While it is used for target/device/Atmel files, it is also needed
> to download binutils/gcc/gdb tarballs for AVR32 architecture support.
> If it is defined in target/device/Atmel, then it is not defined during
> the toolchain build. causing this to fail.
> 
Honestly, I would rather see the directives in each of the toolchain/*/*.mk
files. The top-level files should be kept clean of architecture/platform
directives.

- -Steve
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2.2 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGpBihgyK5H2Ic36cRAhfHAJ0fZeaDN+VRtDPeVDNnQcXAxHU1uQCfcLYc
+ZR60lZxpiiLQ63kWdLGwo0=
=o3sy
-----END PGP SIGNATURE-----

[Buildroot] svn commit: trunk/buildroot: packagetarget/device/Atmel

[Ulf Samuelsson]

> Ulf Samuelsson wrote:
>> 
>> While it is used for target/device/Atmel files, it is also needed
>> to download binutils/gcc/gdb tarballs for AVR32 architecture support.
>> If it is defined in target/device/Atmel, then it is not defined during
>> the toolchain build. causing this to fail.
>> 
> Honestly, I would rather see the directives in each of the toolchain/*/*.mk
> files. The top-level files should be kept clean of architecture/platform
> directives.
> 

It is not "architecture/platform directives", it is a *site* on Internet,
similar to BR2_SOURCEFORGE_MIRROR which
conceivably also can contain the location of a package.

Best Regards
Ulf Samuelsson

[Buildroot] svn commit: trunk/buildroot: packagetarget/device/Atmel

[Ulf Samuelsson]

----- Original Message ----- 
From: "Ulf Samuelsson" <ulf@atmel.com>
To: "Steven J. Hill" <sjhill@realitydiluted.com>
Cc: <buildroot@uclibc.org>
Sent: Monday, July 23, 2007 8:25 AM
Subject: Re: [Buildroot] svn commit: trunk/buildroot: packagetarget/device/Atmel


> Ulf Samuelsson wrote:
>> 
>> While it is used for target/device/Atmel files, it is also needed
>> to download binutils/gcc/gdb tarballs for AVR32 architecture support.
>> If it is defined in target/device/Atmel, then it is not defined during
>> the toolchain build. causing this to fail.
>> 
> Honestly, I would rather see the directives in each of the toolchain/*/*.mk
> files. The top-level files should be kept clean of architecture/platform
> directives.
> 

It is not "architecture/platform directives", it is a *site* on Internet,
similar to BR2_SOURCEFORGE_MIRROR which
conceivably also can contain the location of a package.


==> Additionaly, ATMEL_MIRROR will (long term) be an alternative site for all packages.
        I can rename it to SOURCE_MIRROR, if that makes you happier...

Best Regards
Ulf Samuelsson

[Buildroot] svn commit: trunk/buildroot:packagetarget/device/Atmel

[Ulf Samuelsson]

----- Original Message ----- 
From: "Hans-Christian Egtvedt" <hcegtvedt@atmel.com>
To: "Ulf Samuelsson" <ulf@atmel.com>
Cc: "Steven J. Hill" <sjhill@realitydiluted.com>; <buildroot@uclibc.org>
Sent: Thursday, July 26, 2007 7:49 AM
Subject: Re: [Buildroot] svn commit: trunk/buildroot:packagetarget/device/Atmel


> 
> On Mon, 2007-07-23 at 00:49 +0200, Ulf Samuelsson wrote:
>> > ulf at uclibc.org wrote:
> 
> <cut adding ATMEL_MIRROR and revert>
> 
>> While it is used for target/device/Atmel files, it is also needed
>> to download binutils/gcc/gdb tarballs for AVR32 architecture support.
>> If it is defined in target/device/Atmel, then it is not defined during
>> the toolchain build. causing this to fail.
>> 
>> The alternative is to submit a 7-10 MB patch+ for the buildroot tree
>> with all the AVR32 architecture patches, which I thought was a bad idea.
> 
> I hope to get these patches smaller, many of them contain 90% hacking on
> the automake system.
> 
> Right now they are roughly 8 MB for all the tools (gcc, binutils, gdb,
> strace, uClibc and kernel). But this is in plain text, and they compress
> well.
> 
> <cut location discussion>
> 
> -- 
> With kind regards,
> 
> Hans-Christian Egtvedt, siv.ing. (M.Sc.)
> Applications Engineer - AVR32 System Solutions - Atmel Norway
> 


I think that until the AVR32 support is fully integrated in the GCC, it is probably 
just as well, downloading prepatched source instead of running autotool,
unless you can make sure that *any* version of autotools will work.

We can't expect a user to have a certain version of autotool, unless we 
download and build it as part of buildroot.

Best Regards
Ulf Samuelsson

[Buildroot] svn commit: trunk/buildroot: packagetarget/device/Atmel

[Hans-Christian Egtvedt]

On Mon, 2007-07-23 at 00:49 +0200, Ulf Samuelsson wrote:
> > ulf at uclibc.org wrote:

<cut adding ATMEL_MIRROR and revert>

> While it is used for target/device/Atmel files, it is also needed
> to download binutils/gcc/gdb tarballs for AVR32 architecture support.
> If it is defined in target/device/Atmel, then it is not defined during
> the toolchain build. causing this to fail.
> 
> The alternative is to submit a 7-10 MB patch+ for the buildroot tree
> with all the AVR32 architecture patches, which I thought was a bad idea.

I hope to get these patches smaller, many of them contain 90% hacking on
the automake system.

Right now they are roughly 8 MB for all the tools (gcc, binutils, gdb,
strace, uClibc and kernel). But this is in plain text, and they compress
well.

<cut location discussion>

-- 
With kind regards,

Hans-Christian Egtvedt, siv.ing. (M.Sc.)
Applications Engineer - AVR32 System Solutions - Atmel Norway
-- 
Mvh
Hans-Christian Egtvedt

[Buildroot] svn commit: trunk/buildroot:packagetarget/device/Atmel

[Hans-Christian Egtvedt]

On Thu, 2007-07-26 at 08:03 +0200, Ulf Samuelsson wrote:
> > On Mon, 2007-07-23 at 00:49 +0200, Ulf Samuelsson wrote:
> >> > ulf at uclibc.org wrote: 

<cut info about AVR32 toolchain patches>

> > Right now they are roughly 8 MB for all the tools (gcc, binutils, gdb,
> > strace, uClibc and kernel). But this is in plain text, and they compress
> > well.
>
> I think that until the AVR32 support is fully integrated in the GCC, it is probably 
> just as well, downloading prepatched source instead of running autotool,
> unless you can make sure that *any* version of autotools will work.

I do not have any problems to ship Buildroot with these quite large
patches, the question is if it is appropriate. We can keep the size down
after unpacking Buildroot by bzip'ing them.

Having AVR32 support integrated in GNU toolchain will take some time.

> We can't expect a user to have a certain version of autotool, unless we 
> download and build it as part of buildroot.

Buildroot already depends on different autotools, IIRC I had to install
automake1.8 to be able to build libdaemon.

-- 
With kind regards,

Hans-Christian Egtvedt, siv.ing. (M.Sc.)
Applications Engineer - AVR32 System Solutions - Atmel Norway
-- 
Mvh
Hans-Christian Egtvedt

[Buildroot] svn commit: trunk/buildroot:packagetarget/device/Atmel

[Ulf Samuelsson]

tor 2007-07-26 klockan 09:29 +0200 skrev Hans-Christian Egtvedt:
> On Thu, 2007-07-26 at 08:03 +0200, Ulf Samuelsson wrote:
> > > On Mon, 2007-07-23 at 00:49 +0200, Ulf Samuelsson wrote:
> > >> > ulf at uclibc.org wrote: 
> 
> <cut info about AVR32 toolchain patches>
> 
> > > Right now they are roughly 8 MB for all the tools (gcc, binutils, gdb,
> > > strace, uClibc and kernel). But this is in plain text, and they compress
> > > well.
> >

The full buildroot is about 6 MB so this is more than doubling
the download time.
At home in Stockholm with 100 Mbps Ethernet it is less of a problem,
but where I am now with 10-20 kB/s Internet access it sucks...
A prepatched toolchain which is downloaded once is a much
more attractive alternative, so this is what I am going to submit.

Best Regards
Ulf Samuelsson.

[Buildroot] svn commit: trunk/buildroot:packagetarget/device/Atmel

[Hans-Christian Egtvedt]

On Thu, 2007-07-26 at 18:55 +0200, Ulf Samuelsson wrote:
> tor 2007-07-26 klockan 09:29 +0200 skrev Hans-Christian Egtvedt:
> > On Thu, 2007-07-26 at 08:03 +0200, Ulf Samuelsson wrote:
> > > > On Mon, 2007-07-23 at 00:49 +0200, Ulf Samuelsson wrote:
> > > >> > ulf at uclibc.org wrote: 
> > 
> > <cut info about AVR32 toolchain patches>
> > 
> > > > Right now they are roughly 8 MB for all the tools (gcc, binutils, gdb,
> > > > strace, uClibc and kernel). But this is in plain text, and they compress
> > > > well.
> > >
> 
> The full buildroot is about 6 MB so this is more than doubling
> the download time.
> At home in Stockholm with 100 Mbps Ethernet it is less of a problem,
> but where I am now with 10-20 kB/s Internet access it sucks...
> A prepatched toolchain which is downloaded once is a much
> more attractive alternative, so this is what I am going to submit.

Only problem is that we do not (yet) have a prepatched toolchain
available on the net which is IMHO working.

When bzip'ing a 3 MB text file it usually ends up well below 500k, still
to big though :/

-- 
Mvh
Hans-Christian Egtvedt

[Buildroot] svn commit: trunk/buildroot:packagetarget/device/Atmel

[Ulf Samuelsson]

fre 2007-07-27 klockan 08:07 +0200 skrev Hans-Christian Egtvedt:
> On Thu, 2007-07-26 at 18:55 +0200, Ulf Samuelsson wrote:
> > tor 2007-07-26 klockan 09:29 +0200 skrev Hans-Christian Egtvedt:
> > > On Thu, 2007-07-26 at 08:03 +0200, Ulf Samuelsson wrote:
> > > > > On Mon, 2007-07-23 at 00:49 +0200, Ulf Samuelsson wrote:
> > > > >> > ulf at uclibc.org wrote: 
> > > 
> > > <cut info about AVR32 toolchain patches>
> > > 
> > > > > Right now they are roughly 8 MB for all the tools (gcc, binutils, gdb,
> > > > > strace, uClibc and kernel). But this is in plain text, and they compress
> > > > > well.
> > > >
> > 
> > The full buildroot is about 6 MB so this is more than doubling
> > the download time.
> > At home in Stockholm with 100 Mbps Ethernet it is less of a problem,
> > but where I am now with 10-20 kB/s Internet access it sucks...
> > A prepatched toolchain which is downloaded once is a much
> > more attractive alternative, so this is what I am going to submit.
> 
> Only problem is that we do not (yet) have a prepatched toolchain
> available on the net which is IMHO working.

Yesterday we didn't, but now there are stuff available at
$(BR2_ATMEL_MIRROR)/Source

binutils-2.17
gcc-4.1.2
gdb-6.4
uclibc-0.9.28.3

with Atmel and buildroot patches.

Plan to add AVR32 specific directories in buildroot so that new patches
can be against those prepateched versions.


> 
> When bzip'ing a 3 MB text file it usually ends up well below 500k, still
> to big though :/
> 

Best Regards
Ulf Samuelsson

[Buildroot] svn commit: trunk/buildroot:packagetarget/device/Atmel

[Hans-Christian Egtvedt]

On Fri, 2007-07-27 at 08:07 +0200, Hans-Christian Egtvedt wrote:
> On Thu, 2007-07-26 at 18:55 +0200, Ulf Samuelsson wrote:
> > tor 2007-07-26 klockan 09:29 +0200 skrev Hans-Christian Egtvedt:
> > > On Thu, 2007-07-26 at 08:03 +0200, Ulf Samuelsson wrote:
> > > > > On Mon, 2007-07-23 at 00:49 +0200, Ulf Samuelsson wrote:
> > > > >> > ulf at uclibc.org wrote: 

<cut AVR32 patch size about 8 MB extracted>
 
> > The full buildroot is about 6 MB so this is more than doubling
> > the download time.
> > At home in Stockholm with 100 Mbps Ethernet it is less of a problem,
> > but where I am now with 10-20 kB/s Internet access it sucks...
> > A prepatched toolchain which is downloaded once is a much
> > more attractive alternative, so this is what I am going to submit.
> 
> Only problem is that we do not (yet) have a prepatched toolchain
> available on the net which is IMHO working.
> 
> When bzip'ing a 3 MB text file it usually ends up well below 500k, still
> to big though :/

Total size of a bzip2 -9 compressed tarball is 5.6 MB. It contains all
the AVR32 patches and a BR2 snapshot from 20070718. IMHO not that large.

Most users will have to download the Linux kernel and a lot of other
quite large applications.

-- 
With kind regards,

Hans-Christian Egtvedt, siv.ing. (M.Sc.)
Applications Engineer - AVR32 System Solutions - Atmel Norway