Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Hans-Christian Egtvedt <hcegtvedt@atmel.com>
To: buildroot@busybox.net
Subject: [Buildroot] mplayer-package doesn't build for other	architectures than avr32
Date: Wed, 29 Aug 2007 10:48:09 +0200	[thread overview]
Message-ID: <1188377289.12874.13.camel@localhost.localdomain> (raw)
In-Reply-To: <f90898420708290133i7ac1f31dkbdd53649945091b3@mail.gmail.com>

On Wed, 2007-08-29 at 10:33 +0200, Simon Pasch wrote:
> It's the same issues as in libmad-package:
> There are architecture-specific patches. (by the way...one should be
> removed, as they can't be used both at the same time.
> AVR32-Users...tell us which one is the good one!)

I did, but I think the email got drowned on the list.

Remove package/mplayer/mplayer-1.0rc1-avr32-support.patch

> I added an extra command to the Makefile, because the build fails on
> my x86. Don't know if this breaks the build on other architectures.
> So either a sed-command can be used inside the Makefile or an extra
> architecture-specific patch (but it's not that simple with $(ARCH),
> because then you need patches for i386, i686, etc).

-fomit-frame-pointer is not architecture dependant, so should be fine to
add it. I have not checked if it breaks the AVR32 build.

> This is my sed-command approach. (you have to manually rename the avr-patches):
> 
> --- buildroot/package/mplayer/mplayer.mk.old	2007-08-28 09:15:43.000000000 +0200
> +++ buildroot/package/mplayer/mplayer.mk	2007-08-29 10:02:07.000000000 +0200
> @@ -22,7 +22,9 @@
> 
>  $(MPLAYER_DIR)/.unpacked: $(DL_DIR)/$(MPLAYER_SOURCE)
>  	$(MPLAYER_CAT) $(DL_DIR)/$(MPLAYER_SOURCE) | tar -C $(BUILD_DIR)
> $(TAR_OPTIONS) -
> -	toolchain/patch-kernel.sh $(MPLAYER_DIR) package/mplayer/
> mplayer-$(MPLAYER_VERSION)\*.patch\*

Seems like your email client wraps long lines.

> +	toolchain/patch-kernel.sh $(MPLAYER_DIR) package/mplayer/
> mplayer-$(MPLAYER_VERSION)\*.patch
> +	toolchain/patch-kernel.sh $(MPLAYER_DIR) package/mplayer/
> mplayer-$(MPLAYER_VERSION)\*.patch.$(ARCH)
> +	$(SED) '/^CFLAGS/s/$$/ -fomit-frame-pointer/'
> $(MPLAYER_DIR)/libavcodec/Makefile
>  	touch $@
> 
>  $(MPLAYER_DIR)/.configured: $(MPLAYER_DIR)/.unpacked

-- 
With kind regards,
Hans-Christian Egtvedt, Applications Engineer

  reply	other threads:[~2007-08-29  8:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-29  8:33 [Buildroot] mplayer-package doesn't build for other architectures than avr32 Simon Pasch
2007-08-29  8:48 ` Hans-Christian Egtvedt [this message]
2007-08-30 22:14 ` Bernhard Fischer
2007-08-30 22:30   ` [Buildroot] mplayer-package doesn't build for otherarchitectures " Ulf Samuelsson
2007-08-31  7:31     ` Bernhard Fischer
2007-08-31 16:05       ` [Buildroot] mplayer-package doesn't build forotherarchitectures " Ulf Samuelsson
2007-09-01 16:31         ` Bernhard Fischer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1188377289.12874.13.camel@localhost.localdomain \
    --to=hcegtvedt@atmel.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox