* [Buildroot] mplayer-package doesn't build for other architectures than avr32 @ 2007-08-29 8:33 Simon Pasch 2007-08-29 8:48 ` Hans-Christian Egtvedt 2007-08-30 22:14 ` Bernhard Fischer 0 siblings, 2 replies; 7+ messages in thread From: Simon Pasch @ 2007-08-29 8:33 UTC (permalink / raw) To: buildroot It's the same issues as in libmad-package: There are architecture-specific patches. (by the way...one should be removed, as they can't be used both at the same time. AVR32-Users...tell us which one is the good one!) I added an extra command to the Makefile, because the build fails on my x86. Don't know if this breaks the build on other architectures. So either a sed-command can be used inside the Makefile or an extra architecture-specific patch (but it's not that simple with $(ARCH), because then you need patches for i386, i686, etc). This is my sed-command approach. (you have to manually rename the avr-patches): --- buildroot/package/mplayer/mplayer.mk.old 2007-08-28 09:15:43.000000000 +0200 +++ buildroot/package/mplayer/mplayer.mk 2007-08-29 10:02:07.000000000 +0200 @@ -22,7 +22,9 @@ $(MPLAYER_DIR)/.unpacked: $(DL_DIR)/$(MPLAYER_SOURCE) $(MPLAYER_CAT) $(DL_DIR)/$(MPLAYER_SOURCE) | tar -C $(BUILD_DIR) $(TAR_OPTIONS) - - toolchain/patch-kernel.sh $(MPLAYER_DIR) package/mplayer/ mplayer-$(MPLAYER_VERSION)\*.patch\* + toolchain/patch-kernel.sh $(MPLAYER_DIR) package/mplayer/ mplayer-$(MPLAYER_VERSION)\*.patch + toolchain/patch-kernel.sh $(MPLAYER_DIR) package/mplayer/ mplayer-$(MPLAYER_VERSION)\*.patch.$(ARCH) + $(SED) '/^CFLAGS/s/$$/ -fomit-frame-pointer/' $(MPLAYER_DIR)/libavcodec/Makefile touch $@ $(MPLAYER_DIR)/.configured: $(MPLAYER_DIR)/.unpacked ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] mplayer-package doesn't build for other architectures than avr32 2007-08-29 8:33 [Buildroot] mplayer-package doesn't build for other architectures than avr32 Simon Pasch @ 2007-08-29 8:48 ` Hans-Christian Egtvedt 2007-08-30 22:14 ` Bernhard Fischer 1 sibling, 0 replies; 7+ messages in thread From: Hans-Christian Egtvedt @ 2007-08-29 8:48 UTC (permalink / raw) To: buildroot On Wed, 2007-08-29 at 10:33 +0200, Simon Pasch wrote: > It's the same issues as in libmad-package: > There are architecture-specific patches. (by the way...one should be > removed, as they can't be used both at the same time. > AVR32-Users...tell us which one is the good one!) I did, but I think the email got drowned on the list. Remove package/mplayer/mplayer-1.0rc1-avr32-support.patch > I added an extra command to the Makefile, because the build fails on > my x86. Don't know if this breaks the build on other architectures. > So either a sed-command can be used inside the Makefile or an extra > architecture-specific patch (but it's not that simple with $(ARCH), > because then you need patches for i386, i686, etc). -fomit-frame-pointer is not architecture dependant, so should be fine to add it. I have not checked if it breaks the AVR32 build. > This is my sed-command approach. (you have to manually rename the avr-patches): > > --- buildroot/package/mplayer/mplayer.mk.old 2007-08-28 09:15:43.000000000 +0200 > +++ buildroot/package/mplayer/mplayer.mk 2007-08-29 10:02:07.000000000 +0200 > @@ -22,7 +22,9 @@ > > $(MPLAYER_DIR)/.unpacked: $(DL_DIR)/$(MPLAYER_SOURCE) > $(MPLAYER_CAT) $(DL_DIR)/$(MPLAYER_SOURCE) | tar -C $(BUILD_DIR) > $(TAR_OPTIONS) - > - toolchain/patch-kernel.sh $(MPLAYER_DIR) package/mplayer/ > mplayer-$(MPLAYER_VERSION)\*.patch\* Seems like your email client wraps long lines. > + toolchain/patch-kernel.sh $(MPLAYER_DIR) package/mplayer/ > mplayer-$(MPLAYER_VERSION)\*.patch > + toolchain/patch-kernel.sh $(MPLAYER_DIR) package/mplayer/ > mplayer-$(MPLAYER_VERSION)\*.patch.$(ARCH) > + $(SED) '/^CFLAGS/s/$$/ -fomit-frame-pointer/' > $(MPLAYER_DIR)/libavcodec/Makefile > touch $@ > > $(MPLAYER_DIR)/.configured: $(MPLAYER_DIR)/.unpacked -- With kind regards, Hans-Christian Egtvedt, Applications Engineer ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] mplayer-package doesn't build for other architectures than avr32 2007-08-29 8:33 [Buildroot] mplayer-package doesn't build for other architectures than avr32 Simon Pasch 2007-08-29 8:48 ` Hans-Christian Egtvedt @ 2007-08-30 22:14 ` Bernhard Fischer 2007-08-30 22:30 ` [Buildroot] mplayer-package doesn't build for otherarchitectures " Ulf Samuelsson 1 sibling, 1 reply; 7+ messages in thread From: Bernhard Fischer @ 2007-08-30 22:14 UTC (permalink / raw) To: buildroot On Wed, Aug 29, 2007 at 10:33:04AM +0200, Simon Pasch wrote: >It's the same issues as in libmad-package: >There are architecture-specific patches. (by the way...one should be >removed, as they can't be used both at the same time. >AVR32-Users...tell us which one is the good one!) > >I added an extra command to the Makefile, because the build fails on >my x86. Don't know if this breaks the build on other architectures. >So either a sed-command can be used inside the Makefile or an extra >architecture-specific patch (but it's not that simple with $(ARCH), >because then you need patches for i386, i686, etc). > >This is my sed-command approach. (you have to manually rename the avr-patches): > >--- buildroot/package/mplayer/mplayer.mk.old 2007-08-28 09:15:43.000000000 +0200 >+++ buildroot/package/mplayer/mplayer.mk 2007-08-29 10:02:07.000000000 +0200 >@@ -22,7 +22,9 @@ > > $(MPLAYER_DIR)/.unpacked: $(DL_DIR)/$(MPLAYER_SOURCE) > $(MPLAYER_CAT) $(DL_DIR)/$(MPLAYER_SOURCE) | tar -C $(BUILD_DIR) >$(TAR_OPTIONS) - >- toolchain/patch-kernel.sh $(MPLAYER_DIR) package/mplayer/ >mplayer-$(MPLAYER_VERSION)\*.patch\* >+ toolchain/patch-kernel.sh $(MPLAYER_DIR) package/mplayer/ >mplayer-$(MPLAYER_VERSION)\*.patch >+ toolchain/patch-kernel.sh $(MPLAYER_DIR) package/mplayer/ >mplayer-$(MPLAYER_VERSION)\*.patch.$(ARCH) >+ $(SED) '/^CFLAGS/s/$$/ -fomit-frame-pointer/' >$(MPLAYER_DIR)/libavcodec/Makefile > touch $@ > > $(MPLAYER_DIR)/.configured: $(MPLAYER_DIR)/.unpacked Ulf, can you fix this up in a sane manner, i.e. not add ...$(ARCH).patch stuff but arch agnostic, universally working fixes, if any? TIA, ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] mplayer-package doesn't build for otherarchitectures than avr32 2007-08-30 22:14 ` Bernhard Fischer @ 2007-08-30 22:30 ` Ulf Samuelsson 2007-08-31 7:31 ` Bernhard Fischer 0 siblings, 1 reply; 7+ messages in thread From: Ulf Samuelsson @ 2007-08-30 22:30 UTC (permalink / raw) To: buildroot ----- Original Message ----- From: "Bernhard Fischer" <rep.dot.nop@gmail.com> To: "Simon Pasch" <fpasch@googlemail.com> Cc: <buildroot@uclibc.org>; <ulf@atmel.com> Sent: Friday, August 31, 2007 12:14 AM Subject: Re: [Buildroot] mplayer-package doesn't build for otherarchitectures than avr32 > On Wed, Aug 29, 2007 at 10:33:04AM +0200, Simon Pasch wrote: >>It's the same issues as in libmad-package: >>There are architecture-specific patches. (by the way...one should be >>removed, as they can't be used both at the same time. >>AVR32-Users...tell us which one is the good one!) >> >>I added an extra command to the Makefile, because the build fails on >>my x86. Don't know if this breaks the build on other architectures. >>So either a sed-command can be used inside the Makefile or an extra >>architecture-specific patch (but it's not that simple with $(ARCH), >>because then you need patches for i386, i686, etc). >> >>This is my sed-command approach. (you have to manually rename the avr-patches): >> >>--- buildroot/package/mplayer/mplayer.mk.old 2007-08-28 09:15:43.000000000 +0200 >>+++ buildroot/package/mplayer/mplayer.mk 2007-08-29 10:02:07.000000000 +0200 >>@@ -22,7 +22,9 @@ >> >> $(MPLAYER_DIR)/.unpacked: $(DL_DIR)/$(MPLAYER_SOURCE) >> $(MPLAYER_CAT) $(DL_DIR)/$(MPLAYER_SOURCE) | tar -C $(BUILD_DIR) >>$(TAR_OPTIONS) - >>- toolchain/patch-kernel.sh $(MPLAYER_DIR) package/mplayer/ >>mplayer-$(MPLAYER_VERSION)\*.patch\* >>+ toolchain/patch-kernel.sh $(MPLAYER_DIR) package/mplayer/ >>mplayer-$(MPLAYER_VERSION)\*.patch >>+ toolchain/patch-kernel.sh $(MPLAYER_DIR) package/mplayer/ >>mplayer-$(MPLAYER_VERSION)\*.patch.$(ARCH) >>+ $(SED) '/^CFLAGS/s/$$/ -fomit-frame-pointer/' >>$(MPLAYER_DIR)/libavcodec/Makefile >> touch $@ >> >> $(MPLAYER_DIR)/.configured: $(MPLAYER_DIR)/.unpacked > > Ulf, can you fix this up in a sane manner, i.e. not add ...$(ARCH).patch > stuff but arch agnostic, universally working fixes, if any? > > TIA, > Got it from Hans Christian, which in his turn, got it from a colleague, so they need to update it if that is to happen. A lot of the stuff seems to be AVR32 specific in-line assembly code using the AVR32 DSP features to optimize the mplayer algorithms, so it seems utterly useless to apply for other architectures. Best Regards Ulf Samuelsson ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] mplayer-package doesn't build for otherarchitectures than avr32 2007-08-30 22:30 ` [Buildroot] mplayer-package doesn't build for otherarchitectures " Ulf Samuelsson @ 2007-08-31 7:31 ` Bernhard Fischer 2007-08-31 16:05 ` [Buildroot] mplayer-package doesn't build forotherarchitectures " Ulf Samuelsson 0 siblings, 1 reply; 7+ messages in thread From: Bernhard Fischer @ 2007-08-31 7:31 UTC (permalink / raw) To: buildroot On Fri, Aug 31, 2007 at 12:30:28AM +0200, Ulf Samuelsson wrote: >----- Original Message ----- >From: "Bernhard Fischer" <rep.dot.nop@gmail.com> >To: "Simon Pasch" <fpasch@googlemail.com> >Cc: <buildroot@uclibc.org>; <ulf@atmel.com> >Sent: Friday, August 31, 2007 12:14 AM >Subject: Re: [Buildroot] mplayer-package doesn't build for otherarchitectures than avr32 > > >> On Wed, Aug 29, 2007 at 10:33:04AM +0200, Simon Pasch wrote: >>>It's the same issues as in libmad-package: >>>There are architecture-specific patches. (by the way...one should be >>>removed, as they can't be used both at the same time. >>>AVR32-Users...tell us which one is the good one!) >>> >>>I added an extra command to the Makefile, because the build fails on >>>my x86. Don't know if this breaks the build on other architectures. >>>So either a sed-command can be used inside the Makefile or an extra >>>architecture-specific patch (but it's not that simple with $(ARCH), >>>because then you need patches for i386, i686, etc). >>> >>>This is my sed-command approach. (you have to manually rename the avr-patches): >>> >>>--- buildroot/package/mplayer/mplayer.mk.old 2007-08-28 09:15:43.000000000 +0200 >>>+++ buildroot/package/mplayer/mplayer.mk 2007-08-29 10:02:07.000000000 +0200 >>>@@ -22,7 +22,9 @@ >>> >>> $(MPLAYER_DIR)/.unpacked: $(DL_DIR)/$(MPLAYER_SOURCE) >>> $(MPLAYER_CAT) $(DL_DIR)/$(MPLAYER_SOURCE) | tar -C $(BUILD_DIR) >>>$(TAR_OPTIONS) - >>>- toolchain/patch-kernel.sh $(MPLAYER_DIR) package/mplayer/ >>>mplayer-$(MPLAYER_VERSION)\*.patch\* >>>+ toolchain/patch-kernel.sh $(MPLAYER_DIR) package/mplayer/ >>>mplayer-$(MPLAYER_VERSION)\*.patch >>>+ toolchain/patch-kernel.sh $(MPLAYER_DIR) package/mplayer/ >>>mplayer-$(MPLAYER_VERSION)\*.patch.$(ARCH) >>>+ $(SED) '/^CFLAGS/s/$$/ -fomit-frame-pointer/' >>>$(MPLAYER_DIR)/libavcodec/Makefile >>> touch $@ >>> >>> $(MPLAYER_DIR)/.configured: $(MPLAYER_DIR)/.unpacked >> >> Ulf, can you fix this up in a sane manner, i.e. not add ...$(ARCH).patch >> stuff but arch agnostic, universally working fixes, if any? >> >> TIA, >> > >Got it from Hans Christian, which in his turn, got it from a colleague, >so they need to update it if that is to happen. >A lot of the stuff seems to be AVR32 specific in-line assembly code >using the AVR32 DSP features to optimize the mplayer algorithms, >so it seems utterly useless to apply for other architectures. Given that mplayer currently is at 1.0-rc1 (i.e. not released), what about fixing this in the proper place, i.e. upstream? $ svn ls svn://svn.mplayerhq.hu/ffmpeg/trunk/libavcodec/ | grep -i avr $ Turns up nothing.. ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] mplayer-package doesn't build forotherarchitectures than avr32 2007-08-31 7:31 ` Bernhard Fischer @ 2007-08-31 16:05 ` Ulf Samuelsson 2007-09-01 16:31 ` Bernhard Fischer 0 siblings, 1 reply; 7+ messages in thread From: Ulf Samuelsson @ 2007-08-31 16:05 UTC (permalink / raw) To: buildroot >>> Ulf, can you fix this up in a sane manner, i.e. not add ...$(ARCH).patch >>> stuff but arch agnostic, universally working fixes, if any? >>> >>> TIA, >>> >> >>Got it from Hans Christian, which in his turn, got it from a colleague, >>so they need to update it if that is to happen. >>A lot of the stuff seems to be AVR32 specific in-line assembly code >>using the AVR32 DSP features to optimize the mplayer algorithms, >>so it seems utterly useless to apply for other architectures. > > Given that mplayer currently is at 1.0-rc1 (i.e. not released), what > about fixing this in the proper place, i.e. upstream? > $ svn ls svn://svn.mplayerhq.hu/ffmpeg/trunk/libavcodec/ | grep -i avr > $ > Turns up nothing.. > I think it is the intention of the AVR32 team to ensure that all additions they do are fed upstream, but I do not control their activities. Best Regards Ulf Samuelsson ^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] mplayer-package doesn't build forotherarchitectures than avr32 2007-08-31 16:05 ` [Buildroot] mplayer-package doesn't build forotherarchitectures " Ulf Samuelsson @ 2007-09-01 16:31 ` Bernhard Fischer 0 siblings, 0 replies; 7+ messages in thread From: Bernhard Fischer @ 2007-09-01 16:31 UTC (permalink / raw) To: buildroot On Fri, Aug 31, 2007 at 06:05:07PM +0200, Ulf Samuelsson wrote: >> Given that mplayer currently is at 1.0-rc1 (i.e. not released), what >> about fixing this in the proper place, i.e. upstream? >> $ svn ls svn://svn.mplayerhq.hu/ffmpeg/trunk/libavcodec/ | grep -i avr >> $ >> Turns up nothing.. >> > >I think it is the intention of the AVR32 team to ensure that all additions yep. >they do are fed upstream, but I do not control their activities. Of course not. But now would be a good time to make sure that your avr patches are applied for the 1.0 release, fwiw.. ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2007-09-01 16:31 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2007-08-29 8:33 [Buildroot] mplayer-package doesn't build for other architectures than avr32 Simon Pasch 2007-08-29 8:48 ` Hans-Christian Egtvedt 2007-08-30 22:14 ` Bernhard Fischer 2007-08-30 22:30 ` [Buildroot] mplayer-package doesn't build for otherarchitectures " Ulf Samuelsson 2007-08-31 7:31 ` Bernhard Fischer 2007-08-31 16:05 ` [Buildroot] mplayer-package doesn't build forotherarchitectures " Ulf Samuelsson 2007-09-01 16:31 ` Bernhard Fischer
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox