From: Sven Neumann <s.neumann@phase-zero.de>
To: buildroot@busybox.net
Subject: [Buildroot] svn commit: trunk/buildroot/package/libconfuse
Date: Thu, 22 Jan 2009 09:47:01 +0100 [thread overview]
Message-ID: <1232614021.6415.3.camel@sven> (raw)
In-Reply-To: <20090122071406.155456d9@hcegtvedt>
Hi,
On Thu, 2009-01-22 at 07:14 +0100, Hans-Christian Egtvedt wrote:
> On Wed, 21 Jan 2009 20:45:12 +0000 (UTC)
> jacmet at uclibc.org wrote:
>
> > Author: jacmet
> > Date: 2009-01-21 20:45:10 +0000 (Wed, 21 Jan 2009)
> > New Revision: 24944
> >
> > Log:
> > libconfuse: fix build by removing -Werror flag
> >
>
> You know that is not fixing it ;) Source code should not generate
> warnings, they are usually a sign of something bad is happening.
Source code that compiles without warnings on one compiler may generate
warnings on a different compiler (or just a different version or a
slightly differently configured instance of the very same compiler).
Having -Werror in public source code is always wrong as you can't
possibly know that it will compile cleanly for everyone.
And there are tons of warnings created by compilers that don't
necessarily indicate a problem in the source code. But of course you are
right that one should always check every warning carefully.
Sven
next prev parent reply other threads:[~2009-01-22 8:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-21 20:45 [Buildroot] svn commit: trunk/buildroot/package/libconfuse jacmet at uclibc.org
2009-01-22 6:14 ` Hans-Christian Egtvedt
2009-01-22 8:47 ` Sven Neumann [this message]
2009-01-22 9:05 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1232614021.6415.3.camel@sven \
--to=s.neumann@phase-zero.de \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox