[Buildroot] svn commit: trunk/buildroot/package/libconfuse

[Buildroot] svn commit: trunk/buildroot/package/libconfuse

[jacmet at uclibc.org]

Author: jacmet
Date: 2009-01-21 20:45:10 +0000 (Wed, 21 Jan 2009)
New Revision: 24944

Log:
libconfuse: fix build by removing -Werror flag

Added:
   trunk/buildroot/package/libconfuse/libconfuse-2.6-dont-use-werror.patch


Changeset:
Added: trunk/buildroot/package/libconfuse/libconfuse-2.6-dont-use-werror.patch
===================================================================
--- trunk/buildroot/package/libconfuse/libconfuse-2.6-dont-use-werror.patch	                        (rev 0)
+++ trunk/buildroot/package/libconfuse/libconfuse-2.6-dont-use-werror.patch	2009-01-21 20:45:10 UTC (rev 24944)
@@ -0,0 +1,34 @@
+confuse: don't compile with -Werror
+
+Werror isn't really a robust setting for !development.
+---
+ src/Makefile.am |    2 +-
+ src/Makefile.in |    2 +-
+ 2 files changed, 2 insertions(+), 2 deletions(-)
+
+Index: confuse-2.6/src/Makefile.am
+===================================================================
+--- confuse-2.6.orig/src/Makefile.am
++++ confuse-2.6/src/Makefile.am
+@@ -10,7 +10,7 @@
+ DEFS = -DLOCALEDIR=\"$(localedir)\" @DEFS@
+ 
+ if cc_is_gcc
+-AM_CFLAGS=-Wall -Werror
++AM_CFLAGS=-Wall
+ endif
+ 
+ LIBS = @LIBS@
+Index: confuse-2.6/src/Makefile.in
+===================================================================
+--- confuse-2.6.orig/src/Makefile.in
++++ confuse-2.6/src/Makefile.in
+@@ -196,7 +196,7 @@
+ libconfuse_la_SOURCES = confuse.c lexer.l
+ libconfuse_la_LIBADD = $(LTLIBINTL)
+ include_HEADERS = confuse.h
+- at cc_is_gcc_TRUE@AM_CFLAGS = -Wall -Werror
++ at cc_is_gcc_TRUE@AM_CFLAGS = -Wall
+ CLEANFILES = *~ \#*\#
+ AM_LFLAGS = -Pcfg_yy -olex.yy.c
+ all: all-am

[Buildroot] svn commit: trunk/buildroot/package/libconfuse

[Hans-Christian Egtvedt]

On Wed, 21 Jan 2009 20:45:12 +0000 (UTC)
jacmet at uclibc.org wrote:

> Author: jacmet
> Date: 2009-01-21 20:45:10 +0000 (Wed, 21 Jan 2009)
> New Revision: 24944
> 
> Log:
> libconfuse: fix build by removing -Werror flag
> 

You know that is not fixing it ;) Source code should not generate
warnings, they are usually a sign of something bad is happening.

But I guess this is fine for now.

<snipp>

-- 
Best regards,
Hans-Christian Egtvedt

[Buildroot] svn commit: trunk/buildroot/package/libconfuse

[Sven Neumann]

Hi,

On Thu, 2009-01-22 at 07:14 +0100, Hans-Christian Egtvedt wrote:
> On Wed, 21 Jan 2009 20:45:12 +0000 (UTC)
> jacmet at uclibc.org wrote:
> 
> > Author: jacmet
> > Date: 2009-01-21 20:45:10 +0000 (Wed, 21 Jan 2009)
> > New Revision: 24944
> > 
> > Log:
> > libconfuse: fix build by removing -Werror flag
> > 
> 
> You know that is not fixing it ;) Source code should not generate
> warnings, they are usually a sign of something bad is happening.

Source code that compiles without warnings on one compiler may generate
warnings on a different compiler (or just a different version or a
slightly differently configured instance of the very same compiler).
Having -Werror in public source code is always wrong as you can't
possibly know that it will compile cleanly for everyone.

And there are tons of warnings created by compilers that don't
necessarily indicate a problem in the source code. But of course you are
right that one should always check every warning carefully.


Sven

[Buildroot] svn commit: trunk/buildroot/package/libconfuse

[Peter Korsgaard]

>>>>> "Hans-Christian" == Hans-Christian Egtvedt <hans-christian.egtvedt@atmel.com> writes:

 >> libconfuse: fix build by removing -Werror flag
 >> 

 Hans-Christian> You know that is not fixing it ;) Source code should
 Hans-Christian> not generate warnings, they are usually a sign of
 Hans-Christian> something bad is happening.

 Hans-Christian> But I guess this is fine for now.

True, but in this case it's a simple warning about an unused variable.

Imho, shipping with -Werror isn't really a robust thing to do.

-- 
Bye, Peter Korsgaard