[Buildroot] Question about libtool patching

[Buildroot] Question about libtool patching

[Lionel Landwerlin]

Hi all,

I'm trying to integrate some new packages in buildroot. Those packages
use the autotools and need to be libtool patched to work with my
toolchain.

I'm wondering why the libtool patching is done twice in the build
process. One time after extraction of the package, another time at
configuration time.

The reason of this question is that I'm having problems with the first
patching. As long as the configure script has not been run, the patching
fails.

Couldn't we just trigger the patch at extraction only if autoreconf is
not required ?

Here a patch to try to implement this proposition.


-- 
Lionel Landwerlin <lionel.landwerlin@openwide.fr>

[Buildroot] Question about libtool patching

[Lionel Landwerlin]

[PATCH] Prevent libtool patching before autoreconf when autoreconf is required

Signed-off-by: Lionel Landwerlin <lionel.landwerlin@openwide.fr>
---
 package/Makefile.autotools.in |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/package/Makefile.autotools.in b/package/Makefile.autotools.in
index c4c4b1c..d36c884 100644
--- a/package/Makefile.autotools.in
+++ b/package/Makefile.autotools.in
@@ -188,7 +188,8 @@ $(BUILD_DIR)/%/.stamp_extracted:
 $(BUILD_DIR)/%/.stamp_libtool_patch:
 	$(call MESSAGE,"Patching libtool")
 # if the package uses libtool, patch it for cross-compiling in buildroot
-	$(Q)if test "$($(PKG)_LIBTOOL_PATCH)" = "YES"; then \
+	$(Q)if test "$($(PKG)_LIBTOOL_PATCH)" = "YES" -a \
+	"$($(PKG)_AUTORECONF)" != "YES"; then \
 	for i in `find $(@D) -name ltmain.sh`; do \
 		toolchain/patch-kernel.sh $${i%/*} package buildroot-libtool.patch; \
 		done \
-- 
1.6.4.3

[Buildroot] Question about libtool patching

[Sven Neumann]

On Sun, 2009-10-04 at 20:41 +0200, Lionel Landwerlin wrote:
> [PATCH] Prevent libtool patching before autoreconf when autoreconf is required
> 
> Signed-off-by: Lionel Landwerlin <lionel.landwerlin@openwide.fr>
> ---
>  package/Makefile.autotools.in |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/package/Makefile.autotools.in b/package/Makefile.autotools.in
> index c4c4b1c..d36c884 100644
> --- a/package/Makefile.autotools.in
> +++ b/package/Makefile.autotools.in
> @@ -188,7 +188,8 @@ $(BUILD_DIR)/%/.stamp_extracted:
>  $(BUILD_DIR)/%/.stamp_libtool_patch:
>  	$(call MESSAGE,"Patching libtool")
>  # if the package uses libtool, patch it for cross-compiling in buildroot
> -	$(Q)if test "$($(PKG)_LIBTOOL_PATCH)" = "YES"; then \
> +	$(Q)if test "$($(PKG)_LIBTOOL_PATCH)" = "YES" -a \
> +	"$($(PKG)_AUTORECONF)" != "YES"; then \
>  	for i in `find $(@D) -name ltmain.sh`; do \
>  		toolchain/patch-kernel.sh $${i%/*} package buildroot-libtool.patch; \
>  		done \

Totally makes sense to me and we also ran into problems because of this.
I have applied this in our tree and it seems to work fine. Actually, it
finally fixed a long-standing problem :)

Tested-By: Sven Neumann <s.neumann@raumfeld.com>


Sven

[Buildroot] Question about libtool patching

[Lionel Landwerlin]

Le lundi 05 octobre 2009 ? 11:30 +0200, Sven Neumann a ?crit :
> On Sun, 2009-10-04 at 20:41 +0200, Lionel Landwerlin wrote:
> > [PATCH] Prevent libtool patching before autoreconf when autoreconf is required
> > 
> > Signed-off-by: Lionel Landwerlin <lionel.landwerlin@openwide.fr>
> > ---
> >  package/Makefile.autotools.in |    3 ++-
> >  1 files changed, 2 insertions(+), 1 deletions(-)
> > 
> > diff --git a/package/Makefile.autotools.in b/package/Makefile.autotools.in
> > index c4c4b1c..d36c884 100644
> > --- a/package/Makefile.autotools.in
> > +++ b/package/Makefile.autotools.in
> > @@ -188,7 +188,8 @@ $(BUILD_DIR)/%/.stamp_extracted:
> >  $(BUILD_DIR)/%/.stamp_libtool_patch:
> >  	$(call MESSAGE,"Patching libtool")
> >  # if the package uses libtool, patch it for cross-compiling in buildroot
> > -	$(Q)if test "$($(PKG)_LIBTOOL_PATCH)" = "YES"; then \
> > +	$(Q)if test "$($(PKG)_LIBTOOL_PATCH)" = "YES" -a \
> > +	"$($(PKG)_AUTORECONF)" != "YES"; then \
> >  	for i in `find $(@D) -name ltmain.sh`; do \
> >  		toolchain/patch-kernel.sh $${i%/*} package buildroot-libtool.patch; \
> >  		done \
> 
> Totally makes sense to me and we also ran into problems because of this.
> I have applied this in our tree and it seems to work fine. Actually, it
> finally fixed a long-standing problem :)
> 
> Tested-By: Sven Neumann <s.neumann@raumfeld.com>
> 
> 

Nice ! :)


-- 
Lionel Landwerlin <lionel.landwerlin@openwide.fr>

[Buildroot] Question about libtool patching

[Peter Korsgaard]

>>>>> "Lionel" == Lionel Landwerlin <lionel.landwerlin@openwide.fr> writes:

 Lionel> [PATCH] Prevent libtool patching before autoreconf when autoreconf is required

Committed, thanks.

-- 
Bye, Peter Korsgaard