From: Clark Rawlins <clark.rawlins@escient.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Permit building grub with an external toolchain.
Date: Sun, 03 Jan 2010 08:43:38 -0500 [thread overview]
Message-ID: <1262526218.23927.27.camel@venture> (raw)
In-Reply-To: <1262491694.23193.10.camel@coalu.atr>
Okay,
I've started looking at this but it isn't clear to me how to handle the
following:
$(GRUB_DIR)/$(GRUB_BINARY): $(GRUB_DIR)/.configured
$(MAKE) CC=$(TARGET_CC) -C $(GRUB_DIR)
rm -f $(GRUB_DIR)/$(GRUB_BINARY)
$(MAKE) CC=$(TARGET_CC) CFLAGS+=-static -C $(GRUB_DIR)/grub grub
mkdir -p $(dir $(STAGING_DIR)/$(GRUB_TARGET_BINARY))
mv $(GRUB_DIR)/$(GRUB_BINARY) $(STAGING_DIR)/$(GRUB_TARGET_BINARY).static
$(MAKE) CC=$(TARGET_CC) -C $(GRUB_DIR)/grub
This builds everything dynamically linked first then builds the grub binary statically.
Is the right way to do this to override the target after/before calling the autotools macro?
On Sun, 2010-01-03 at 05:08 +0100, Lionel Landwerlin wrote:
> Here is one example :
>
> http://git.buildroot.org/buildroot/commit/?id=21bab8862f3c2906af347e5a993ce4cd36c1b063
>
> You can find a lot like this in the recent git history.
> I'm think to the new infrastructure because it provides all the glue to
> configure the package, especially the 2 lines you added.
>
> Regards,
>
>
> Le samedi 02 janvier 2010 ? 21:15 -0500, Clark Rawlins a ?crit :
> > I could give that a shot. I thought as a start I would go with the
> > smallest change possible. Any suggestions for an example to look at for
> > switching grub to the autotools macros?
> >
> >
> > On Sun, 2010-01-03 at 01:13 +0100, Lionel Landwerlin wrote:
> > > Le samedi 02 janvier 2010 ? 17:46 -0500, Clark Rawlins a ?crit :
> > > > Grub build failed at the link stage because it
> > > > couldn't find libcurses. Adding these variable
> > > > invocations to the configure line make it work.
> > > >
> > > > Signed-off-by: Clark Rawlins <clark.rawlins@escient.com>
> > > > ---
> > > > target/x86/grub/grub.mk | 2 ++
> > > > 1 files changed, 2 insertions(+), 0 deletions(-)
> > > >
> > > > diff --git a/target/x86/grub/grub.mk b/target/x86/grub/grub.mk
> > > > index af46244..21f089f 100644
> > > > --- a/target/x86/grub/grub.mk
> > > > +++ b/target/x86/grub/grub.mk
> > > > @@ -81,6 +81,8 @@ $(GRUB_DIR)/.unpacked: $(DL_DIR)/$(GRUB_SOURCE) $(DL_DIR)/$(GRUB_PATCH)
> > > > $(GRUB_DIR)/.configured: $(GRUB_DIR)/.unpacked
> > > > (cd $(GRUB_DIR); rm -rf config.cache; \
> > > > $(TARGET_CONFIGURE_OPTS) \
> > > > + $(TARGET_CONFIGURE_ARGS) \
> > > > + $(TARGET_CONFIGURE_ENV) \
> > > > CFLAGS="$(TARGET_CFLAGS)" \
> > > > CPPFLAGS="$(GRUB_CFLAGS)" \
> > > > ./configure $(QUIET) \
> > >
> > > Maybe you should consider switching grub to the autotool infrastructure.
> > >
> > > --
> > > Lionel Landwerlin
> > >
> > > _______________________________________________
> > > buildroot mailing list
> > > buildroot at busybox.net
> > > http://lists.busybox.net/mailman/listinfo/buildroot
> >
>
next prev parent reply other threads:[~2010-01-03 13:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-02 22:46 [Buildroot] [PATCH] Permit building grub with an external toolchain Clark Rawlins
2010-01-03 0:13 ` Lionel Landwerlin
2010-01-03 2:15 ` Clark Rawlins
2010-01-03 4:08 ` Lionel Landwerlin
2010-01-03 13:43 ` Clark Rawlins [this message]
2010-01-04 13:01 ` Clark Rawlins
2010-01-04 13:09 ` Lionel Landwerlin
2010-01-04 13:22 ` Clark Rawlins
2010-01-04 13:29 ` Lionel Landwerlin
2010-01-04 13:20 ` Thomas Petazzoni
2010-01-04 13:29 ` Clark Rawlins
2010-01-04 17:48 ` Clark Rawlins
2010-01-17 0:59 ` Clark Rawlins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1262526218.23927.27.camel@venture \
--to=clark.rawlins@escient.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox