Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Clark Rawlins <clark.rawlins@escient.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Permit building grub with an external toolchain.
Date: Sat, 16 Jan 2010 19:59:20 -0500	[thread overview]
Message-ID: <1263689960.6123.2.camel@venture> (raw)
In-Reply-To: <1262627315.31246.8.camel@venture>

Ping?

Is there anything wrong with this patch that should be fixed prior to
its inclusion in master?

On Mon, 2010-01-04 at 12:48 -0500, Clark Rawlins wrote:
> I have attached the complete file for review as well as the git
> format-patch generated diff.
> 
> On Mon, 2010-01-04 at 08:29 -0500, Clark Rawlins wrote:
> > On Mon, 2010-01-04 at 14:20 +0100, Thomas Petazzoni wrote:
> > > Hello Clark!
> > > 
> > > Le Mon, 04 Jan 2010 08:01:44 -0500,
> > > Clark Rawlins <clark.rawlins@escient.com> a ?crit :
> > > 
> > > > Here is my attempt to use the autotools macros.
> > > > I look forward to any discussion, suggestions for improvement etc.
> > > > 
> > > > I attach the whole file since it is effectively a rewrite.  If it is
> > > > acceptable I will submit as a git diff against head.  
> > > 
> > > Thanks for your work.
> > > 
> > > Maybe the GRUB_SUPPORTED_ARCH thing should be handled at the
> > > Config.in level.
> > 
> > Of course I was just copying what was already there for that part.
> > 
> > In grub/Config.in BR2_TARGET_GRUB depends on BR2_i386 || BR2_x86_64.
> > It seems that it would be equivalent to replace all the
> > GRUB_SUPPORTED_ARCH stuff with a single check for 
> > 
> > ifeq ($(BR2_TARGET_GRUB),y)
> > 
> > endif
> > 
> > > 
> > > Thomas
> > > -- 
> > > Thomas Petazzoni, Free Electrons
> > > Kernel, drivers and embedded Linux development,
> > > consulting, training and support.
> > > http://free-electrons.com
> > > _______________________________________________
> > > buildroot mailing list
> > > buildroot at busybox.net
> > > http://lists.busybox.net/mailman/listinfo/buildroot
> > 
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

      reply	other threads:[~2010-01-17  0:59 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-02 22:46 [Buildroot] [PATCH] Permit building grub with an external toolchain Clark Rawlins
2010-01-03  0:13 ` Lionel Landwerlin
2010-01-03  2:15   ` Clark Rawlins
2010-01-03  4:08     ` Lionel Landwerlin
2010-01-03 13:43       ` Clark Rawlins
2010-01-04 13:01         ` Clark Rawlins
2010-01-04 13:09           ` Lionel Landwerlin
2010-01-04 13:22             ` Clark Rawlins
2010-01-04 13:29               ` Lionel Landwerlin
2010-01-04 13:20           ` Thomas Petazzoni
2010-01-04 13:29             ` Clark Rawlins
2010-01-04 17:48               ` Clark Rawlins
2010-01-17  0:59                 ` Clark Rawlins [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1263689960.6123.2.camel@venture \
    --to=clark.rawlins@escient.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox