From: Mike Frysinger <vapier@gentoo.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] autotools: add with/without and enable/disable helpers
Date: Thu, 18 Nov 2010 23:33:57 -0500 [thread overview]
Message-ID: <1290141237-30539-1-git-send-email-vapier@gentoo.org> (raw)
Rather than have to write ugly logic in every package .mk file to check
a config var and then expand into a --{en,dis}able-foo flag, add helpers
so code can cleanly expand things.
A simple example:
- ifeq ($(BR2_PACKAGE_LIBVORBIS),y)
- SDL_MIXER_CONF_OPT += --enable-music-ogg
- else
- SDL_MIXER_CONF_OPT += --disable-music-ogg
- endif
+ SDL_MIXER_CONF_OPT += $(call USE_ENABLE,PACKAGE_LIBVORBIS,music-ogg)
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
package/Makefile.autotools.in | 18 ++++++++++++++++++
1 files changed, 18 insertions(+), 0 deletions(-)
diff --git a/package/Makefile.autotools.in b/package/Makefile.autotools.in
index 7d04e44..08a190b 100644
--- a/package/Makefile.autotools.in
+++ b/package/Makefile.autotools.in
@@ -279,3 +279,21 @@ else
$(call AUTOTARGETS_INNER,$(2),$(call UPPERCASE,$(2)),$(call UPPERCASE,$(2)),$(1),target)
endif
endef
+
+################################################################################
+# AUTOTOOLS HELPERS
+################################################################################
+
+# $(call _USE_CONF,enable,disable,LIB_FFMPEG,video,blah) -> --enable-video=blah if LIB_FFMPEG
+# $(call _USE_CONF,with,without,LIB_FFMPEG,video) -> --with-video if LIB_FFMPEG
+_USE_CONF = $(shell \
+ opt="$(5)"; test "$${opt:+set}" = "set" && opt="=$${opt}"; \
+ test "$(BR2_$(3))" = "y" \
+ && echo "--$(1)-$(4)$${opt}" \
+ || echo "--$(2)-$(4)")
+
+# $(call USE_ENABLE,LIB_FFMPEG,video) => --enable-video if LIB_FFMPEG is set
+USE_ENABLE = $(call _USE_CONF,enable,disable,$(1),$(2),$(3))
+
+# $(call USE_WITH,LIB_FFMPEG,video) => --with-video if LIB_FFMPEG is set
+USE_WITH = $(call _USE_CONF,with,without,$(1),$(2),$(3))
--
1.7.3.2
next reply other threads:[~2010-11-19 4:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-19 4:33 Mike Frysinger [this message]
2010-11-19 7:55 ` [Buildroot] [PATCH] autotools: add with/without and enable/disable helpers Thomas Petazzoni
2010-11-19 8:20 ` Mike Frysinger
2010-11-19 9:56 ` Thomas Petazzoni
2010-11-19 10:07 ` Mike Frysinger
2010-11-19 10:23 ` [Buildroot] [PATCH v2] " Mike Frysinger
2010-11-19 11:13 ` Thomas Petazzoni
2010-11-19 11:24 ` Mike Frysinger
2010-11-19 12:49 ` Paulius Zaleckas
2010-11-19 23:25 ` Mike Frysinger
2010-11-20 2:37 ` [Buildroot] [PATCH v3] " Mike Frysinger
2010-11-20 3:47 ` Mike Frysinger
-- strict thread matches above, loose matches on Subject: below --
2011-03-28 8:35 [Buildroot] [PATCH] " Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290141237-30539-1-git-send-email-vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox