Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] autotools: add with/without and enable/disable helpers
Date: Fri, 19 Nov 2010 18:25:00 -0500	[thread overview]
Message-ID: <201011191825.02260.vapier@gentoo.org> (raw)
In-Reply-To: <AANLkTikhi1PN3uSMR6Q_4gX3oEmi2Y7pNZhbaaL8PgwM@mail.gmail.com>

On Friday, November 19, 2010 07:49:54 Paulius Zaleckas wrote:
> On Fri, Nov 19, 2010 at 1:24 PM, Mike Frysinger <vapier@gentoo.org> wrote:
> > On Friday, November 19, 2010 06:13:26 Thomas Petazzoni wrote:
> >> > +_USE_CONF = $(if $(BR2_$(3)), --$(1)-$(4)$(if $(5),=$(5)),
> >> > --$(2)-$(4))
> >> 
> >> What about testing directly BR2_PACKAGE_$(3), since all packages are
> >> prefixed by BR2_PACKAGE_ ?
> > 
> > if that's the case, then there's no reason
> > 
> > in the original implementation, i avoided making the 2nd argument
> > optional. this was because i'd have to execute tr or something to do
> > lower->upper.  but if it's all in make now, it should be possible to
> > support the syntax: $(call USE_ENABLE,libvorbis)
> > the 1st arg would always be passed through the UPPERCASE helper, and hte
> > 2nd arg would default to the 1st.
> 
> I believe he means BR2_PACKAGE_$(3) instead of BR2_$(3), not to get rid of
> it.

i know what he meant.  i think you're confusing unrelated threads of thought.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20101119/6961619e/attachment-0001.pgp>

  reply	other threads:[~2010-11-19 23:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-19  4:33 [Buildroot] [PATCH] autotools: add with/without and enable/disable helpers Mike Frysinger
2010-11-19  7:55 ` Thomas Petazzoni
2010-11-19  8:20   ` Mike Frysinger
2010-11-19  9:56     ` Thomas Petazzoni
2010-11-19 10:07       ` Mike Frysinger
2010-11-19 10:23 ` [Buildroot] [PATCH v2] " Mike Frysinger
2010-11-19 11:13   ` Thomas Petazzoni
2010-11-19 11:24     ` Mike Frysinger
2010-11-19 12:49       ` Paulius Zaleckas
2010-11-19 23:25         ` Mike Frysinger [this message]
2010-11-20  2:37 ` [Buildroot] [PATCH v3] " Mike Frysinger
2010-11-20  3:47   ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201011191825.02260.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox