Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] libnl: bump to version 3.2.3
@ 2011-11-29 16:27 Daniel Mack
  2011-11-29 18:16 ` [Buildroot] [PATCH] hostapd: fix build with new libnl-3 Daniel Mack
                   ` (2 more replies)
  0 siblings, 3 replies; 17+ messages in thread
From: Daniel Mack @ 2011-11-29 16:27 UTC (permalink / raw)
  To: buildroot

This newer version splits the library code into libnl, libnl-route,
libnl-genl and libnl-nf, each individually selectable via pkgconfig.

Signed-off-by: Daniel Mack <zonque@gmail.com>
---
 package/libnl/libnl.mk |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/package/libnl/libnl.mk b/package/libnl/libnl.mk
index dd0d7fb..612908b 100644
--- a/package/libnl/libnl.mk
+++ b/package/libnl/libnl.mk
@@ -4,7 +4,7 @@
 #
 #############################################################
 
-LIBNL_VERSION = 3.0
+LIBNL_VERSION = 3.2.3
 LIBNL_SOURCE = libnl-$(LIBNL_VERSION).tar.gz
 LIBNL_SITE = http://www.infradead.org/~tgr/libnl/files/
 LIBNL_INSTALL_STAGING = YES
-- 
1.7.7.3

^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [Buildroot] [PATCH] hostapd: fix build with new libnl-3
  2011-11-29 16:27 [Buildroot] [PATCH] libnl: bump to version 3.2.3 Daniel Mack
@ 2011-11-29 18:16 ` Daniel Mack
  2011-11-29 18:27   ` Daniel Mack
  2011-11-29 18:24 ` [Buildroot] [PATCH] wpa_supplicant: " Daniel Mack
  2011-11-29 21:26 ` [Buildroot] [PATCH] libnl: bump to version 3.2.3 Yegor Yefremov
  2 siblings, 1 reply; 17+ messages in thread
From: Daniel Mack @ 2011-11-29 18:16 UTC (permalink / raw)
  To: buildroot

The CFLAGS have to be augmented for the include dir and a small patch
will make the binary link to libnl-3 and libnl-genl-3 instead of libnl
and libnl-gen.

Signed-off-by: Daniel Mack <zonque@gmail.com>
---
 package/hostapd/hostapd-0.7.3-libnl3.patch |   15 +++++++++++++++
 package/hostapd/hostapd.mk                 |    1 +
 2 files changed, 16 insertions(+), 0 deletions(-)
 create mode 100644 package/hostapd/hostapd-0.7.3-libnl3.patch

diff --git a/package/hostapd/hostapd-0.7.3-libnl3.patch b/package/hostapd/hostapd-0.7.3-libnl3.patch
new file mode 100644
index 0000000..e47da73
--- /dev/null
+++ b/package/hostapd/hostapd-0.7.3-libnl3.patch
@@ -0,0 +1,15 @@
+--- a/src/drivers/drivers.mak	2011-11-29 19:09:23.889942913 +0100
++++ b/src/drivers/drivers.mak	2011-11-29 19:09:40.637381428 +0100
+@@ -31,10 +31,10 @@
+ NEED_AP_MLME=y
+ NEED_NETLINK=y
+ NEED_LINUX_IOCTL=y
+-DRV_LIBS += -lnl
++DRV_LIBS += -lnl-3
+ 
+ ifdef CONFIG_LIBNL20
+-DRV_LIBS += -lnl-genl
++DRV_LIBS += -lnl-genl-3
+ DRV_CFLAGS += -DCONFIG_LIBNL20
+ endif
+ endif
diff --git a/package/hostapd/hostapd.mk b/package/hostapd/hostapd.mk
index 0d6c2c5..53af871 100644
--- a/package/hostapd/hostapd.mk
+++ b/package/hostapd/hostapd.mk
@@ -18,6 +18,7 @@ endif
 
 define HOSTAPD_LIBNL_CONFIG
 	echo "CONFIG_LIBNL20=y" >>$(HOSTAPD_CONFIG)
+	echo "CFLAGS += -I$(TARGET_DIR)/usr/include/libnl3/" >>$(HOSTAPD_CONFIG)
 endef
 
 define HOSTAPD_CRYPTO_CONFIG
-- 
1.7.7.3

^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [Buildroot] [PATCH] wpa_supplicant: fix build with new libnl-3
  2011-11-29 16:27 [Buildroot] [PATCH] libnl: bump to version 3.2.3 Daniel Mack
  2011-11-29 18:16 ` [Buildroot] [PATCH] hostapd: fix build with new libnl-3 Daniel Mack
@ 2011-11-29 18:24 ` Daniel Mack
  2011-11-29 21:26 ` [Buildroot] [PATCH] libnl: bump to version 3.2.3 Yegor Yefremov
  2 siblings, 0 replies; 17+ messages in thread
From: Daniel Mack @ 2011-11-29 18:24 UTC (permalink / raw)
  To: buildroot

The CFLAGS have to be augmented for the include dir and a small patch
will make the binary link to libnl-3 and libnl-genl-3 instead of libnl
and libnl-gen.

Signed-off-by: Daniel Mack <zonque@gmail.com>
---
 .../wpa_supplicant-0.7.3-libnl-3.patch             |   15 +++++++++++++++
 package/wpa_supplicant/wpa_supplicant.mk           |    2 +-
 2 files changed, 16 insertions(+), 1 deletions(-)
 create mode 100644 package/wpa_supplicant/wpa_supplicant-0.7.3-libnl-3.patch

diff --git a/package/wpa_supplicant/wpa_supplicant-0.7.3-libnl-3.patch b/package/wpa_supplicant/wpa_supplicant-0.7.3-libnl-3.patch
new file mode 100644
index 0000000..a460c2a
--- /dev/null
+++ b/package/wpa_supplicant/wpa_supplicant-0.7.3-libnl-3.patch
@@ -0,0 +1,15 @@
+--- a/src/drivers/drivers.mak	2011-11-29 19:19:56.684221050 +0100
++++ b/src/drivers/drivers.mak	2011-11-29 19:20:12.199609246 +0100
+@@ -31,10 +31,10 @@
+ NEED_AP_MLME=y
+ NEED_NETLINK=y
+ NEED_LINUX_IOCTL=y
+-DRV_LIBS += -lnl
++DRV_LIBS += -lnl-3
+ 
+ ifdef CONFIG_LIBNL20
+-DRV_LIBS += -lnl-genl
++DRV_LIBS += -lnl-genl-3
+ DRV_CFLAGS += -DCONFIG_LIBNL20
+ endif
+ endif
diff --git a/package/wpa_supplicant/wpa_supplicant.mk b/package/wpa_supplicant/wpa_supplicant.mk
index b2e7be3..f7f1af4 100644
--- a/package/wpa_supplicant/wpa_supplicant.mk
+++ b/package/wpa_supplicant/wpa_supplicant.mk
@@ -56,7 +56,7 @@ endif
 
 define WPA_SUPPLICANT_CONFIGURE_CMDS
 	cp $(@D)/wpa_supplicant/defconfig $(WPA_SUPPLICANT_CONFIG)
-	echo "CFLAGS += $(TARGET_CFLAGS)" >>$(WPA_SUPPLICANT_CONFIG)
+	echo "CFLAGS += $(TARGET_CFLAGS) -I$(TARGET_DIR)/usr/include/libnl3/" >>$(WPA_SUPPLICANT_CONFIG)
 	echo "LDFLAGS += $(TARGET_LDFLAGS)" >>$(WPA_SUPPLICANT_CONFIG)
 	echo "CC = $(TARGET_CC)" >>$(WPA_SUPPLICANT_CONFIG)
 	$(SED) "s/^#CONFIG_IEEE80211R/CONFIG_IEEE80211R/" $(WPA_SUPPLICANT_CONFIG)
-- 
1.7.7.3

^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [Buildroot] [PATCH] hostapd: fix build with new libnl-3
  2011-11-29 18:16 ` [Buildroot] [PATCH] hostapd: fix build with new libnl-3 Daniel Mack
@ 2011-11-29 18:27   ` Daniel Mack
  0 siblings, 0 replies; 17+ messages in thread
From: Daniel Mack @ 2011-11-29 18:27 UTC (permalink / raw)
  To: buildroot

On 11/29/2011 07:16 PM, Daniel Mack wrote:
> The CFLAGS have to be augmented for the include dir and a small patch
> will make the binary link to libnl-3 and libnl-genl-3 instead of libnl
> and libnl-gen.

There might be more patches like this necessary, and unfortunately, the
approach is a nasty hack which don't like either. But don't see any
cleaner way to make this work.

The root cause for touching all this is that I need libnl-3 with
libnl-route3 support for another package I'm working on.


Daniel



> 
> Signed-off-by: Daniel Mack <zonque@gmail.com>
> ---
>  package/hostapd/hostapd-0.7.3-libnl3.patch |   15 +++++++++++++++
>  package/hostapd/hostapd.mk                 |    1 +
>  2 files changed, 16 insertions(+), 0 deletions(-)
>  create mode 100644 package/hostapd/hostapd-0.7.3-libnl3.patch
> 
> diff --git a/package/hostapd/hostapd-0.7.3-libnl3.patch b/package/hostapd/hostapd-0.7.3-libnl3.patch
> new file mode 100644
> index 0000000..e47da73
> --- /dev/null
> +++ b/package/hostapd/hostapd-0.7.3-libnl3.patch
> @@ -0,0 +1,15 @@
> +--- a/src/drivers/drivers.mak	2011-11-29 19:09:23.889942913 +0100
> ++++ b/src/drivers/drivers.mak	2011-11-29 19:09:40.637381428 +0100
> +@@ -31,10 +31,10 @@
> + NEED_AP_MLME=y
> + NEED_NETLINK=y
> + NEED_LINUX_IOCTL=y
> +-DRV_LIBS += -lnl
> ++DRV_LIBS += -lnl-3
> + 
> + ifdef CONFIG_LIBNL20
> +-DRV_LIBS += -lnl-genl
> ++DRV_LIBS += -lnl-genl-3
> + DRV_CFLAGS += -DCONFIG_LIBNL20
> + endif
> + endif
> diff --git a/package/hostapd/hostapd.mk b/package/hostapd/hostapd.mk
> index 0d6c2c5..53af871 100644
> --- a/package/hostapd/hostapd.mk
> +++ b/package/hostapd/hostapd.mk
> @@ -18,6 +18,7 @@ endif
>  
>  define HOSTAPD_LIBNL_CONFIG
>  	echo "CONFIG_LIBNL20=y" >>$(HOSTAPD_CONFIG)
> +	echo "CFLAGS += -I$(TARGET_DIR)/usr/include/libnl3/" >>$(HOSTAPD_CONFIG)
>  endef
>  
>  define HOSTAPD_CRYPTO_CONFIG

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [Buildroot] [PATCH] libnl: bump to version 3.2.3
  2011-11-29 16:27 [Buildroot] [PATCH] libnl: bump to version 3.2.3 Daniel Mack
  2011-11-29 18:16 ` [Buildroot] [PATCH] hostapd: fix build with new libnl-3 Daniel Mack
  2011-11-29 18:24 ` [Buildroot] [PATCH] wpa_supplicant: " Daniel Mack
@ 2011-11-29 21:26 ` Yegor Yefremov
  2011-11-29 21:28   ` Yegor Yefremov
  2 siblings, 1 reply; 17+ messages in thread
From: Yegor Yefremov @ 2011-11-29 21:26 UTC (permalink / raw)
  To: buildroot

On Tue, Nov 29, 2011 at 5:27 PM, Daniel Mack <zonque@gmail.com> wrote:
> This newer version splits the library code into libnl, libnl-route,
> libnl-genl and libnl-nf, each individually selectable via pkgconfig.
>
> Signed-off-by: Daniel Mack <zonque@gmail.com>
> ---
> ?package/libnl/libnl.mk | ? ?2 +-
> ?1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/package/libnl/libnl.mk b/package/libnl/libnl.mk
> index dd0d7fb..612908b 100644
> --- a/package/libnl/libnl.mk
> +++ b/package/libnl/libnl.mk
> @@ -4,7 +4,7 @@
> ?#
> ?#############################################################
>
> -LIBNL_VERSION = 3.0
> +LIBNL_VERSION = 3.2.3
> ?LIBNL_SOURCE = libnl-$(LIBNL_VERSION).tar.gz
> ?LIBNL_SITE = http://www.infradead.org/~tgr/libnl/files/
> ?LIBNL_INSTALL_STAGING = YES
> --
> 1.7.7.3

The only package I know that is prepared for libnl 3.2.3 is iw (latest
git version). Other packages like wpa_supplicant, hostapd, kismet are
not prepared for the new version of libnl.

Yegor

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [Buildroot] [PATCH] libnl: bump to version 3.2.3
  2011-11-29 21:26 ` [Buildroot] [PATCH] libnl: bump to version 3.2.3 Yegor Yefremov
@ 2011-11-29 21:28   ` Yegor Yefremov
  2011-11-30 15:05     ` [Buildroot] [PATCH 1/2] iw: fix build with new libnl-3 Daniel Mack
  2011-11-30 15:06     ` [Buildroot] [PATCH] libnl: bump to version 3.2.3 Daniel Mack
  0 siblings, 2 replies; 17+ messages in thread
From: Yegor Yefremov @ 2011-11-29 21:28 UTC (permalink / raw)
  To: buildroot

On Tue, Nov 29, 2011 at 10:26 PM, Yegor Yefremov
<yegorslists@googlemail.com> wrote:
> On Tue, Nov 29, 2011 at 5:27 PM, Daniel Mack <zonque@gmail.com> wrote:
>> This newer version splits the library code into libnl, libnl-route,
>> libnl-genl and libnl-nf, each individually selectable via pkgconfig.
>>
>> Signed-off-by: Daniel Mack <zonque@gmail.com>
>> ---
>> ?package/libnl/libnl.mk | ? ?2 +-
>> ?1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/package/libnl/libnl.mk b/package/libnl/libnl.mk
>> index dd0d7fb..612908b 100644
>> --- a/package/libnl/libnl.mk
>> +++ b/package/libnl/libnl.mk
>> @@ -4,7 +4,7 @@
>> ?#
>> ?#############################################################
>>
>> -LIBNL_VERSION = 3.0
>> +LIBNL_VERSION = 3.2.3
>> ?LIBNL_SOURCE = libnl-$(LIBNL_VERSION).tar.gz
>> ?LIBNL_SITE = http://www.infradead.org/~tgr/libnl/files/
>> ?LIBNL_INSTALL_STAGING = YES
>> --
>> 1.7.7.3
>
> The only package I know that is prepared for libnl 3.2.3 is iw (latest
> git version). Other packages like wpa_supplicant, hostapd, kismet are
> not prepared for the new version of libnl.

I've seen your patches for wpa_supplicant, hostapd. So kismet and iw are left.

Yegor

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [Buildroot] [PATCH 1/2] iw: fix build with new libnl-3
  2011-11-29 21:28   ` Yegor Yefremov
@ 2011-11-30 15:05     ` Daniel Mack
  2011-11-30 15:06       ` [Buildroot] [PATCH 2/2] kismet: " Daniel Mack
  2011-11-30 15:54       ` [Buildroot] [PATCH 1/2] iw: " Yegor Yefremov
  2011-11-30 15:06     ` [Buildroot] [PATCH] libnl: bump to version 3.2.3 Daniel Mack
  1 sibling, 2 replies; 17+ messages in thread
From: Daniel Mack @ 2011-11-30 15:05 UTC (permalink / raw)
  To: buildroot

The CFLAGS have to be augmented for the include dir and the patch
needs to be tweaked to make the binary link to libnl-3 instead of
libnl-gen.

Signed-off-by: Daniel Mack <zonque@gmail.com>
---
 package/iw/iw-libnl-30-support.patch |    2 +-
 package/iw/iw.mk                     |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/package/iw/iw-libnl-30-support.patch b/package/iw/iw-libnl-30-support.patch
index 48a179f..02e818c 100644
--- a/package/iw/iw-libnl-30-support.patch
+++ b/package/iw/iw-libnl-30-support.patch
@@ -20,7 +20,7 @@ Index: b/Makefile
 
 +ifeq ($(NL3FOUND),Y)
 +CFLAGS += -DCONFIG_LIBNL20
-+LIBS += -lnl-genl
++LIBS += -lnl-genl-3
 +NLLIBNAME = libnl-3.0
 +endif
 +
diff --git a/package/iw/iw.mk b/package/iw/iw.mk
index 9f1d65f..65326b7 100644
--- a/package/iw/iw.mk
+++ b/package/iw/iw.mk
@@ -15,7 +15,7 @@ IW_MAKE_ENV = PKG_CONFIG_PATH="$(STAGING_DIR)/usr/lib/pkgconfig" \
 
 define IW_CONFIGURE_CMDS
 	echo "CC = $(TARGET_CC)" >$(IW_CONFIG)
-	echo "CFLAGS = $(TARGET_CFLAGS)" >>$(IW_CONFIG)
+	echo "CFLAGS = $(TARGET_CFLAGS) -I$(STAGING_DIR)/usr/include/libnl3/" >>$(IW_CONFIG)
 	echo "LDFLAGS = $(TARGET_LDFLAGS)" >>$(IW_CONFIG)
 endef
 
-- 
1.7.7.3

^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [Buildroot] [PATCH 2/2] kismet: fix build with new libnl-3
  2011-11-30 15:05     ` [Buildroot] [PATCH 1/2] iw: fix build with new libnl-3 Daniel Mack
@ 2011-11-30 15:06       ` Daniel Mack
  2011-11-30 15:54       ` [Buildroot] [PATCH 1/2] iw: " Yegor Yefremov
  1 sibling, 0 replies; 17+ messages in thread
From: Daniel Mack @ 2011-11-30 15:06 UTC (permalink / raw)
  To: buildroot

The CFLAGS have to be augmented, so configure finds the correct include
dir, and the patch needs to be tweaked to make the binary link to
libnl-3 instead of libnl-gen.

Signed-off-by: Daniel Mack <zonque@gmail.com>
---
 package/kismet/kismet-libnl-30-support.patch |   10 +++++++---
 package/kismet/kismet.mk                     |    1 +
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/package/kismet/kismet-libnl-30-support.patch b/package/kismet/kismet-libnl-30-support.patch
index cf3c845..5100a69 100644
--- a/package/kismet/kismet-libnl-30-support.patch
+++ b/package/kismet/kismet-libnl-30-support.patch
@@ -111,13 +111,17 @@ Index: b/configure
  pkg_failed=no
  { $as_echo "$as_me:${as_lineno-$LINENO}: checking for libnl20" >&5
  $as_echo_n "checking for libnl20... " >&6; }
-@@ -6897,7 +6974,7 @@
+@@ -6897,7 +6974,11 @@
  $as_echo "yes" >&6; }
  	libnl1=yes
  fi
 -	if test "$libnl20" = "yes"; then
-+	if test "$libnl20" = "yes" -o "$libnl30" = "yes"; then
-
++	if test "$libnl30" = "yes"; then
++$as_echo "#define HAVE_LIBNL 1" >>confdefs.h
++$as_echo "#define HAVE_LIBNL20 1" >>confdefs.h
++               NLLIBS="-lnl-genl-3 -lnl-3"
++	elif test "$libnl20" = "yes"; then
+ 
  $as_echo "#define HAVE_LIBNL 1" >>confdefs.h
 
 
diff --git a/package/kismet/kismet.mk b/package/kismet/kismet.mk
index 4c7d6e2..854c9dd 100644
--- a/package/kismet/kismet.mk
+++ b/package/kismet/kismet.mk
@@ -10,6 +10,7 @@ KISMET_DEPENDENCIES = libpcap ncurses
 
 ifeq ($(BR2_PACKAGE_LIBNL),y)
 	KISMET_DEPENDENCIES += libnl
+	KISMET_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -I$(STAGING_DIR)/usr/include/libnl3/"
 endif
 ifeq ($(BR2_PACKAGE_PCRE),y)
 	KISMET_DEPENDENCIES += pcre
-- 
1.7.7.3

^ permalink raw reply related	[flat|nested] 17+ messages in thread

* [Buildroot] [PATCH] libnl: bump to version 3.2.3
  2011-11-29 21:28   ` Yegor Yefremov
  2011-11-30 15:05     ` [Buildroot] [PATCH 1/2] iw: fix build with new libnl-3 Daniel Mack
@ 2011-11-30 15:06     ` Daniel Mack
  1 sibling, 0 replies; 17+ messages in thread
From: Daniel Mack @ 2011-11-30 15:06 UTC (permalink / raw)
  To: buildroot

On 11/29/2011 10:28 PM, Yegor Yefremov wrote:
> On Tue, Nov 29, 2011 at 10:26 PM, Yegor Yefremov
> <yegorslists@googlemail.com> wrote:
>> On Tue, Nov 29, 2011 at 5:27 PM, Daniel Mack <zonque@gmail.com> wrote:
>>> This newer version splits the library code into libnl, libnl-route,
>>> libnl-genl and libnl-nf, each individually selectable via pkgconfig.
>>>
>>> Signed-off-by: Daniel Mack <zonque@gmail.com>
>>> ---
>>>  package/libnl/libnl.mk |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/package/libnl/libnl.mk b/package/libnl/libnl.mk
>>> index dd0d7fb..612908b 100644
>>> --- a/package/libnl/libnl.mk
>>> +++ b/package/libnl/libnl.mk
>>> @@ -4,7 +4,7 @@
>>>  #
>>>  #############################################################
>>>
>>> -LIBNL_VERSION = 3.0
>>> +LIBNL_VERSION = 3.2.3
>>>  LIBNL_SOURCE = libnl-$(LIBNL_VERSION).tar.gz
>>>  LIBNL_SITE = http://www.infradead.org/~tgr/libnl/files/
>>>  LIBNL_INSTALL_STAGING = YES
>>> --
>>> 1.7.7.3
>>
>> The only package I know that is prepared for libnl 3.2.3 is iw (latest
>> git version). Other packages like wpa_supplicant, hostapd, kismet are
>> not prepared for the new version of libnl.
> 
> I've seen your patches for wpa_supplicant, hostapd. So kismet and iw are left.

Ok, I've sent patches for these, too. Thanks for the heads-up.


Daniel

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [Buildroot] [PATCH 1/2] iw: fix build with new libnl-3
  2011-11-30 15:05     ` [Buildroot] [PATCH 1/2] iw: fix build with new libnl-3 Daniel Mack
  2011-11-30 15:06       ` [Buildroot] [PATCH 2/2] kismet: " Daniel Mack
@ 2011-11-30 15:54       ` Yegor Yefremov
  2011-11-30 16:31         ` Daniel Mack
  1 sibling, 1 reply; 17+ messages in thread
From: Yegor Yefremov @ 2011-11-30 15:54 UTC (permalink / raw)
  To: buildroot

On Wed, Nov 30, 2011 at 4:05 PM, Daniel Mack <zonque@gmail.com> wrote:
> The CFLAGS have to be augmented for the include dir and the patch
> needs to be tweaked to make the binary link to libnl-3 instead of
> libnl-gen.
>
> Signed-off-by: Daniel Mack <zonque@gmail.com>
> ---
> ?package/iw/iw-libnl-30-support.patch | ? ?2 +-
> ?package/iw/iw.mk ? ? ? ? ? ? ? ? ? ? | ? ?2 +-
> ?2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/package/iw/iw-libnl-30-support.patch b/package/iw/iw-libnl-30-support.patch

this file has gone in next. Please rebase your patches on the next
branch and try to get iw from git with this commit
http://git.sipsolutions.net/?p=iw.git;a=commit;h=a82abc2cac9dea7def53070565201145c76c8c6c.

Yegor

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [Buildroot] [PATCH 1/2] iw: fix build with new libnl-3
  2011-11-30 15:54       ` [Buildroot] [PATCH 1/2] iw: " Yegor Yefremov
@ 2011-11-30 16:31         ` Daniel Mack
  2011-11-30 16:36           ` Michael S. Zick
                             ` (2 more replies)
  0 siblings, 3 replies; 17+ messages in thread
From: Daniel Mack @ 2011-11-30 16:31 UTC (permalink / raw)
  To: buildroot

Hi Yegor,

On 11/30/2011 04:54 PM, Yegor Yefremov wrote:
> On Wed, Nov 30, 2011 at 4:05 PM, Daniel Mack <zonque@gmail.com> wrote:
>> The CFLAGS have to be augmented for the include dir and the patch
>> needs to be tweaked to make the binary link to libnl-3 instead of
>> libnl-gen.
>>
>> Signed-off-by: Daniel Mack <zonque@gmail.com>
>> ---
>>  package/iw/iw-libnl-30-support.patch |    2 +-
>>  package/iw/iw.mk                     |    2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/package/iw/iw-libnl-30-support.patch b/package/iw/iw-libnl-30-support.patch
> 
> this file has gone in next. Please rebase your patches on the next

I can do this. I wasn't even aware of this branch, and part of the
reason is that it doesn't show up on the cgit web interface
(http://git.buildroot.net/buildroot) when there's no trailing slash in
the URI, which is unfortunately the location the website
(http://buildroot.uclibc.org/git.html) points visitors to. You can click
on "refs" and back on "summary" which will add the "/" suffix, and then
cgit will show the existance of the "next" branch. Very odd.

> branch and try to get iw from git with this commit
> http://git.sipsolutions.net/?p=iw.git;a=commit;h=a82abc2cac9dea7def53070565201145c76c8c6c.

Not sure whether I follow you here. Do you suggest writing package
definitions for sources that are not released yet officially? If that is
the case, what is the reason?

Also, I fail to see how the commit you pointed me to is related to the
changed location of libnl-3. Is this not something that should be
addressed independently?

All my other libnl-related patches still seem to apply fine on the -next
branch, though.


Daniel

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [Buildroot] [PATCH 1/2] iw: fix build with new libnl-3
  2011-11-30 16:31         ` Daniel Mack
@ 2011-11-30 16:36           ` Michael S. Zick
  2011-11-30 16:41             ` Michael S. Zick
  2011-11-30 21:31           ` Yegor Yefremov
  2011-12-24 15:24           ` Peter Korsgaard
  2 siblings, 1 reply; 17+ messages in thread
From: Michael S. Zick @ 2011-11-30 16:36 UTC (permalink / raw)
  To: buildroot

On Wed November 30 2011, Daniel Mack wrote:
> I can do this. I wasn't even aware of this branch, and part of the
> reason is that it doesn't show up on the cgit web interface
> (http://git.buildroot.net/buildroot) when there's no trailing slash in
> the URI, which is unfortunately the location the website
> (http://buildroot.uclibc.org/git.html) points visitors to. You can click
> on "refs" and back on "summary" which will add the "/" suffix, and then
> cgit will show the existance of the "next" branch. Very odd.
> 

Confirmed here also.

Just adding the "/" to the URI in the browser bar and hitting "enter"
fixes the display of the "next" branch also.

Mike

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [Buildroot] [PATCH 1/2] iw: fix build with new libnl-3
  2011-11-30 16:36           ` Michael S. Zick
@ 2011-11-30 16:41             ` Michael S. Zick
  0 siblings, 0 replies; 17+ messages in thread
From: Michael S. Zick @ 2011-11-30 16:41 UTC (permalink / raw)
  To: buildroot

On Wed November 30 2011, Michael S. Zick wrote:
> On Wed November 30 2011, Daniel Mack wrote:
> > I can do this. I wasn't even aware of this branch, and part of the
> > reason is that it doesn't show up on the cgit web interface
> > (http://git.buildroot.net/buildroot) when there's no trailing slash in
> > the URI, which is unfortunately the location the website
> > (http://buildroot.uclibc.org/git.html) points visitors to. You can click
> > on "refs" and back on "summary" which will add the "/" suffix, and then
> > cgit will show the existance of the "next" branch. Very odd.
> > 
> 
> Confirmed here also.
> 
> Just adding the "/" to the URI in the browser bar and hitting "enter"
> fixes the display of the "next" branch also.
>

I haven't checked if the command line shown under the "Clone" section
is effected by this strange behavior.

Mike 
> Mike
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
> 
> 

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [Buildroot] [PATCH 1/2] iw: fix build with new libnl-3
  2011-11-30 16:31         ` Daniel Mack
  2011-11-30 16:36           ` Michael S. Zick
@ 2011-11-30 21:31           ` Yegor Yefremov
  2011-12-01 11:50             ` Daniel Mack
  2011-12-24 15:24           ` Peter Korsgaard
  2 siblings, 1 reply; 17+ messages in thread
From: Yegor Yefremov @ 2011-11-30 21:31 UTC (permalink / raw)
  To: buildroot

Hi Daniel,

>>> The CFLAGS have to be augmented for the include dir and the patch
>>> needs to be tweaked to make the binary link to libnl-3 instead of
>>> libnl-gen.
>>>
>>> Signed-off-by: Daniel Mack <zonque@gmail.com>
>>> ---
>>> ?package/iw/iw-libnl-30-support.patch | ? ?2 +-
>>> ?package/iw/iw.mk ? ? ? ? ? ? ? ? ? ? | ? ?2 +-
>>> ?2 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/package/iw/iw-libnl-30-support.patch b/package/iw/iw-libnl-30-support.patch
>>
>> this file has gone in next. Please rebase your patches on the next
>
> I can do this. I wasn't even aware of this branch, and part of the
> reason is that it doesn't show up on the cgit web interface
> (http://git.buildroot.net/buildroot) when there's no trailing slash in
> the URI, which is unfortunately the location the website
> (http://buildroot.uclibc.org/git.html) points visitors to. You can click
> on "refs" and back on "summary" which will add the "/" suffix, and then
> cgit will show the existance of the "next" branch. Very odd.
>
>> branch and try to get iw from git with this commit
>> http://git.sipsolutions.net/?p=iw.git;a=commit;h=a82abc2cac9dea7def53070565201145c76c8c6c.
>
> Not sure whether I follow you here. Do you suggest writing package
> definitions for sources that are not released yet officially? If that is
> the case, what is the reason?

I see here 3 possibilities:

1. replace official release with git one
2. wait for iw 3.3
3. apply related patches (from iw repo) only

the first way is simpler and quicker to implement

> Also, I fail to see how the commit you pointed me to is related to the
> changed location of libnl-3. Is this not something that should be
> addressed independently?

I just pointed to the latest commit. You can choose the one with related changes

> All my other libnl-related patches still seem to apply fine on the -next
> branch, though.

ACK

Yegor

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [Buildroot] [PATCH 1/2] iw: fix build with new libnl-3
  2011-11-30 21:31           ` Yegor Yefremov
@ 2011-12-01 11:50             ` Daniel Mack
  0 siblings, 0 replies; 17+ messages in thread
From: Daniel Mack @ 2011-12-01 11:50 UTC (permalink / raw)
  To: buildroot

On 11/30/2011 10:31 PM, Yegor Yefremov wrote:
> Hi Daniel,
> 
>>>> The CFLAGS have to be augmented for the include dir and the patch
>>>> needs to be tweaked to make the binary link to libnl-3 instead of
>>>> libnl-gen.
>>>>
>>>> Signed-off-by: Daniel Mack <zonque@gmail.com>
>>>> ---
>>>>  package/iw/iw-libnl-30-support.patch |    2 +-
>>>>  package/iw/iw.mk                     |    2 +-
>>>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/package/iw/iw-libnl-30-support.patch b/package/iw/iw-libnl-30-support.patch
>>>
>>> this file has gone in next. Please rebase your patches on the next
>>
>> I can do this. I wasn't even aware of this branch, and part of the
>> reason is that it doesn't show up on the cgit web interface
>> (http://git.buildroot.net/buildroot) when there's no trailing slash in
>> the URI, which is unfortunately the location the website
>> (http://buildroot.uclibc.org/git.html) points visitors to. You can click
>> on "refs" and back on "summary" which will add the "/" suffix, and then
>> cgit will show the existance of the "next" branch. Very odd.
>>
>>> branch and try to get iw from git with this commit
>>> http://git.sipsolutions.net/?p=iw.git;a=commit;h=a82abc2cac9dea7def53070565201145c76c8c6c.
>>
>> Not sure whether I follow you here. Do you suggest writing package
>> definitions for sources that are not released yet officially? If that is
>> the case, what is the reason?
> 
> I see here 3 possibilities:
> 
> 1. replace official release with git one
> 2. wait for iw 3.3
> 3. apply related patches (from iw repo) only
> 
> the first way is simpler and quicker to implement

Ok, fine. I did that and the git version seems to cope well with
nibnl-3. Nice.

>> Also, I fail to see how the commit you pointed me to is related to the
>> changed location of libnl-3. Is this not something that should be
>> addressed independently?
> 
> I just pointed to the latest commit. You can choose the one with related changes

Ok. I rebased all patches and will repost them all. Thanks for your review!


Dainel

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [Buildroot] [PATCH 1/2] iw: fix build with new libnl-3
  2011-11-30 16:31         ` Daniel Mack
  2011-11-30 16:36           ` Michael S. Zick
  2011-11-30 21:31           ` Yegor Yefremov
@ 2011-12-24 15:24           ` Peter Korsgaard
  2011-12-24 15:56             ` Stephan Hoffmann
  2 siblings, 1 reply; 17+ messages in thread
From: Peter Korsgaard @ 2011-12-24 15:24 UTC (permalink / raw)
  To: buildroot

>>>>> "Daniel" == Daniel Mack <zonque@gmail.com> writes:

 >> this file has gone in next. Please rebase your patches on the next

 Daniel> I can do this. I wasn't even aware of this branch, and part of the
 Daniel> reason is that it doesn't show up on the cgit web interface
 Daniel> (http://git.buildroot.net/buildroot) when there's no trailing slash in
 Daniel> the URI, which is unfortunately the location the website
 Daniel> (http://buildroot.uclibc.org/git.html) points visitors to. You can click
 Daniel> on "refs" and back on "summary" which will add the "/" suffix, and then
 Daniel> cgit will show the existance of the "next" branch. Very odd.

Yes, I know. I've reported it to the osuosl.org guys a while back, and
they are looking into it, but so far without any luck.

I've now fixed the website link.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 17+ messages in thread

* [Buildroot] [PATCH 1/2] iw: fix build with new libnl-3
  2011-12-24 15:24           ` Peter Korsgaard
@ 2011-12-24 15:56             ` Stephan Hoffmann
  0 siblings, 0 replies; 17+ messages in thread
From: Stephan Hoffmann @ 2011-12-24 15:56 UTC (permalink / raw)
  To: buildroot

Am 24.12.2011 16:24, schrieb Peter Korsgaard:
>>>>>> "Daniel" == Daniel Mack <zonque@gmail.com> writes:
>  >> this file has gone in next. Please rebase your patches on the next
>
>  Daniel> I can do this. I wasn't even aware of this branch, and part of the
>  Daniel> reason is that it doesn't show up on the cgit web interface
>  Daniel> (http://git.buildroot.net/buildroot) when there's no trailing slash in
>  Daniel> the URI, which is unfortunately the location the website
>  Daniel> (http://buildroot.uclibc.org/git.html) points visitors to. You can click
>  Daniel> on "refs" and back on "summary" which will add the "/" suffix, and then
>  Daniel> cgit will show the existance of the "next" branch. Very odd.
Even more strange:

http://git.buildroot.net/buildroot

Branch Commit message                                       
Author          Age
master <http://git.buildroot.net/buildroot/log/>hostapd: fix libnl
linking with BR2_PREFER_STATIC_LIB
<http://git.buildroot.net/buildroot/commit/>Peter Korsgaard91 min.

manually adding a "/" at the end of the URL gives:

http://git.buildroot.net/buildroot/:

Branch Commit message                                       
Author          Age
master <http://git.buildroot.net/buildroot/log/>xapp_xman: fix
dependencies                          
<http://git.buildroot.net/buildroot/commit/>Peter Korsgaard29 hours
next <http://git.buildroot.net/buildroot/log/?h=next>   libroxml: bump
version to 2.1.2                      
<http://git.buildroot.net/buildroot/commit/?h=next>Tristan Lelong   4 weeks

A nice time to all

Stephan
> Yes, I know. I've reported it to the osuosl.org guys a while back, and
> they are looking into it, but so far without any luck.
>
> I've now fixed the website link.
>


-- 
reLinux     -    Stephan Hoffmann
Am Schmidtgrund 124    50765 K?ln
Tel. +49.221.95595-19    Fax: -64
www.reLinux.de     sho at reLinux.de


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20111224/9774ded9/attachment.html>

^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2011-12-24 15:56 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-29 16:27 [Buildroot] [PATCH] libnl: bump to version 3.2.3 Daniel Mack
2011-11-29 18:16 ` [Buildroot] [PATCH] hostapd: fix build with new libnl-3 Daniel Mack
2011-11-29 18:27   ` Daniel Mack
2011-11-29 18:24 ` [Buildroot] [PATCH] wpa_supplicant: " Daniel Mack
2011-11-29 21:26 ` [Buildroot] [PATCH] libnl: bump to version 3.2.3 Yegor Yefremov
2011-11-29 21:28   ` Yegor Yefremov
2011-11-30 15:05     ` [Buildroot] [PATCH 1/2] iw: fix build with new libnl-3 Daniel Mack
2011-11-30 15:06       ` [Buildroot] [PATCH 2/2] kismet: " Daniel Mack
2011-11-30 15:54       ` [Buildroot] [PATCH 1/2] iw: " Yegor Yefremov
2011-11-30 16:31         ` Daniel Mack
2011-11-30 16:36           ` Michael S. Zick
2011-11-30 16:41             ` Michael S. Zick
2011-11-30 21:31           ` Yegor Yefremov
2011-12-01 11:50             ` Daniel Mack
2011-12-24 15:24           ` Peter Korsgaard
2011-12-24 15:56             ` Stephan Hoffmann
2011-11-30 15:06     ` [Buildroot] [PATCH] libnl: bump to version 3.2.3 Daniel Mack

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox