* [Buildroot] [PATCH next] tpm2-tss: depend on shared libraries
@ 2018-11-19 4:41 Carlos Santos
2018-11-19 20:59 ` Thomas Petazzoni
0 siblings, 1 reply; 3+ messages in thread
From: Carlos Santos @ 2018-11-19 4:41 UTC (permalink / raw)
To: buildroot
The code includes dlfcn.h even if --enable-static and --disable-shared
are passed to configure. There is an "#ifndef NO_DL ... #endif" wrapper
but NO_DL is never defined and adding "-DNO_DL" to CFLAGS causes other
compilation errors.
Fixes:
http://autobuild.buildroot.net/results/cfc3bfef5e93329bf944a57947086d9ddc4fece3
Signed-off-by: Carlos Santos <casantos@datacom.com.br>
---
package/tpm2-tss/Config.in | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/package/tpm2-tss/Config.in b/package/tpm2-tss/Config.in
index 4e299eccc1..26a120c46b 100644
--- a/package/tpm2-tss/Config.in
+++ b/package/tpm2-tss/Config.in
@@ -1,5 +1,6 @@
config BR2_PACKAGE_TPM2_TSS
bool "tpm2-tss"
+ depends on !BR2_STATIC_LIBS # dlfcn.h
select BR2_PACKAGE_LIBURIPARSER
select BR2_PACKAGE_OPENSSL
help
@@ -30,3 +31,6 @@ config BR2_PACKAGE_TPM2_TSS
Microsoft software TPM2 simulator.
https://github.com/tpm2-software/tpm2-tss
+
+comment "tpm2-tss needs a toolchain w/ dynamic library"
+ depends BR2_STATIC_LIBS
--
2.19.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH next] tpm2-tss: depend on shared libraries
2018-11-19 4:41 [Buildroot] [PATCH next] tpm2-tss: depend on shared libraries Carlos Santos
@ 2018-11-19 20:59 ` Thomas Petazzoni
2018-11-20 10:16 ` Carlos Santos
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2018-11-19 20:59 UTC (permalink / raw)
To: buildroot
Hello Carlos,
On Mon, 19 Nov 2018 02:41:23 -0200, Carlos Santos wrote:
> The code includes dlfcn.h even if --enable-static and --disable-shared
> are passed to configure. There is an "#ifndef NO_DL ... #endif" wrapper
> but NO_DL is never defined and adding "-DNO_DL" to CFLAGS causes other
> compilation errors.
>
> Fixes:
> http://autobuild.buildroot.net/results/cfc3bfef5e93329bf944a57947086d9ddc4fece3
>
> Signed-off-by: Carlos Santos <casantos@datacom.com.br>
You need to propagate this dependency to the reverse dependencies of
tpm2-tss.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH next] tpm2-tss: depend on shared libraries
2018-11-19 20:59 ` Thomas Petazzoni
@ 2018-11-20 10:16 ` Carlos Santos
0 siblings, 0 replies; 3+ messages in thread
From: Carlos Santos @ 2018-11-20 10:16 UTC (permalink / raw)
To: buildroot
Superseded-by: https://patchwork.ozlabs.org/patch/1000367/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-11-20 10:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-19 4:41 [Buildroot] [PATCH next] tpm2-tss: depend on shared libraries Carlos Santos
2018-11-19 20:59 ` Thomas Petazzoni
2018-11-20 10:16 ` Carlos Santos
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox