[Buildroot] build of e2fsprogs fails (2012.02-rc3)

[Buildroot] build of e2fsprogs fails (2012.02-rc3)

[Sven Neumann]

Hi,

the build of e2fsprogs fails with 2012.02-rc3:

	CC e4defrag.c
e4defrag.c:28:17: fatal error: ftw.h: No such file or directory
compilation terminated.
make[3]: *** [e4defrag.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: Leaving directory
`/home/sven/git/buildroot-geode/output/build/e2fsprogs-1.42/misc'
make[2]: *** [all-progs-recursive] Error 1
make[2]: Leaving directory
`/home/sven/git/buildroot-geode/output/build/e2fsprogs-1.42'
make[1]: *** [all] Error 2
make[1]: Leaving directory
`/home/sven/git/buildroot-geode/output/build/e2fsprogs-1.42'
make: ***
[/home/sven/git/buildroot-geode/output/build/e2fsprogs-1.42/.stamp_built] Error 2


$ find . -name ftw.h 
./output/toolchain/uClibc-0.9.32.1/include/ftw.h


The relevant lines of the buildroot .config are:

BR2_PACKAGE_E2FSPROGS=y
BR2_PACKAGE_E2FSPROGS_BADBLOCKS=y
# BR2_PACKAGE_E2FSPROGS_CHATTR is not set
# BR2_PACKAGE_E2FSPROGS_DEBUGFS is not set
# BR2_PACKAGE_E2FSPROGS_DUMPE2FS is not set
# BR2_PACKAGE_E2FSPROGS_E2FREEFRAG is not set
BR2_PACKAGE_E2FSPROGS_E2FSCK=y
# BR2_PACKAGE_E2FSPROGS_E2IMAGE is not set
BR2_PACKAGE_E2FSPROGS_E2LABEL=y
# BR2_PACKAGE_E2FSPROGS_E2UNDO is not set
# BR2_PACKAGE_E2FSPROGS_E4DEFRAG is not set
# BR2_PACKAGE_E2FSPROGS_FILEFRAG is not set
# BR2_PACKAGE_E2FSPROGS_FINDFS is not set
# BR2_PACKAGE_E2FSPROGS_FSCK is not set
# BR2_PACKAGE_E2FSPROGS_LOGSAVE is not set
# BR2_PACKAGE_E2FSPROGS_LSATTR is not set
BR2_PACKAGE_E2FSPROGS_MKE2FS=y
# BR2_PACKAGE_E2FSPROGS_MKLOSTFOUND is not set
# BR2_PACKAGE_E2FSPROGS_RESIZE2FS is not set
# BR2_PACKAGE_E2FSPROGS_TUNE2FS is not set
BR2_PACKAGE_E2FSPROGS_UUIDGEN=y


Regards, Sven

[Buildroot] [PATCH] e2fsprogs: disable build of e4defrag unless explicitly enabled

[Sven Neumann]

The e2fsprogs configure script enables the build of the e4defrag
utility by default. Disable it unless BR2_PACKAGE_E2FSPROGS_E4DEFRAG
is selected.

Also the --disable-blkid option is not recognized by the configure
script. Use --disable-libblkid instead.

Signed-off-by: Sven Neumann <s.neumann@raumfeld.com>
---
 package/e2fsprogs/e2fsprogs.mk |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/package/e2fsprogs/e2fsprogs.mk b/package/e2fsprogs/e2fsprogs.mk
index 912deab..f3d44f6 100644
--- a/package/e2fsprogs/e2fsprogs.mk
+++ b/package/e2fsprogs/e2fsprogs.mk
@@ -12,9 +12,10 @@ E2FSPROGS_CONF_OPT = \
 	--enable-elf-shlibs \
 	$(if $(BR2_PACKAGE_E2FSPROGS_DEBUGFS),,--disable-debugfs) \
 	$(if $(BR2_PACKAGE_E2FSPROGS_E2IMAGE),,--disable-imager) \
+	$(if $(BR2_PACKAGE_E2FSPROGS_E4DEFRAG),,--disable-defrag) \
 	$(if $(BR2_PACKAGE_E2FSPROGS_RESIZE2FS),,--disable-resizer) \
 	--disable-uuidd \
-	--disable-blkid \
+	--disable-libblkid \
 	--disable-libuuid \
 	--enable-fsck \
 	--disable-e2initrd-helper \
-- 
1.7.5.4

[Buildroot] build of e2fsprogs fails (2012.02-rc3)

[Gustavo Zacarias]

On 2012-02-28 08:16, Sven Neumann wrote:

> Hi,
>
> the build of e2fsprogs fails with 2012.02-rc3:
>
> 	CC e4defrag.c
> e4defrag.c:28:17: fatal error: ftw.h: No such file or directory
> compilation terminated.

What about your uclibc config?
If you're using a custom uclibc config basically "you're on your own" 
if packages break.
Like on bug #4736 you reported.
Packages are tested to work on buildroot's-shipped default uclibc 
configurations.
At least that's my take.
Regards.

[Buildroot] build of e2fsprogs fails (2012.02-rc3)

[Sven Neumann]

Hi,

On Tue, 2012-02-28 at 09:11 -0300, Gustavo Zacarias wrote:

> > the build of e2fsprogs fails with 2012.02-rc3:
> >
> > 	CC e4defrag.c
> > e4defrag.c:28:17: fatal error: ftw.h: No such file or directory
> > compilation terminated.
> 
> What about your uclibc config?
> If you're using a custom uclibc config basically "you're on your own" 
> if packages break.
> Like on bug #4736 you reported.
> Packages are tested to work on buildroot's-shipped default uclibc 
> configurations.
> At least that's my take.

Well, this probably used to be a default uclibc configuration three
years ago. Since then we have updated buildroot several times and
obviously our ubclibc configuration diverged. What would be the best way
to go back to the default uclibc configuration?

Nevertheless, you should consider the patch I've sent as the
BR2_PACKAGE_E2FSPROGS_E4DEFRAG option is currently not correctly
handled.


Regards,
Sven

[Buildroot] build of e2fsprogs fails (2012.02-rc3)

[Gustavo Zacarias]

On 2012-02-28 09:38, Sven Neumann wrote:

> Well, this probably used to be a default uclibc configuration three
> years ago. Since then we have updated buildroot several times and
> obviously our ubclibc configuration diverged. What would be the best 
> way
> to go back to the default uclibc configuration?
>
> Nevertheless, you should consider the patch I've sent as the
> BR2_PACKAGE_E2FSPROGS_E4DEFRAG option is currently not correctly
> handled.
>
>
> Regards,
> Sven

It's likely, since then many new packages started using ftw extensively 
so the default configuration was updated, precisely by Thomas on April 
2010.
The option is handled by removing the binary when it is disabled... 
down in E2FSPROGS_BINTARGETS_$(BR2_PACKAGE_E2FSPROGS_E4DEFRAG) += 
e4defrag
However i see no harm in your patch so Acked by me in principle since 
it also fixes the bklid change.
Regards.

[Buildroot] build of e2fsprogs fails (2012.02-rc3)

[Sven Neumann]

Hi,

On Tue, 2012-02-28 at 09:49 -0300, Gustavo Zacarias wrote:
> On 2012-02-28 09:38, Sven Neumann wrote:
> 
> > Well, this probably used to be a default uclibc configuration three
> > years ago. Since then we have updated buildroot several times and
> > obviously our ubclibc configuration diverged. What would be the best 
> > way
> > to go back to the default uclibc configuration?
> >
> > Nevertheless, you should consider the patch I've sent as the
> > BR2_PACKAGE_E2FSPROGS_E4DEFRAG option is currently not correctly
> > handled.
> >
> >
> > Regards,
> > Sven
> 
> It's likely, since then many new packages started using ftw extensively 
> so the default configuration was updated, precisely by Thomas on April 
> 2010.

OK, I am now trying builds with the default uclibc configuration. I
don't remember why exactly we started to use a custom config file some
years ago. It was probably just because we did not know that this was a
bad idea that would bite us later.


Thanks for your help,
Sven

[Buildroot] [PATCH] e2fsprogs: disable build of e4defrag unless explicitly enabled

[Peter Korsgaard]

>>>>> "Sven" == Sven Neumann <s.neumann@raumfeld.com> writes:

 Sven> The e2fsprogs configure script enables the build of the e4defrag
 Sven> utility by default. Disable it unless BR2_PACKAGE_E2FSPROGS_E4DEFRAG
 Sven> is selected.

Committed to next, thanks.

-- 
Bye, Peter Korsgaard