* [Buildroot] [PATCH] Added the empty package
@ 2012-04-10 9:07 spdawson at gmail.com
0 siblings, 0 replies; 9+ messages in thread
From: spdawson at gmail.com @ 2012-04-10 9:07 UTC (permalink / raw)
To: buildroot
From: Simon Dawson <spdawson@gmail.com>
Signed-off-by: Simon Dawson <spdawson@gmail.com>
---
Tweaked initial patch: need to protect spaces in TARGET_CC and TARGET_LD
package/Config.in | 1 +
package/empty/Config.in | 6 ++++++
package/empty/empty.mk | 19 +++++++++++++++++++
3 files changed, 26 insertions(+), 0 deletions(-)
create mode 100644 package/empty/Config.in
create mode 100644 package/empty/empty.mk
diff --git a/package/Config.in b/package/Config.in
index 4c6d4d8..205fa8a 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -426,6 +426,7 @@ endmenu
endmenu
menu "Miscellaneous"
+source "package/empty/Config.in"
source "package/shared-mime-info/Config.in"
endmenu
diff --git a/package/empty/Config.in b/package/empty/Config.in
new file mode 100644
index 0000000..67b09fc
--- /dev/null
+++ b/package/empty/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_EMPTY
+ bool "empty"
+ help
+ Run processes and applications under pseudo-terminal (PTY) sessions.
+
+ http://empty.sourceforge.net/
diff --git a/package/empty/empty.mk b/package/empty/empty.mk
new file mode 100644
index 0000000..d15a18f
--- /dev/null
+++ b/package/empty/empty.mk
@@ -0,1 +1,19 @@
+#############################################################
+#
+# empty
+#
+#############################################################
+EMPTY_VERSION = 0.6.18b
+EMPTY_SOURCE = empty-$(EMPTY_VERSION).tgz
+EMPTY_SITE = http://downloads.sourceforge.net/project/empty/empty/empty-$(EMPTY_VERSION)
+
+define EMPTY_BUILD_CMDS
+ $(MAKE) CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D) all
+endef
+
+define EMPTY_INSTALL_TARGET_CMDS
+ $(INSTALL) -D $(@D)/empty $(TARGET_DIR)/usr/bin
+ -$(STRIPCMP) $(STRIP_STRIP_UNNEEDED) $(TARGET_DIR)/usr/bin/empty
+endef
+
+$(eval $(call GENTARGETS,package,empty))
--
1.7.5.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] Added the empty package
@ 2012-05-06 6:59 spdawson at gmail.com
2012-05-06 8:02 ` Peter Korsgaard
0 siblings, 1 reply; 9+ messages in thread
From: spdawson at gmail.com @ 2012-05-06 6:59 UTC (permalink / raw)
To: buildroot
From: Simon Dawson <spdawson@gmail.com>
Signed-off-by: Simon Dawson <spdawson@gmail.com>
---
package/Config.in | 1 +
package/empty/Config.in | 6 ++++++
package/empty/empty.mk | 18 ++++++++++++++++++
3 files changed, 25 insertions(+)
create mode 100644 package/empty/Config.in
create mode 100644 package/empty/empty.mk
diff --git a/package/Config.in b/package/Config.in
index 6caca9d..3e60660 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -467,6 +467,7 @@ endmenu
endmenu
menu "Miscellaneous"
+source "package/empty/Config.in"
source "package/shared-mime-info/Config.in"
endmenu
diff --git a/package/empty/Config.in b/package/empty/Config.in
new file mode 100644
index 0000000..67b09fc
--- /dev/null
+++ b/package/empty/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_EMPTY
+ bool "empty"
+ help
+ Run processes and applications under pseudo-terminal (PTY) sessions.
+
+ http://empty.sourceforge.net/
diff --git a/package/empty/empty.mk b/package/empty/empty.mk
new file mode 100644
index 0000000..137e196
--- /dev/null
+++ b/package/empty/empty.mk
@@ -0,0 +1,18 @@
+#############################################################
+#
+# empty
+#
+#############################################################
+EMPTY_VERSION = 0.6.18b
+EMPTY_SOURCE = empty-$(EMPTY_VERSION).tgz
+EMPTY_SITE = http://downloads.sourceforge.net/project/empty/empty/empty-$(EMPTY_VERSION)
+
+define EMPTY_BUILD_CMDS
+ $(MAKE) $(TARGET_CONFIGURE_OPTS) -C $(@D) all
+endef
+
+define EMPTY_INSTALL_TARGET_CMDS
+ $(INSTALL) -m 0755 -D $(@D)/empty $(TARGET_DIR)/usr/bin/empty
+endef
+
+$(eval $(call GENTARGETS))
--
1.7.9.5
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] Added the empty package
@ 2012-04-10 9:15 spdawson at gmail.com
2012-05-05 22:36 ` Peter Korsgaard
0 siblings, 1 reply; 9+ messages in thread
From: spdawson at gmail.com @ 2012-04-10 9:15 UTC (permalink / raw)
To: buildroot
From: Simon Dawson <spdawson@gmail.com>
Signed-off-by: Simon Dawson <spdawson@gmail.com>
---
Improved patch in response to comments
package/Config.in | 1 +
package/empty/Config.in | 6 ++++++
package/empty/empty.mk | 19 +++++++++++++++++++
3 files changed, 26 insertions(+), 0 deletions(-)
create mode 100644 package/empty/Config.in
create mode 100644 package/empty/empty.mk
diff --git a/package/Config.in b/package/Config.in
index 4c6d4d8..205fa8a 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -426,6 +426,7 @@ endmenu
endmenu
menu "Miscellaneous"
+source "package/empty/Config.in"
source "package/shared-mime-info/Config.in"
endmenu
diff --git a/package/empty/Config.in b/package/empty/Config.in
new file mode 100644
index 0000000..67b09fc
--- /dev/null
+++ b/package/empty/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_EMPTY
+ bool "empty"
+ help
+ Run processes and applications under pseudo-terminal (PTY) sessions.
+
+ http://empty.sourceforge.net/
diff --git a/package/empty/empty.mk b/package/empty/empty.mk
new file mode 100644
index 0000000..d15a18f
--- /dev/null
+++ b/package/empty/empty.mk
@@ -0,1 +1,18 @@
+#############################################################
+#
+# empty
+#
+#############################################################
+EMPTY_VERSION = 0.6.18b
+EMPTY_SOURCE = empty-$(EMPTY_VERSION).tgz
+EMPTY_SITE = http://downloads.sourceforge.net/project/empty/empty/empty-$(EMPTY_VERSION)
+
+define EMPTY_BUILD_CMDS
+ $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) all
+endef
+
+define EMPTY_INSTALL_TARGET_CMDS
+ $(INSTALL) -D $(@D)/empty $(TARGET_DIR)/usr/bin/empty
+endef
+
+$(eval $(call GENTARGETS))
--
1.7.5.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] Added the empty package
2012-04-10 9:15 spdawson at gmail.com
@ 2012-05-05 22:36 ` Peter Korsgaard
0 siblings, 0 replies; 9+ messages in thread
From: Peter Korsgaard @ 2012-05-05 22:36 UTC (permalink / raw)
To: buildroot
>>>>> "spdawson" == spdawson <spdawson@gmail.com> writes:
spdawson> From: Simon Dawson <spdawson@gmail.com>
spdawson> Signed-off-by: Simon Dawson <spdawson@gmail.com>
I was about to commit this, but noticed a few errors. Care to fix and
resubmit?
spdawson> new file mode 100644
spdawson> index 0000000..d15a18f
spdawson> --- /dev/null
spdawson> +++ b/package/empty/empty.mk
spdawson> @@ -0,1 +1,18 @@
I don't know where this first 0,1 comes from, but git am andn patch very
much dislikes it. I had to change it to to 0,0 to get the patch to
apply.
spdawson> +#############################################################
spdawson> +#
spdawson> +# empty
spdawson> +#
spdawson> +#############################################################
spdawson> +EMPTY_VERSION = 0.6.18b
spdawson> +EMPTY_SOURCE = empty-$(EMPTY_VERSION).tgz
spdawson> +EMPTY_SITE = http://downloads.sourceforge.net/project/empty/empty/empty-$(EMPTY_VERSION)
spdawson> +
spdawson> +define EMPTY_BUILD_CMDS
spdawson> + $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D) all
variables passed in the environment do not override settings in the
Makefile (unless ?= is used), so it ends up using my host compiler:
make[1]: Entering directory `/home/peko/source/buildroot/output/build/empty-0.6.18b'
gcc -pipe -Os -Wall -lutil -o empty empty.c
empty.c: In function ?pidbyppid?:
empty.c:689:9: warning: array subscript is above array bounds [-Warray-bounds]
make[1]: Leaving directory `/home/peko/source/buildroot/output/build/empty-0.6.18b'
I suggest you add TARGET_CONFIGURE_OPTS as a make argument instead.
spdawson> +endef
spdawson> +
spdawson> +define EMPTY_INSTALL_TARGET_CMDS
spdawson> + $(INSTALL) -D $(@D)/empty $(TARGET_DIR)/usr/bin/empty
We normally add explicit -m 0755 for installation of binaries.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] Added the empty package
@ 2012-04-10 9:10 spdawson at gmail.com
0 siblings, 0 replies; 9+ messages in thread
From: spdawson at gmail.com @ 2012-04-10 9:10 UTC (permalink / raw)
To: buildroot
From: Simon Dawson <spdawson@gmail.com>
Signed-off-by: Simon Dawson <spdawson@gmail.com>
---
Fixed install command to use full target file name
package/Config.in | 1 +
package/empty/Config.in | 6 ++++++
package/empty/empty.mk | 19 +++++++++++++++++++
3 files changed, 26 insertions(+), 0 deletions(-)
create mode 100644 package/empty/Config.in
create mode 100644 package/empty/empty.mk
diff --git a/package/Config.in b/package/Config.in
index 4c6d4d8..205fa8a 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -426,6 +426,7 @@ endmenu
endmenu
menu "Miscellaneous"
+source "package/empty/Config.in"
source "package/shared-mime-info/Config.in"
endmenu
diff --git a/package/empty/Config.in b/package/empty/Config.in
new file mode 100644
index 0000000..67b09fc
--- /dev/null
+++ b/package/empty/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_EMPTY
+ bool "empty"
+ help
+ Run processes and applications under pseudo-terminal (PTY) sessions.
+
+ http://empty.sourceforge.net/
diff --git a/package/empty/empty.mk b/package/empty/empty.mk
new file mode 100644
index 0000000..d15a18f
--- /dev/null
+++ b/package/empty/empty.mk
@@ -0,1 +1,19 @@
+#############################################################
+#
+# empty
+#
+#############################################################
+EMPTY_VERSION = 0.6.18b
+EMPTY_SOURCE = empty-$(EMPTY_VERSION).tgz
+EMPTY_SITE = http://downloads.sourceforge.net/project/empty/empty/empty-$(EMPTY_VERSION)
+
+define EMPTY_BUILD_CMDS
+ $(MAKE) CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D) all
+endef
+
+define EMPTY_INSTALL_TARGET_CMDS
+ $(INSTALL) -D $(@D)/empty $(TARGET_DIR)/usr/bin/empty
+ -$(STRIPCMP) $(STRIP_STRIP_UNNEEDED) $(TARGET_DIR)/usr/bin/empty
+endef
+
+$(eval $(call GENTARGETS,package,empty))
--
1.7.5.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] Added the empty package
@ 2012-04-10 8:52 spdawson at gmail.com
2012-04-10 9:06 ` Belisko Marek
0 siblings, 1 reply; 9+ messages in thread
From: spdawson at gmail.com @ 2012-04-10 8:52 UTC (permalink / raw)
To: buildroot
From: Simon Dawson <spdawson@gmail.com>
Signed-off-by: Simon Dawson <spdawson@gmail.com>
---
package/Config.in | 1 +
package/empty/Config.in | 6 ++++++
package/empty/empty.mk | 19 +++++++++++++++++++
3 files changed, 26 insertions(+), 0 deletions(-)
create mode 100644 package/empty/Config.in
create mode 100644 package/empty/empty.mk
diff --git a/package/Config.in b/package/Config.in
index 4c6d4d8..205fa8a 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -426,6 +426,7 @@ endmenu
endmenu
menu "Miscellaneous"
+source "package/empty/Config.in"
source "package/shared-mime-info/Config.in"
endmenu
diff --git a/package/empty/Config.in b/package/empty/Config.in
new file mode 100644
index 0000000..67b09fc
--- /dev/null
+++ b/package/empty/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_EMPTY
+ bool "empty"
+ help
+ Run processes and applications under pseudo-terminal (PTY) sessions.
+
+ http://empty.sourceforge.net/
diff --git a/package/empty/empty.mk b/package/empty/empty.mk
new file mode 100644
index 0000000..d15a18f
--- /dev/null
+++ b/package/empty/empty.mk
@@ -0,0 +1,19 @@
+#############################################################
+#
+# empty
+#
+#############################################################
+EMPTY_VERSION = 0.6.18b
+EMPTY_SOURCE = empty-$(EMPTY_VERSION).tgz
+EMPTY_SITE = http://downloads.sourceforge.net/project/empty/empty/empty-$(EMPTY_VERSION)
+
+define EMPTY_BUILD_CMDS
+ $(MAKE) CC=$(TARGET_CC) LD=$(TARGET_LD) -C $(@D) all
+endef
+
+define EMPTY_INSTALL_TARGET_CMDS
+ $(INSTALL) -D $(@D)/empty $(TARGET_DIR)/usr/bin
+ -$(STRIPCMP) $(STRIP_STRIP_UNNEEDED) $(TARGET_DIR)/usr/bin/empty
+endef
+
+$(eval $(call GENTARGETS,package,empty))
--
1.7.5.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] Added the empty package
2012-04-10 8:52 spdawson at gmail.com
@ 2012-04-10 9:06 ` Belisko Marek
2012-04-10 9:12 ` Thomas Petazzoni
0 siblings, 1 reply; 9+ messages in thread
From: Belisko Marek @ 2012-04-10 9:06 UTC (permalink / raw)
To: buildroot
Hi,
On Tue, Apr 10, 2012 at 10:52 AM, <spdawson@gmail.com> wrote:
> From: Simon Dawson <spdawson@gmail.com>
>
> Signed-off-by: Simon Dawson <spdawson@gmail.com>
> ---
> ?package/Config.in ? ? ? | ? ?1 +
> ?package/empty/Config.in | ? ?6 ++++++
> ?package/empty/empty.mk ?| ? 19 +++++++++++++++++++
> ?3 files changed, 26 insertions(+), 0 deletions(-)
> ?create mode 100644 package/empty/Config.in
> ?create mode 100644 package/empty/empty.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 4c6d4d8..205fa8a 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -426,6 +426,7 @@ endmenu
> ?endmenu
>
> ?menu "Miscellaneous"
> +source "package/empty/Config.in"
> ?source "package/shared-mime-info/Config.in"
> ?endmenu
>
> diff --git a/package/empty/Config.in b/package/empty/Config.in
> new file mode 100644
> index 0000000..67b09fc
> --- /dev/null
> +++ b/package/empty/Config.in
> @@ -0,0 +1,6 @@
> +config BR2_PACKAGE_EMPTY
> + ? ? ? bool "empty"
> + ? ? ? help
> + ? ? ? ? Run processes and applications under pseudo-terminal (PTY) sessions.
> +
> + ? ? ? ? http://empty.sourceforge.net/
> diff --git a/package/empty/empty.mk b/package/empty/empty.mk
> new file mode 100644
> index 0000000..d15a18f
> --- /dev/null
> +++ b/package/empty/empty.mk
> @@ -0,0 +1,19 @@
> +#############################################################
> +#
> +# empty
> +#
> +#############################################################
> +EMPTY_VERSION = 0.6.18b
> +EMPTY_SOURCE = empty-$(EMPTY_VERSION).tgz
> +EMPTY_SITE = http://downloads.sourceforge.net/project/empty/empty/empty-$(EMPTY_VERSION)
> +
> +define EMPTY_BUILD_CMDS
> + ? ? ? $(MAKE) CC=$(TARGET_CC) LD=$(TARGET_LD) -C $(@D) all
Instead CC and LD use $(TARGET_CONFIGURE_OPTS) which does the job.
> +endef
> +
> +define EMPTY_INSTALL_TARGET_CMDS
> + ? ? ? $(INSTALL) -D $(@D)/empty $(TARGET_DIR)/usr/bin
You need to specify name also for target directory so then:
+ $(INSTALL) -D $(@D)/empty $(TARGET_DIR)/usr/bin/empty
> + ? ? ? -$(STRIPCMP) $(STRIP_STRIP_UNNEEDED) $(TARGET_DIR)/usr/bin/empty
> +endef
> +
> +$(eval $(call GENTARGETS,package,empty))
> --
> 1.7.5.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
regards,
marek
--
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer
Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
twitter: #opennandra
web: http://open-nandra.com
^ permalink raw reply [flat|nested] 9+ messages in thread
* [Buildroot] [PATCH] Added the empty package
2012-04-10 9:06 ` Belisko Marek
@ 2012-04-10 9:12 ` Thomas Petazzoni
0 siblings, 0 replies; 9+ messages in thread
From: Thomas Petazzoni @ 2012-04-10 9:12 UTC (permalink / raw)
To: buildroot
Le Tue, 10 Apr 2012 11:06:57 +0200,
Belisko Marek <marek.belisko@gmail.com> a ?crit :
> > +define EMPTY_INSTALL_TARGET_CMDS
> > + ? ? ? $(INSTALL) -D $(@D)/empty $(TARGET_DIR)/usr/bin
> You need to specify name also for target directory so then:
> + $(INSTALL) -D $(@D)/empty $(TARGET_DIR)/usr/bin/empty
>
> > + ? ? ? -$(STRIPCMP) $(STRIP_STRIP_UNNEEDED)
> > $(TARGET_DIR)/usr/bin/empty +endef
No need to call $(STRIPCMP), this is done automatically by Buildroot.
> > +$(eval $(call GENTARGETS,package,empty))
The GENTARGETS arguments are useless.
Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2012-05-06 8:02 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-10 9:07 [Buildroot] [PATCH] Added the empty package spdawson at gmail.com
-- strict thread matches above, loose matches on Subject: below --
2012-05-06 6:59 spdawson at gmail.com
2012-05-06 8:02 ` Peter Korsgaard
2012-04-10 9:15 spdawson at gmail.com
2012-05-05 22:36 ` Peter Korsgaard
2012-04-10 9:10 spdawson at gmail.com
2012-04-10 8:52 spdawson at gmail.com
2012-04-10 9:06 ` Belisko Marek
2012-04-10 9:12 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox