Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] gpsd: disallow profiling support with Buildroot toolchain
@ 2012-07-24  8:42 spdawson at gmail.com
  2012-07-24  8:51 ` Thomas Petazzoni
  0 siblings, 1 reply; 3+ messages in thread
From: spdawson at gmail.com @ 2012-07-24  8:42 UTC (permalink / raw)
  To: buildroot

From: Simon Dawson <spdawson@gmail.com>

The following problem was reported by Thomas Petazzoni.

If BR2_PACKAGE_GPSD_PROFILING is enabled with a Buildroot toolchain, then
gpsd fails to build. See the following for details.

  http://autobuild.buildroot.org/results/be707893f4bf0e7e964d183e4a655c5bb72d1889/build-end.log
  http://autobuild.buildroot.org/results/be707893f4bf0e7e964d183e4a655c5bb72d1889/defconfig.

The issue is that uClibc lacks the necessary infrastructure to support
profiling. This patch disallows selection of the gpsd profiling feature when
the Buildroot toolchain is selected.

Signed-off-by: Simon Dawson <spdawson@gmail.com>
---
 package/gpsd/Config.in |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/gpsd/Config.in b/package/gpsd/Config.in
index 18e21e5..6aa2deb 100644
--- a/package/gpsd/Config.in
+++ b/package/gpsd/Config.in
@@ -31,6 +31,10 @@ config BR2_PACKAGE_GPSD_OLDSTYLE
 
 config BR2_PACKAGE_GPSD_PROFILING
 	bool "profiling support"
+	depends on !BR2_TOOLCHAIN_BUILDROOT
+
+comment "profiling support not available with Buildroot toolchain"
+	depends on BR2_TOOLCHAIN_BUILDROOT
 
 config BR2_PACKAGE_GPSD_NTP_SHM
 	bool "NTP time hinting support"
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] gpsd: disallow profiling support with Buildroot toolchain
  2012-07-24  8:42 [Buildroot] [PATCH] gpsd: disallow profiling support with Buildroot toolchain spdawson at gmail.com
@ 2012-07-24  8:51 ` Thomas Petazzoni
  2012-07-24 12:24   ` Simon Dawson
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2012-07-24  8:51 UTC (permalink / raw)
  To: buildroot

Le Tue, 24 Jul 2012 09:42:17 +0100,
spdawson at gmail.com a ?crit :

> +comment "profiling support not available with Buildroot toolchain"
> +	depends on BR2_TOOLCHAIN_BUILDROOT

Is the problem Buildroot-toolchain related, or uClibc related? If it's
uClibc related, it will also show up with uClibc-based external
toolchains and uClibc-based toolchains generated by the Crosstool-NG
backend.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] gpsd: disallow profiling support with Buildroot toolchain
  2012-07-24  8:51 ` Thomas Petazzoni
@ 2012-07-24 12:24   ` Simon Dawson
  0 siblings, 0 replies; 3+ messages in thread
From: Simon Dawson @ 2012-07-24 12:24 UTC (permalink / raw)
  To: buildroot

On 24 July 2012 09:51, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Le Tue, 24 Jul 2012 09:42:17 +0100,
> spdawson at gmail.com a ?crit :
>
>> +comment "profiling support not available with Buildroot toolchain"
>> +     depends on BR2_TOOLCHAIN_BUILDROOT
>
> Is the problem Buildroot-toolchain related, or uClibc related? If it's
> uClibc related, it will also show up with uClibc-based external
> toolchains and uClibc-based toolchains generated by the Crosstool-NG
> backend.

Okay, thanks Thomas. I'll fix and resubmit.

Simon.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-07-24 12:24 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-24  8:42 [Buildroot] [PATCH] gpsd: disallow profiling support with Buildroot toolchain spdawson at gmail.com
2012-07-24  8:51 ` Thomas Petazzoni
2012-07-24 12:24   ` Simon Dawson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox