* [Buildroot] [PATCH 1/2] logrotate: nees mmu
@ 2013-10-01 2:31 Axel Lin
2013-10-01 2:32 ` [Buildroot] [PATCH 2/2] logrotate: bump to version 3.8.6 Axel Lin
2013-10-01 7:32 ` [Buildroot] [PATCH 1/2] logrotate: nees mmu Thomas Petazzoni
0 siblings, 2 replies; 5+ messages in thread
From: Axel Lin @ 2013-10-01 2:31 UTC (permalink / raw)
To: buildroot
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
Fix below build error:
logrotate.o: In function `switch_user_permanently':
/opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:129: undefined reference to `fork'
logrotate.o: In function `removeLogFile':
/opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:431: undefined reference to `fork'
logrotate.o: In function `mailLog':
/opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:597: undefined reference to `fork'
/opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:615: undefined reference to `fork'
logrotate.o: In function `compressLogFile':
/opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:533: undefined reference to `fork'
collect2: ld returned 1 exit status
make[1]: *** [logrotate] Error 1
package/logrotate/Config.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/logrotate/Config.in b/package/logrotate/Config.in
index 0d0ec61..bc7b295 100644
--- a/package/logrotate/Config.in
+++ b/package/logrotate/Config.in
@@ -2,6 +2,7 @@ config BR2_PACKAGE_LOGROTATE
bool "logrotate"
select BR2_PACKAGE_POPT
depends on BR2_USE_WCHAR
+ depends on BR2_USE_MMU # fork()
help
A simple program to rotate logs.
--
1.8.1.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 2/2] logrotate: bump to version 3.8.6
2013-10-01 2:31 [Buildroot] [PATCH 1/2] logrotate: nees mmu Axel Lin
@ 2013-10-01 2:32 ` Axel Lin
2013-10-01 19:33 ` Peter Korsgaard
2013-10-01 7:32 ` [Buildroot] [PATCH 1/2] logrotate: nees mmu Thomas Petazzoni
1 sibling, 1 reply; 5+ messages in thread
From: Axel Lin @ 2013-10-01 2:32 UTC (permalink / raw)
To: buildroot
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
package/logrotate/logrotate.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/logrotate/logrotate.mk b/package/logrotate/logrotate.mk
index f5ef0b9..4bae431 100644
--- a/package/logrotate/logrotate.mk
+++ b/package/logrotate/logrotate.mk
@@ -4,7 +4,7 @@
#
################################################################################
-LOGROTATE_VERSION = 3.8.4
+LOGROTATE_VERSION = 3.8.6
LOGROTATE_SOURCE = logrotate-$(LOGROTATE_VERSION).tar.gz
LOGROTATE_SITE = https://www.fedorahosted.org/releases/l/o/logrotate/
LOGROTATE_LICENSE = GPLv2+
--
1.8.1.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/2] logrotate: nees mmu
2013-10-01 2:31 [Buildroot] [PATCH 1/2] logrotate: nees mmu Axel Lin
2013-10-01 2:32 ` [Buildroot] [PATCH 2/2] logrotate: bump to version 3.8.6 Axel Lin
@ 2013-10-01 7:32 ` Thomas Petazzoni
2013-10-01 8:08 ` Axel Lin
1 sibling, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2013-10-01 7:32 UTC (permalink / raw)
To: buildroot
Dear Axel Lin,
On Tue, 01 Oct 2013 10:31:42 +0800, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> Fix below build error:
>
> logrotate.o: In function `switch_user_permanently':
> /opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:129: undefined reference to `fork'
> logrotate.o: In function `removeLogFile':
> /opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:431: undefined reference to `fork'
> logrotate.o: In function `mailLog':
> /opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:597: undefined reference to `fork'
> /opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:615: undefined reference to `fork'
> logrotate.o: In function `compressLogFile':
> /opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:533: undefined reference to `fork'
> collect2: ld returned 1 exit status
> make[1]: *** [logrotate] Error 1
It's a minor comment, but I believe the log of the error could go
within the commit log itself (i.e, before the --- separator). It really
is part of the explanation of why the change is needed.
Note that there is no need to resend this patch just for this reason,
it was merely a suggestion for future patches.
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 1/2] logrotate: nees mmu
2013-10-01 7:32 ` [Buildroot] [PATCH 1/2] logrotate: nees mmu Thomas Petazzoni
@ 2013-10-01 8:08 ` Axel Lin
0 siblings, 0 replies; 5+ messages in thread
From: Axel Lin @ 2013-10-01 8:08 UTC (permalink / raw)
To: buildroot
2013/10/1 Thomas Petazzoni <thomas.petazzoni@free-electrons.com>:
> Dear Axel Lin,
>
> On Tue, 01 Oct 2013 10:31:42 +0800, Axel Lin wrote:
>> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>> ---
>> Fix below build error:
>>
>> logrotate.o: In function `switch_user_permanently':
>> /opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:129: undefined reference to `fork'
>> logrotate.o: In function `removeLogFile':
>> /opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:431: undefined reference to `fork'
>> logrotate.o: In function `mailLog':
>> /opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:597: undefined reference to `fork'
>> /opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:615: undefined reference to `fork'
>> logrotate.o: In function `compressLogFile':
>> /opt/test/buildroot/buildroot/output/build/logrotate-3.8.4/logrotate.c:533: undefined reference to `fork'
>> collect2: ld returned 1 exit status
>> make[1]: *** [logrotate] Error 1
>
> It's a minor comment, but I believe the log of the error could go
> within the commit log itself (i.e, before the --- separator). It really
> is part of the explanation of why the change is needed.
>
> Note that there is no need to resend this patch just for this reason,
> it was merely a suggestion for future patches.
Actually, I check git log before sending patches.
Some commit log includes a link to the autobuild build log.
But I don't find any commit log with build error so I didn't include the
build error messages.
I just add the error messages here to make it easier for review.
Anyway, I will include the error message in commit log next time I send a patch.
Regards,
Axel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-10-01 19:33 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-01 2:31 [Buildroot] [PATCH 1/2] logrotate: nees mmu Axel Lin
2013-10-01 2:32 ` [Buildroot] [PATCH 2/2] logrotate: bump to version 3.8.6 Axel Lin
2013-10-01 19:33 ` Peter Korsgaard
2013-10-01 7:32 ` [Buildroot] [PATCH 1/2] logrotate: nees mmu Thomas Petazzoni
2013-10-01 8:08 ` Axel Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox