[Buildroot] [PATCH] rt-tests: fix build of NTPL dependent tests

[Buildroot] [PATCH] rt-tests: fix build of NTPL dependent tests

[Baruch Siach]

Commit 143fe5b443da4 (rt-tests: allow building subset of tests with non-NPTL
toolchains) disabled build of NPTL dependent tests unconditionally. Fix this.

Cc: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
Reported-by: "Williams Jr., Ernest L." <ernesto@slac.stanford.edu>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 package/rt-tests/rt-tests.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/rt-tests/rt-tests.mk b/package/rt-tests/rt-tests.mk
index e0c7748c9c3b..009e9a6818ce 100644
--- a/package/rt-tests/rt-tests.mk
+++ b/package/rt-tests/rt-tests.mk
@@ -15,6 +15,8 @@ endif
 
 ifeq ($(BR2_TOOLCHAIN_HAS_THREADS_NPTL),)
 RT_TESTS_HAVE_NPTL=no
+else
+RT_TESTS_HAVE_NPTL=yes
 endif
 
 define RT_TESTS_BUILD_CMDS
-- 
2.1.4

[Buildroot] [PATCH] rt-tests: fix build of NTPL dependent tests

[Alexey Brodkin]

Hi Baruch,

On Thu, 2015-01-15 at 09:19 +0200, Baruch Siach wrote:
> Commit 143fe5b443da4 (rt-tests: allow building subset of tests with non-NPTL
> toolchains) disabled build of NPTL dependent tests unconditionally. Fix this.
> 
> Cc: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
> Reported-by: "Williams Jr., Ernest L." <ernesto@slac.stanford.edu>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  package/rt-tests/rt-tests.mk | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/rt-tests/rt-tests.mk b/package/rt-tests/rt-tests.mk
> index e0c7748c9c3b..009e9a6818ce 100644
> --- a/package/rt-tests/rt-tests.mk
> +++ b/package/rt-tests/rt-tests.mk
> @@ -15,6 +15,8 @@ endif
>  
>  ifeq ($(BR2_TOOLCHAIN_HAS_THREADS_NPTL),)
>  RT_TESTS_HAVE_NPTL=no
> +else
> +RT_TESTS_HAVE_NPTL=yes
>  endif

My bad - indeed if build system passes "HAVE_NPTL=" to "rt-tests" then
default "yes" won't be used in rt-test's Makefile (I mean "HAVE_NPTL ?=
yes").

Thanks for fixing this.

Please don't hesitate to add:
--->8---
Tested-by: Alexey Brodkin <abrodkin@synpsys.com>
--->8---

Regards,
Alexey

[Buildroot] [PATCH] rt-tests: fix build of NTPL dependent tests

[Baruch Siach]

Hi buildroot list,

s/NTPL/NPTL/ in subject. Sorry.

baruch

On Thu, Jan 15, 2015 at 09:19:36AM +0200, Baruch Siach wrote:
> Commit 143fe5b443da4 (rt-tests: allow building subset of tests with non-NPTL
> toolchains) disabled build of NPTL dependent tests unconditionally. Fix this.
> 
> Cc: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
> Reported-by: "Williams Jr., Ernest L." <ernesto@slac.stanford.edu>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  package/rt-tests/rt-tests.mk | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/rt-tests/rt-tests.mk b/package/rt-tests/rt-tests.mk
> index e0c7748c9c3b..009e9a6818ce 100644
> --- a/package/rt-tests/rt-tests.mk
> +++ b/package/rt-tests/rt-tests.mk
> @@ -15,6 +15,8 @@ endif
>  
>  ifeq ($(BR2_TOOLCHAIN_HAS_THREADS_NPTL),)
>  RT_TESTS_HAVE_NPTL=no
> +else
> +RT_TESTS_HAVE_NPTL=yes
>  endif
>  
>  define RT_TESTS_BUILD_CMDS
> -- 
> 2.1.4
> 

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

[Buildroot] [PATCH] rt-tests: fix build of NTPL dependent tests

[Thomas Petazzoni]

Dear Baruch Siach,

On Thu, 15 Jan 2015 09:19:36 +0200, Baruch Siach wrote:
> Commit 143fe5b443da4 (rt-tests: allow building subset of tests with non-NPTL
> toolchains) disabled build of NPTL dependent tests unconditionally. Fix this.
> 
> Cc: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
> Reported-by: "Williams Jr., Ernest L." <ernesto@slac.stanford.edu>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  package/rt-tests/rt-tests.mk | 2 ++
>  1 file changed, 2 insertions(+)

Thanks, applied, after fixing the commit title, and reversing the
condition to use positive logic.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com