Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Jörg Krause" <joerg.krause@embedded.rocks>
To: buildroot@busybox.net
Subject: [Buildroot] Worried about patches not being merged?
Date: Fri, 20 Mar 2015 16:33:16 +0100	[thread overview]
Message-ID: <1426865596.27254.23.camel@embedded.rocks> (raw)
In-Reply-To: <20150319092042.2875d9e1@free-electrons.com>

Hi Thomas,

On Do, 2015-03-19 at 09:20 +0100, Thomas Petazzoni wrote:
> J?rg,
> 
> On Wed, 18 Mar 2015 21:01:06 +0100, J?rg Krause wrote:
> 
> > Are there any guidelines for reviewing?
> 
> Not really. Just pick patches touching things you are a bit comfortable
> with, give them some testing, and do some comments if needed. On the
> other hand, if you think the patch is fine, simply reply with a
> Reviewed-by tag.

To be honest, I'm only looking for packages I'm currently using or which
seems to be interesting to me. I must confess I don't have the time to
review/test patches I don't care about or which looks to complex.

Following the mailing list for some months now I noticed that there is a
team of five to ten main contributers which do the most reviews and
tests. Maybe a section in the documentation  

I think patches should be classified as you mentioned in another mail. I
like the idea have having tags like "infrastructure", "new package",
"version bump", ..., to get a quick overview.

> Of course, reviewing simple package bumps or hash file additions is not
> very useful, since I tend to apply such patches quickly: there is not
> much potential trouble with such patches.
> 
> > It's a pitty that GSoC did not accepted Buildroot this year. The
> > testing scripts would be a nice feature.
> 
> Yes, it is a pitty, but hopefully someone will pick up the task and
> work on improving our QA tooling :)

Hopefully!

  reply	other threads:[~2015-03-20 15:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-04 22:21 [Buildroot] Worried about patches not being merged? Thomas Petazzoni
2015-03-18 20:01 ` Jörg Krause
2015-03-19  8:20   ` Thomas Petazzoni
2015-03-20 15:33     ` Jörg Krause [this message]
2015-03-20 15:37       ` Thomas Petazzoni
2015-03-19  8:35   ` Angelo Compagnucci
2015-03-19  9:16     ` Thomas Petazzoni
2015-03-19  9:34       ` Angelo Compagnucci
2015-03-19 10:25         ` Angelo Compagnucci
2015-03-19 10:26         ` Thomas Petazzoni
2015-03-19 10:45           ` Angelo Compagnucci
2015-03-19 11:09             ` Thomas Petazzoni
2015-03-19 22:27               ` Angelo Compagnucci
2015-03-20 16:02                 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426865596.27254.23.camel@embedded.rocks \
    --to=joerg.krause@embedded.rocks \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox