Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/pkg-kconfig: define KCONFIG_EDITORS_MAKE_ENV
Date: Thu, 2 Jul 2015 07:56:19 +0000	[thread overview]
Message-ID: <1435823779.2966.31.camel@synopsys.com> (raw)
In-Reply-To: <20150702095217.6813b8c5@free-electrons.com>

Hi Thomas,

On Thu, 2015-07-02 at 09:52 +0200, Thomas Petazzoni wrote:
> Dear Alexey Brodkin,
> 
> On Thu, 2 Jul 2015 07:44:05 +0000, Alexey Brodkin wrote:
> 
> > I'm wondering why did you put 2 patches in one series?
> >  [1] https://patchwork.ozlabs.org/patch/489307/
> >  [2] https://patchwork.ozlabs.org/patch/489306/
> > 
> > I'd say these 2 patches solve completely different problems and so
> > should be posted as 2 separate patches compared to your [PATCH 
> > 1/2],
> > [PATCH 2/2].
> 
> I agree they are not related.
> 
> > The problem with series patches within series could not be applied
> > separately, that means chances are you may not get either applied
> > because:
> 
> That's not really true. I tend to try to apply all patches I can from 
> a
> series, even if certain other patches of the series cannot be 
> applied.
> Look at the SELinux series for example. I have not applied some of 
> the
> first patches of the series, but already applied some patches later 
> in
> the series.
> 
> So while I agree it's a bit weird to mix completely independent stuff 
> in
> one single patch series, it's not actually that problematic.

Makes sense.

What about mentioned problem with patch rebase that is only required
because of line number changes?

In this particular case a few more lines were added in the file and so
"git am" fails while "patch" succeeds with message about offset like
that:
----------------->8-----------------
patching file package/pkg-kconfig.mk
Hunk #1 succeeded at 109 with fuzz 2 (offset 33 lines).
----------------->8-----------------

Is my proposal for resend is valid or you may handle it yourself?

-Alexey

  reply	other threads:[~2015-07-02  7:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-29 12:50 [Buildroot] [PATCH 1/2] package/gcc: fix ARC failure to build in 2 phases Tal Zilcer
2015-06-29 12:50 ` [Buildroot] [PATCH 2/2] package/pkg-kconfig: define KCONFIG_EDITORS_MAKE_ENV Tal Zilcer
2015-07-02  7:44   ` Alexey Brodkin
2015-07-02  7:52     ` Thomas Petazzoni
2015-07-02  7:56       ` Alexey Brodkin [this message]
2015-06-29 14:29 ` [Buildroot] [PATCH 1/2] package/gcc: fix ARC failure to build in 2 phases Thomas Petazzoni
2015-06-29 15:39   ` Tal Zilcer
2015-06-29 15:49     ` Thomas Petazzoni
2015-07-02  7:46       ` Alexey Brodkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1435823779.2966.31.camel@synopsys.com \
    --to=alexey.brodkin@synopsys.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox