Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/gcc: fix ARC failure to build in 2 phases.
Date: Mon, 29 Jun 2015 16:29:06 +0200	[thread overview]
Message-ID: <20150629162906.415e456f@free-electrons.com> (raw)
In-Reply-To: <1435582227-26345-1-git-send-email-talz@ezchip.com>

Dear Tal Zilcer,

On Mon, 29 Jun 2015 15:50:26 +0300, Tal Zilcer wrote:

> diff --git a/package/gcc/gcc-initial/gcc-initial.mk b/package/gcc/gcc-initial/gcc-initial.mk
> index 0fa2353..6b747d0 100644
> --- a/package/gcc/gcc-initial/gcc-initial.mk
> +++ b/package/gcc/gcc-initial/gcc-initial.mk
> @@ -33,7 +33,11 @@ define HOST_GCC_INITIAL_DISABLE_LIBGMON
>  	$(SED) 's/crtbeginS.o libgmon.a crtg.o/crtbeginS.o crtg.o/' \
>  		$(@D)/libgcc/config.host
>  endef
> +ifeq ($(HOST_GCC_INITIAL_OVERRIDE_SRCDIR),)
>  HOST_GCC_INITIAL_POST_PATCH_HOOKS += HOST_GCC_INITIAL_DISABLE_LIBGMON
> +else
> +HOST_GCC_INITIAL_POST_RSYNC_HOOKS += HOST_GCC_INITIAL_DISABLE_LIBGMON
> +endif
>  endif
>  
>  HOST_GCC_INITIAL_CONF_OPTS = \

If you're using <pkg>_OVERRIDE_SRCDIR, then the assumption is that your
source tree is patched with whatever change is needed for the package
to build fine without applying any of the Buildroot patches.

In any case, I don't think it's worth the effort making that
conditional, just register the post-rsync hook unconditionally.

BTW, this problem should have been sorted out by the ARC developers,
maybe you should ping them about this?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  parent reply	other threads:[~2015-06-29 14:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-29 12:50 [Buildroot] [PATCH 1/2] package/gcc: fix ARC failure to build in 2 phases Tal Zilcer
2015-06-29 12:50 ` [Buildroot] [PATCH 2/2] package/pkg-kconfig: define KCONFIG_EDITORS_MAKE_ENV Tal Zilcer
2015-07-02  7:44   ` Alexey Brodkin
2015-07-02  7:52     ` Thomas Petazzoni
2015-07-02  7:56       ` Alexey Brodkin
2015-06-29 14:29 ` Thomas Petazzoni [this message]
2015-06-29 15:39   ` [Buildroot] [PATCH 1/2] package/gcc: fix ARC failure to build in 2 phases Tal Zilcer
2015-06-29 15:49     ` Thomas Petazzoni
2015-07-02  7:46       ` Alexey Brodkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150629162906.415e456f@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox