Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] qt: enable Script and WebKit modules for ARC
Date: Mon, 20 Jul 2015 07:58:30 +0000	[thread overview]
Message-ID: <1437379110.4091.5.camel@synopsys.com> (raw)
In-Reply-To: <20150718192015.3676e5a8@free-electrons.com>

Hi Thomas,

On Sat, 2015-07-18 at 19:20 +0200, Thomas Petazzoni wrote:
> Dear Alexey Brodkin,
> 
> On Wed, 15 Jul 2015 16:47:17 +0300, Alexey Brodkin wrote:
> 
> > diff --git a/package/qt/Config.in b/package/qt/Config.in
> > index 306fe1f..cadc784 100644
> > --- a/package/qt/Config.in
> > +++ b/package/qt/Config.in
> > @@ -412,7 +412,8 @@ config BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
> >  	default y if BR2_arm || BR2_armeb || BR2_i386 || BR2_microblazeel || \
> >  		BR2_microblazebe || BR2_mips || BR2_mipsel || \
> >  		(BR2_mips64 || BR2_mips64el) && !BR2_MIPS_NABI32 || BR2_powerpc || \
> > -		BR2_powerpc64 || BR2_powerpc64le || BR2_sparc || BR2_x86_64
> > +		BR2_powerpc64 || BR2_powerpc64le || BR2_sparc || BR2_x86_64 || \
> > +		BR2_arc
> 
> Alphabetic ordering was not correct (for both), so I've fixed that up
> and applied, thanks!

I'm sorry that you had to rework this but I put ARC in the end consciously.
As an extension to existing arches. But if alphabetical order is preferred
in Buildroot even for things added later I'll keep this in mind for the future.

And thanks a lot for fixing this minor issue.

-Alexey

      reply	other threads:[~2015-07-20  7:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-15 13:47 [Buildroot] [PATCH] qt: enable Script and WebKit modules for ARC Alexey Brodkin
2015-07-18 17:20 ` Thomas Petazzoni
2015-07-20  7:58   ` Alexey Brodkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1437379110.4091.5.camel@synopsys.com \
    --to=alexey.brodkin@synopsys.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox