Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] qt: enable Script and WebKit modules for ARC
@ 2015-07-15 13:47 Alexey Brodkin
  2015-07-18 17:20 ` Thomas Petazzoni
  0 siblings, 1 reply; 3+ messages in thread
From: Alexey Brodkin @ 2015-07-15 13:47 UTC (permalink / raw)
  To: buildroot

Now when ARC toolchain also supports NPTL both Qt's Script and WebKit
modules could be successfully built and then executed on ARC.

Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/qt/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/package/qt/Config.in b/package/qt/Config.in
index 306fe1f..cadc784 100644
--- a/package/qt/Config.in
+++ b/package/qt/Config.in
@@ -412,7 +412,8 @@ config BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
 	default y if BR2_arm || BR2_armeb || BR2_i386 || BR2_microblazeel || \
 		BR2_microblazebe || BR2_mips || BR2_mipsel || \
 		(BR2_mips64 || BR2_mips64el) && !BR2_MIPS_NABI32 || BR2_powerpc || \
-		BR2_powerpc64 || BR2_powerpc64le || BR2_sparc || BR2_x86_64
+		BR2_powerpc64 || BR2_powerpc64le || BR2_sparc || BR2_x86_64 || \
+		BR2_arc
 	# The CodeSourcery SuperH toolchain fails to build Webkit,
 	# with an assertion failure in binutils.
 	default y if (BR2_sh4 || BR2_sh4eb || BR2_sh4a || BR2_sh4aeb) && \
@@ -459,7 +460,7 @@ config BR2_PACKAGE_QT_ARCH_SUPPORTS_SCRIPT
 		BR2_microblazeel || BR2_microblazebe || BR2_mips || BR2_mipsel || \
 		BR2_mips64 || BR2_mips64el || BR2_nios2 || BR2_powerpc || \
 		BR2_powerpc64 || BR2_powerpc64le || BR2_sh4 || BR2_sh4eb || \
-		BR2_sh4a || BR2_sh4aeb || BR2_sparc || BR2_x86_64
+		BR2_sh4a || BR2_sh4aeb || BR2_sparc || BR2_x86_64 || BR2_arc
 
 config BR2_PACKAGE_QT_SCRIPT
 	bool "Script Module"
-- 
2.4.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] qt: enable Script and WebKit modules for ARC
  2015-07-15 13:47 [Buildroot] [PATCH] qt: enable Script and WebKit modules for ARC Alexey Brodkin
@ 2015-07-18 17:20 ` Thomas Petazzoni
  2015-07-20  7:58   ` Alexey Brodkin
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2015-07-18 17:20 UTC (permalink / raw)
  To: buildroot

Dear Alexey Brodkin,

On Wed, 15 Jul 2015 16:47:17 +0300, Alexey Brodkin wrote:

> diff --git a/package/qt/Config.in b/package/qt/Config.in
> index 306fe1f..cadc784 100644
> --- a/package/qt/Config.in
> +++ b/package/qt/Config.in
> @@ -412,7 +412,8 @@ config BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
>  	default y if BR2_arm || BR2_armeb || BR2_i386 || BR2_microblazeel || \
>  		BR2_microblazebe || BR2_mips || BR2_mipsel || \
>  		(BR2_mips64 || BR2_mips64el) && !BR2_MIPS_NABI32 || BR2_powerpc || \
> -		BR2_powerpc64 || BR2_powerpc64le || BR2_sparc || BR2_x86_64
> +		BR2_powerpc64 || BR2_powerpc64le || BR2_sparc || BR2_x86_64 || \
> +		BR2_arc

Alphabetic ordering was not correct (for both), so I've fixed that up
and applied, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] qt: enable Script and WebKit modules for ARC
  2015-07-18 17:20 ` Thomas Petazzoni
@ 2015-07-20  7:58   ` Alexey Brodkin
  0 siblings, 0 replies; 3+ messages in thread
From: Alexey Brodkin @ 2015-07-20  7:58 UTC (permalink / raw)
  To: buildroot

Hi Thomas,

On Sat, 2015-07-18 at 19:20 +0200, Thomas Petazzoni wrote:
> Dear Alexey Brodkin,
> 
> On Wed, 15 Jul 2015 16:47:17 +0300, Alexey Brodkin wrote:
> 
> > diff --git a/package/qt/Config.in b/package/qt/Config.in
> > index 306fe1f..cadc784 100644
> > --- a/package/qt/Config.in
> > +++ b/package/qt/Config.in
> > @@ -412,7 +412,8 @@ config BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
> >  	default y if BR2_arm || BR2_armeb || BR2_i386 || BR2_microblazeel || \
> >  		BR2_microblazebe || BR2_mips || BR2_mipsel || \
> >  		(BR2_mips64 || BR2_mips64el) && !BR2_MIPS_NABI32 || BR2_powerpc || \
> > -		BR2_powerpc64 || BR2_powerpc64le || BR2_sparc || BR2_x86_64
> > +		BR2_powerpc64 || BR2_powerpc64le || BR2_sparc || BR2_x86_64 || \
> > +		BR2_arc
> 
> Alphabetic ordering was not correct (for both), so I've fixed that up
> and applied, thanks!

I'm sorry that you had to rework this but I put ARC in the end consciously.
As an extension to existing arches. But if alphabetical order is preferred
in Buildroot even for things added later I'll keep this in mind for the future.

And thanks a lot for fixing this minor issue.

-Alexey

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-07-20  7:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-15 13:47 [Buildroot] [PATCH] qt: enable Script and WebKit modules for ARC Alexey Brodkin
2015-07-18 17:20 ` Thomas Petazzoni
2015-07-20  7:58   ` Alexey Brodkin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox