Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Jörg Krause" <joerg.krause@embedded.rocks>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] minidlna: fix static linking
Date: Wed, 12 Aug 2015 08:49:51 +0200	[thread overview]
Message-ID: <1439362191.22945.8.camel@embedded.rocks> (raw)
In-Reply-To: <20150812043257.GA13454@waldemar-brodkorb.de>

Dear Waldemar,

On Mi, 2015-08-12 at 06:32 +0200, Waldemar Brodkorb wrote:
> As libid3tag uses compress, -lz must be linked in, as no pkconfig
> file exist.
> The name of the vorbis pkgconfig file is vorbis.pc.
> We also need to add sqlite in pkgconfig call.
> 
> This fixes following autobuilder compile error:
> http://autobuild.buildroot.net/results/f538ad6673b711492acd727d623d0c
> c2de626f16/
> 
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> ---
>  package/minidlna/minidlna.mk |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/minidlna/minidlna.mk
> b/package/minidlna/minidlna.mk
> index ab93484..385c8df 100644
> --- a/package/minidlna/minidlna.mk
> +++ b/package/minidlna/minidlna.mk
> @@ -17,8 +17,9 @@ MINIDLNA_DEPENDENCIES = \
>  ifeq ($(BR2_STATIC_LIBS),y)
>  # the configure script / Makefile forgets to link with some of the
> dependent
>  # libraries breaking static linking, so help it along
> -MINIDLNA_STATIC_LIBS += `$(PKG_CONFIG_HOST_BINARY) --libs libavcodec
> libexif libvorbis`
> +MINIDLNA_STATIC_LIBS += `$(PKG_CONFIG_HOST_BINARY) --libs libavcodec
> libexif vorbis sqlite3`
>  MINIDLNA_STATIC_LIBS += $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),-lintl)
> +MINIDLNA_STATIC_LIBS += -lz
>  MINIDLNA_CONF_ENV += LIBS="$(MINIDLNA_STATIC_LIBS)"
>  else
>  MINIDLNA_CONF_OPTS = \

This is an almost identical patch to what Bernd Kuhls sent two weeks
ago [1]. Are there any updates for this patch?

Best regards
J?rg Krause

[1] http://patchwork.ozlabs.org/patch/501844/

  reply	other threads:[~2015-08-12  6:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-12  4:32 [Buildroot] [PATCH] minidlna: fix static linking Waldemar Brodkorb
2015-08-12  6:49 ` Jörg Krause [this message]
2015-08-12  7:36   ` Waldemar Brodkorb
2015-08-12  8:16   ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1439362191.22945.8.camel@embedded.rocks \
    --to=joerg.krause@embedded.rocks \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox