[Buildroot] [PATCH] minidlna: fix static linking

[Buildroot] [PATCH] minidlna: fix static linking

[Waldemar Brodkorb]

As libid3tag uses compress, -lz must be linked in, as no pkconfig file exist.
The name of the vorbis pkgconfig file is vorbis.pc.
We also need to add sqlite in pkgconfig call.

This fixes following autobuilder compile error:
http://autobuild.buildroot.net/results/f538ad6673b711492acd727d623d0cc2de626f16/

Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
---
 package/minidlna/minidlna.mk |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/minidlna/minidlna.mk b/package/minidlna/minidlna.mk
index ab93484..385c8df 100644
--- a/package/minidlna/minidlna.mk
+++ b/package/minidlna/minidlna.mk
@@ -17,8 +17,9 @@ MINIDLNA_DEPENDENCIES = \
 ifeq ($(BR2_STATIC_LIBS),y)
 # the configure script / Makefile forgets to link with some of the dependent
 # libraries breaking static linking, so help it along
-MINIDLNA_STATIC_LIBS += `$(PKG_CONFIG_HOST_BINARY) --libs libavcodec libexif libvorbis`
+MINIDLNA_STATIC_LIBS += `$(PKG_CONFIG_HOST_BINARY) --libs libavcodec libexif vorbis sqlite3`
 MINIDLNA_STATIC_LIBS += $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),-lintl)
+MINIDLNA_STATIC_LIBS += -lz
 MINIDLNA_CONF_ENV += LIBS="$(MINIDLNA_STATIC_LIBS)"
 else
 MINIDLNA_CONF_OPTS = \
-- 
1.7.10.4

[Buildroot] [PATCH] minidlna: fix static linking

[Jörg Krause]

Dear Waldemar,

On Mi, 2015-08-12 at 06:32 +0200, Waldemar Brodkorb wrote:
> As libid3tag uses compress, -lz must be linked in, as no pkconfig
> file exist.
> The name of the vorbis pkgconfig file is vorbis.pc.
> We also need to add sqlite in pkgconfig call.
> 
> This fixes following autobuilder compile error:
> http://autobuild.buildroot.net/results/f538ad6673b711492acd727d623d0c
> c2de626f16/
> 
> Signed-off-by: Waldemar Brodkorb <wbx@openadk.org>
> ---
>  package/minidlna/minidlna.mk |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/package/minidlna/minidlna.mk
> b/package/minidlna/minidlna.mk
> index ab93484..385c8df 100644
> --- a/package/minidlna/minidlna.mk
> +++ b/package/minidlna/minidlna.mk
> @@ -17,8 +17,9 @@ MINIDLNA_DEPENDENCIES = \
>  ifeq ($(BR2_STATIC_LIBS),y)
>  # the configure script / Makefile forgets to link with some of the
> dependent
>  # libraries breaking static linking, so help it along
> -MINIDLNA_STATIC_LIBS += `$(PKG_CONFIG_HOST_BINARY) --libs libavcodec
> libexif libvorbis`
> +MINIDLNA_STATIC_LIBS += `$(PKG_CONFIG_HOST_BINARY) --libs libavcodec
> libexif vorbis sqlite3`
>  MINIDLNA_STATIC_LIBS += $(if $(BR2_NEEDS_GETTEXT_IF_LOCALE),-lintl)
> +MINIDLNA_STATIC_LIBS += -lz
>  MINIDLNA_CONF_ENV += LIBS="$(MINIDLNA_STATIC_LIBS)"
>  else
>  MINIDLNA_CONF_OPTS = \

This is an almost identical patch to what Bernd Kuhls sent two weeks
ago [1]. Are there any updates for this patch?

Best regards
J?rg Krause

[1] http://patchwork.ozlabs.org/patch/501844/

[Buildroot] [PATCH] minidlna: fix static linking

[Waldemar Brodkorb]

Hi,
Joerg Krause wrote,

> 
> This is an almost identical patch to what Bernd Kuhls sent two weeks
> ago [1]. Are there any updates for this patch?

Sorry for the noise. I need to take a look @pachwork next time
I try to fix any autobuilder issues :)

best regards
 Waldemar

[Buildroot] [PATCH] minidlna: fix static linking

[Thomas Petazzoni]

Dear J?rg Krause,

On Wed, 12 Aug 2015 08:49:51 +0200, J?rg Krause wrote:

> This is an almost identical patch to what Bernd Kuhls sent two weeks
> ago [1]. Are there any updates for this patch?
> 
> Best regards
> J?rg Krause
> 
> [1] http://patchwork.ozlabs.org/patch/501844/

If you read this link, I said:

"""
Would it be possible to stop hacking this to death? What about instead
taking the saner approach of switching minidlna configure.ac to use
PKG_CHECK_MODULES(), which will remove a lot of crap from it, and make
it work properly for cross-compilation.
"""

and I've got no further comment. So my comment still stands.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com