[Buildroot] [PATCH 1/1] wpa_supplicant: fix static link with readline

[Buildroot] [PATCH 1/1] wpa_supplicant: fix static link with readline

[David du Colombier]

When linking statically, the order of libraries on the
linker command matters, since readline depends on ncurses.

Signed-off-by: David du Colombier <0intro@gmail.com>
---
 package/wpa_supplicant/0005-fix-readline-libs-ordering.patch | 11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 package/wpa_supplicant/0005-fix-readline-libs-ordering.patch

diff --git a/package/wpa_supplicant/0005-fix-readline-libs-ordering.patch b/package/wpa_supplicant/0005-fix-readline-libs-ordering.patch
new file mode 100644
index 0000000..b2439f0
--- /dev/null
+++ b/package/wpa_supplicant/0005-fix-readline-libs-ordering.patch
@@ -0,0 +1,11 @@
+--- ./wpa_supplicant/Makefile
++++ ./wpa_supplicant/Makefile
+@@ -1379,7 +1379,7 @@
+ 
+ ifdef CONFIG_READLINE
+ OBJS_c += ../src/utils/edit_readline.o
+-LIBS_c += -lncurses -lreadline
++LIBS_c += -lreadline -lncurses
+ else
+ ifdef CONFIG_WPA_CLI_EDIT
+ OBJS_c += ../src/utils/edit.o
-- 
1.8.3.1

[Buildroot] [PATCH 1/1] wpa_supplicant: fix static link with readline

[Thomas Petazzoni]

David,

Thanks for this contribution!

On Sun, 13 Sep 2015 23:16:21 +0200, David du Colombier wrote:
> When linking statically, the order of libraries on the
> linker command matters, since readline depends on ncurses.
> 
> Signed-off-by: David du Colombier <0intro@gmail.com>
> ---
>  package/wpa_supplicant/0005-fix-readline-libs-ordering.patch | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>  create mode 100644 package/wpa_supplicant/0005-fix-readline-libs-ordering.patch
> 
> diff --git a/package/wpa_supplicant/0005-fix-readline-libs-ordering.patch b/package/wpa_supplicant/0005-fix-readline-libs-ordering.patch
> new file mode 100644
> index 0000000..b2439f0
> --- /dev/null
> +++ b/package/wpa_supplicant/0005-fix-readline-libs-ordering.patch

Thanks for the patch, but patches in Buildroot have to have a
description and a Signed-off-by line. See
http://buildroot.uclibc.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches.

Also, could you submit this patch to upstream wpa_supplicant?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/1] wpa_supplicant: fix static link with readline

[David du Colombier]

Thomas,

> Thanks for the patch, but patches in Buildroot have to have a
> description and a Signed-off-by line. See
> http://buildroot.uclibc.org/downloads/manual/manual.html#_format_and_licensing_of_the_package_patches.
>
> Also, could you submit this patch to upstream wpa_supplicant?

I've just submitted the fix to the wpa_supplicant mailing list.
I will send a new version of this change, including the patch I sent.

-- 
David du Colombier