Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH RFC v1 1/1] gcc: fix problem with detecting SSP under uclibc-ng
Date: Thu, 17 Sep 2015 22:10:23 +0000	[thread overview]
Message-ID: <1442527823.17912.40.camel@synopsys.com> (raw)
In-Reply-To: <CA+BsyQ7RqCVPi6h9VUJpdQ49pVZwLnCGzRtL+wN1JUhs+T7_WA@mail.gmail.com>

Hi Brendan,

On Thu, 2015-09-17 at 18:29 +0100, Brendan Heading wrote:
The problem is seen with uclibc-ng 1.0.6 (and likely greater) where they
> > > updated the __GLIBC_MINOR__ value to 10. It will be seen in any libc
> > > that permits stack protection to be disabled while exporting a glibc
> > > version >= 2.4.
> > 
> > Cc'ing Waldemar here. It's an interesting consequence of bumping the
> > GLIBC_MINOR version exposed by uClibc, which happened recently to solve
> > an eventfd_read() problem in Boost on ARC, investigated by Alexey (also
> > in Cc).
> 
> Yup, that's exactly what has exposed the problem. And the "problem" is
> really a deficiency in the way GCC detects SSP support in the libc.

Well I expected new issues to show up after that change but I'm surprised
it's the first one reported - so IMHO we're dealing quite well.

As for the nature of that new problem I'd say it's also expected.
Because I see people use glibc version to determine which feature
or set of features could be used. And IMHO that's not very correct
especially compared to checking each particular feature via compilation.

And frankly I was not very happy with that blind bump of GLIBC_MINOR
from one magical version (I was not able to find any justification why
it was the value it was) to another not justified also... just in attempt
to pretend we're now covering more things in uClibc. But it was low
hanging fruit and so we decided to go that way instead of fixing
affected projects... which in its turn could be not that easy as
patch submission in either uClibc or Buildroot :)

> __stack_chk symbols. Would be interested in hearing from Alexey and
> Waldemar

I think I'll vote for GCC patch as well. So there will be a check for
__UCLIBC_HAS_SSP__ regardless that GLIBC_MINOR value.

-Alexey

      parent reply	other threads:[~2015-09-17 22:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-17 14:37 [Buildroot] [PATCH RFC v1 1/1] gcc: fix problem with detecting SSP under uclibc-ng Brendan Heading
2015-09-17 17:14 ` Thomas Petazzoni
2015-09-17 17:29   ` Brendan Heading
2015-09-17 17:42     ` Waldemar Brodkorb
2015-09-17 20:20     ` Thomas Petazzoni
2015-09-17 21:22       ` Brendan Heading
2015-09-18  7:11         ` Thomas Petazzoni
2015-09-17 22:10     ` Alexey Brodkin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442527823.17912.40.camel@synopsys.com \
    --to=alexey.brodkin@synopsys.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox