[Buildroot] [PATCH RFC v1 1/1] gcc: fix problem with detecting SSP under uclibc-ng

[Thomas Petazzoni <thomas.petazzoni@free-electrons.com>]

Brendan,

On Thu, 17 Sep 2015 22:22:52 +0100, Brendan Heading wrote:

> > We are fine with patches being order-dependent. That's fine we have a
> > sequence number for all patches in the first place.
> >
> > So far, the effort to push upstream our gcc patches has been very
> > limited. It would be good to push some of them upstream, but in the
> > mean time, our stack of gcc patches is not that big, and is not causing
> > too many problems when bumping gcc.
> 
> Yeah I also get the sense that getting patches upstream in GCC might
> be difficult, and when I was googling this I saw other examples of
> people running into problems similar to this. I would guess it's
> especially unlikely we would get patches into the versions that are in
> maintenance mode. We might have more luck with next (ie GCC 6.0).

It is indeed not necessarily easy to get patches upstream, but when it
is the proper fix, it is nonetheless what we should do.

> >> Aside from that .. GCC actually already has a block which checks
> >> UCLIBC_HAS_SSP. The problem is that it reaches it only if the glibc
> >> version check returns that the version is 2.3 or lower. The fix might
> >> simply be to reorder the check.
> >
> > If it's that simple, then it should be done :) In any case, version
> > based tests are often not a good idea, so when uClibc is used, gcc
> > should really rely on UCLIBC_HAS_SSP.
> 
> Okay, I am now looking at putting together an interim patch set. I
> don't think there is any point in trying to submit them into
> maintenance releases of the existing versions but it's worth taking a
> shot at getting them into -next.

Great, thanks!

In fact, maybe uClibc-ng should have some sort of side project to
collect the gcc patches needed to build a uClibc based toolchain, a bit
like musl is doing at
https://bitbucket.org/GregorR/musl-gcc-patches/src.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com