Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v10 1/1] squeezelite: new package
@ 2015-09-22 10:38 kei-k at ca2.so-net.ne.jp
  2015-09-22 10:39 ` 川島 浩
  2015-09-22 12:08 ` Jörg Krause
  0 siblings, 2 replies; 7+ messages in thread
From: kei-k at ca2.so-net.ne.jp @ 2015-09-22 10:38 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Hiroshi Kawashima <kei-k@ca2.so-net.ne.jp>
---
 package/Config.in                  |    1 +
 package/squeezelite/Config.in      |   27 +++++++++++++++++++++++++++
 package/squeezelite/squeezelite.mk |   27 +++++++++++++++++++++++++++
 3 files changed, 55 insertions(+), 0 deletions(-)
 create mode 100644 package/squeezelite/Config.in
 create mode 100644 package/squeezelite/squeezelite.mk

diff --git a/package/Config.in b/package/Config.in
index 5158371..2a47420 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -33,6 +33,7 @@ menu "Audio and video applications"
 	source "package/opus-tools/Config.in"
 	source "package/pulseaudio/Config.in"
 	source "package/sox/Config.in"
+	source "package/squeezelite/Config.in"
 	source "package/tidsp-binaries/Config.in"
 	source "package/tovid/Config.in"
 	source "package/tstools/Config.in"
diff --git a/package/squeezelite/Config.in b/package/squeezelite/Config.in
new file mode 100644
index 0000000..119ade1
--- /dev/null
+++ b/package/squeezelite/Config.in
@@ -0,0 +1,27 @@
+config BR2_PACKAGE_SQUEEZELITE
+	bool "squeezelite"
+	depends on BR2_USE_WCHAR # flac
+	depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib
+	depends on BR2_USE_MMU # mpg123
+	select BR2_PACKAGE_ALSA_LIB
+	select BR2_PACKAGE_FLAC
+	select BR2_PACKAGE_LIBMAD
+	select BR2_PACKAGE_LIBVORBIS
+	select BR2_PACKAGE_FAAD2
+	select BR2_PACKAGE_MPG123
+	help
+	  Logitech Media Server client
+
+	  https://code.google.com/p/squeezelite/
+if BR2_PACKAGE_SQUEEZELITE
+config BR2_PACKAGE_SQUEEZELITE_RESAMPLE
+	bool "Enable resampling function"
+	select BR2_PACKAGE_LIBSOXR
+	depends on BR2_PACKAGE_SQUEEZELITE
+	help
+	  Enable resampling function
+endif
+
+comment "squeezelite needs a toolchain w/ wchar, threads"
+	depends on BR2_USE_MMU
+	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
diff --git a/package/squeezelite/squeezelite.mk b/package/squeezelite/squeezelite.mk
new file mode 100644
index 0000000..4defa31
--- /dev/null
+++ b/package/squeezelite/squeezelite.mk
@@ -0,0 +1,27 @@
+################################################################################
+#
+# squeezelite
+#
+################################################################################
+
+SQUEEZELITE_VERSION = v1.8
+SQUEEZELITE_SITE = https://code.google.com/p/squeezelite
+SQUEEZELITE_SITE_METHOD = git
+SQUEEZELITE_LICENSE = GPLv3
+SQUEEZELITE_LICENSE_FILE = LICENSE.txt
+SQUEEZELITE_DEPENDENCIES = alsa-lib flac libmad libvorbis faad2 mpg123 libsoxr
+
+ifeq ($(BR2_PACKAGE_SQUEEZELITE_RESAMPLE),y)
+SQUEEZELITE_MAKE_OPTS += -DRESAMPLE -DRESAMPLE_MP
+endif
+
+define SQUEEZELITE_BUILD_CMDS
+    $(TARGET_MAKE_ENV) $(MAKE) OPTS="$(SQUEEZELITE_MAKE_OPTS)" \
+		CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D) all
+endef
+
+define SQUEEZELITE_INSTALL_TARGET_CMDS
+	$(INSTALL) -D -m 0755 $(@D)/squeezelite $(TARGET_DIR)/usr/bin
+endef
+
+$(eval $(generic-package))
-- 
1.7.1

============================================================
    Hiroshi Kawashima

^ permalink raw reply related	[flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v10 1/1] squeezelite: new package
  2015-09-22 10:38 [Buildroot] [PATCH v10 1/1] squeezelite: new package kei-k at ca2.so-net.ne.jp
@ 2015-09-22 10:39 ` 川島 浩
  2015-09-22 12:08 ` Jörg Krause
  1 sibling, 0 replies; 7+ messages in thread
From: 川島 浩 @ 2015-09-22 10:39 UTC (permalink / raw)
  To: buildroot

You like this ?

> 2015/09/22 19:38?kei-k at ca2.so-net.ne.jp ?????
> 
> Signed-off-by: Hiroshi Kawashima <kei-k@ca2.so-net.ne.jp>
> ---
> package/Config.in                  |    1 +
> package/squeezelite/Config.in      |   27 +++++++++++++++++++++++++++
> package/squeezelite/squeezelite.mk |   27 +++++++++++++++++++++++++++
> 3 files changed, 55 insertions(+), 0 deletions(-)
> create mode 100644 package/squeezelite/Config.in
> create mode 100644 package/squeezelite/squeezelite.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index 5158371..2a47420 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -33,6 +33,7 @@ menu "Audio and video applications"
> 	source "package/opus-tools/Config.in"
> 	source "package/pulseaudio/Config.in"
> 	source "package/sox/Config.in"
> +	source "package/squeezelite/Config.in"
> 	source "package/tidsp-binaries/Config.in"
> 	source "package/tovid/Config.in"
> 	source "package/tstools/Config.in"
> diff --git a/package/squeezelite/Config.in b/package/squeezelite/Config.in
> new file mode 100644
> index 0000000..119ade1
> --- /dev/null
> +++ b/package/squeezelite/Config.in
> @@ -0,0 +1,27 @@
> +config BR2_PACKAGE_SQUEEZELITE
> +	bool "squeezelite"
> +	depends on BR2_USE_WCHAR # flac
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib
> +	depends on BR2_USE_MMU # mpg123
> +	select BR2_PACKAGE_ALSA_LIB
> +	select BR2_PACKAGE_FLAC
> +	select BR2_PACKAGE_LIBMAD
> +	select BR2_PACKAGE_LIBVORBIS
> +	select BR2_PACKAGE_FAAD2
> +	select BR2_PACKAGE_MPG123
> +	help
> +	  Logitech Media Server client
> +
> +	  https://code.google.com/p/squeezelite/
> +if BR2_PACKAGE_SQUEEZELITE
> +config BR2_PACKAGE_SQUEEZELITE_RESAMPLE
> +	bool "Enable resampling function"
> +	select BR2_PACKAGE_LIBSOXR
> +	depends on BR2_PACKAGE_SQUEEZELITE
> +	help
> +	  Enable resampling function
> +endif
> +
> +comment "squeezelite needs a toolchain w/ wchar, threads"
> +	depends on BR2_USE_MMU
> +	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
> diff --git a/package/squeezelite/squeezelite.mk b/package/squeezelite/squeezelite.mk
> new file mode 100644
> index 0000000..4defa31
> --- /dev/null
> +++ b/package/squeezelite/squeezelite.mk
> @@ -0,0 +1,27 @@
> +################################################################################
> +#
> +# squeezelite
> +#
> +################################################################################
> +
> +SQUEEZELITE_VERSION = v1.8
> +SQUEEZELITE_SITE = https://code.google.com/p/squeezelite
> +SQUEEZELITE_SITE_METHOD = git
> +SQUEEZELITE_LICENSE = GPLv3
> +SQUEEZELITE_LICENSE_FILE = LICENSE.txt
> +SQUEEZELITE_DEPENDENCIES = alsa-lib flac libmad libvorbis faad2 mpg123 libsoxr
> +
> +ifeq ($(BR2_PACKAGE_SQUEEZELITE_RESAMPLE),y)
> +SQUEEZELITE_MAKE_OPTS += -DRESAMPLE -DRESAMPLE_MP
> +endif
> +
> +define SQUEEZELITE_BUILD_CMDS
> +    $(TARGET_MAKE_ENV) $(MAKE) OPTS="$(SQUEEZELITE_MAKE_OPTS)" \
> +		CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D) all
> +endef
> +
> +define SQUEEZELITE_INSTALL_TARGET_CMDS
> +	$(INSTALL) -D -m 0755 $(@D)/squeezelite $(TARGET_DIR)/usr/bin
> +endef
> +
> +$(eval $(generic-package))
> -- 
> 1.7.1
> 
> ============================================================
>    Hiroshi Kawashima

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v10 1/1] squeezelite: new package
  2015-09-22 10:38 [Buildroot] [PATCH v10 1/1] squeezelite: new package kei-k at ca2.so-net.ne.jp
  2015-09-22 10:39 ` 川島 浩
@ 2015-09-22 12:08 ` Jörg Krause
  2015-09-22 12:46   ` kei
  1 sibling, 1 reply; 7+ messages in thread
From: Jörg Krause @ 2015-09-22 12:08 UTC (permalink / raw)
  To: buildroot

Dear Hiroshi Kawashima,

please see my comment below...

On Di, 2015-09-22 at 19:38 +0900, kei-k at ca2.so-net.ne.jp wrote:
> Signed-off-by: Hiroshi Kawashima <kei-k@ca2.so-net.ne.jp>
> ---
>  package/Config.in                  |    1 +
>  package/squeezelite/Config.in      |   27
> +++++++++++++++++++++++++++
>  package/squeezelite/squeezelite.mk |   27
> +++++++++++++++++++++++++++
>  3 files changed, 55 insertions(+), 0 deletions(-)
>  create mode 100644 package/squeezelite/Config.in
>  create mode 100644 package/squeezelite/squeezelite.mk
> 
> diff --git a/package/Config.in b/package/Config.in
> index 5158371..2a47420 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -33,6 +33,7 @@ menu "Audio and video applications"
>  	source "package/opus-tools/Config.in"
>  	source "package/pulseaudio/Config.in"
>  	source "package/sox/Config.in"
> +	source "package/squeezelite/Config.in"
>  	source "package/tidsp-binaries/Config.in"
>  	source "package/tovid/Config.in"
>  	source "package/tstools/Config.in"
> diff --git a/package/squeezelite/Config.in
> b/package/squeezelite/Config.in
> new file mode 100644
> index 0000000..119ade1
> --- /dev/null
> +++ b/package/squeezelite/Config.in
> @@ -0,0 +1,27 @@
> +config BR2_PACKAGE_SQUEEZELITE
> +	bool "squeezelite"
> +	depends on BR2_USE_WCHAR # flac
> +	depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib
> +	depends on BR2_USE_MMU # mpg123
> +	select BR2_PACKAGE_ALSA_LIB
> +	select BR2_PACKAGE_FLAC
> +	select BR2_PACKAGE_LIBMAD
> +	select BR2_PACKAGE_LIBVORBIS
> +	select BR2_PACKAGE_FAAD2
> +	select BR2_PACKAGE_MPG123
> +	help
> +	  Logitech Media Server client
> +
> +	  https://code.google.com/p/squeezelite/
> +if BR2_PACKAGE_SQUEEZELITE
> +config BR2_PACKAGE_SQUEEZELITE_RESAMPLE
> +	bool "Enable resampling function"
> +	select BR2_PACKAGE_LIBSOXR
> +	depends on BR2_PACKAGE_SQUEEZELITE
> +	help
> +	  Enable resampling function
> +endif

Please add some newlines here and remove "depends on
BR2_PACKAGE_SQUEEZELITE":

[...]
	select BR2_PACKAGE_MPG123
	help
	  Logitech Media Server client

	  https://code.google.com/p/squeezelite/>

if BR2_PACKAGE_SQUEEZELITE

config BR2_PACKAGE_SQUEEZELITE_RESAMPLE
	bool "Enable resampling function"
	select BR2_PACKAGE_LIBSOXR
	help
	  Enable resampling function

endif

comment "squeezelite needs a toolchain w/ wchar, threads"
[...]

> +comment "squeezelite needs a toolchain w/ wchar, threads"
> +	depends on BR2_USE_MMU
> +	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
> diff --git a/package/squeezelite/squeezelite.mk
> b/package/squeezelite/squeezelite.mk
> new file mode 100644
> index 0000000..4defa31
> --- /dev/null
> +++ b/package/squeezelite/squeezelite.mk
> @@ -0,0 +1,27 @@
> +####################################################################
> ############
> +#
> +# squeezelite
> +#
> +####################################################################
> ############
> +
> +SQUEEZELITE_VERSION = v1.8
> +SQUEEZELITE_SITE = https://code.google.com/p/squeezelite
> +SQUEEZELITE_SITE_METHOD = git
> +SQUEEZELITE_LICENSE = GPLv3
> +SQUEEZELITE_LICENSE_FILE = LICENSE.txt
> +SQUEEZELITE_DEPENDENCIES = alsa-lib flac libmad libvorbis faad2
> mpg123 libsoxr

Remove libsoxr here. It's added conditionally below.

> +ifeq ($(BR2_PACKAGE_SQUEEZELITE_RESAMPLE),y)
> +SQUEEZELITE_MAKE_OPTS += -DRESAMPLE -DRESAMPLE_MP
> +endif

Add SQUEEZELITE_DEPENDENCIES += libsoxr and remove -DRESAMPLE_MP here:

ifeq ($(BR2_PACKAGE_SQUEEZELITE_RESAMPLE),y)
SQUEEZELITE_DEPENDENCIES += libsoxr
SQUEEZELITE_MAKE_OPTS += -DRESAMPLE
endif

> +define SQUEEZELITE_BUILD_CMDS
> +    $(TARGET_MAKE_ENV) $(MAKE) OPTS="$(SQUEEZELITE_MAKE_OPTS)" \
> +		CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D) all
> +endef

Did you tried Thomas comment here:
"Have you tried using $(TARGET_CONFIGURE_OPTS) instead of manually
passing CC and LD ?"

> +define SQUEEZELITE_INSTALL_TARGET_CMDS
> +	$(INSTALL) -D -m 0755 $(@D)/squeezelite
> $(TARGET_DIR)/usr/bin
> +endef
> +
> +$(eval $(generic-package))

Best regards
J?rg Krause

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v10 1/1] squeezelite: new package
  2015-09-22 12:08 ` Jörg Krause
@ 2015-09-22 12:46   ` kei
  2015-09-22 12:59     ` kei
  0 siblings, 1 reply; 7+ messages in thread
From: kei @ 2015-09-22 12:46 UTC (permalink / raw)
  To: buildroot

Dear Jorg.

On 2015/09/22, at 21:08, J?rg Krause <joerg.krause@embedded.rocks> wrote:

> Dear Hiroshi Kawashima,
> 
> please see my comment below...
> 
> On Di, 2015-09-22 at 19:38 +0900, kei-k at ca2.so-net.ne.jp wrote:
>> Signed-off-by: Hiroshi Kawashima <kei-k@ca2.so-net.ne.jp>
>> ---
>> package/Config.in                  |    1 +
>> package/squeezelite/Config.in      |   27
>> +++++++++++++++++++++++++++
>> package/squeezelite/squeezelite.mk |   27
>> +++++++++++++++++++++++++++
>> 3 files changed, 55 insertions(+), 0 deletions(-)
>> create mode 100644 package/squeezelite/Config.in
>> create mode 100644 package/squeezelite/squeezelite.mk
>> 
>> diff --git a/package/Config.in b/package/Config.in
>> index 5158371..2a47420 100644
>> --- a/package/Config.in
>> +++ b/package/Config.in
>> @@ -33,6 +33,7 @@ menu "Audio and video applications"
>> 	source "package/opus-tools/Config.in"
>> 	source "package/pulseaudio/Config.in"
>> 	source "package/sox/Config.in"
>> +	source "package/squeezelite/Config.in"
>> 	source "package/tidsp-binaries/Config.in"
>> 	source "package/tovid/Config.in"
>> 	source "package/tstools/Config.in"
>> diff --git a/package/squeezelite/Config.in
>> b/package/squeezelite/Config.in
>> new file mode 100644
>> index 0000000..119ade1
>> --- /dev/null
>> +++ b/package/squeezelite/Config.in
>> @@ -0,0 +1,27 @@
>> +config BR2_PACKAGE_SQUEEZELITE
>> +	bool "squeezelite"
>> +	depends on BR2_USE_WCHAR # flac
>> +	depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib
>> +	depends on BR2_USE_MMU # mpg123
>> +	select BR2_PACKAGE_ALSA_LIB
>> +	select BR2_PACKAGE_FLAC
>> +	select BR2_PACKAGE_LIBMAD
>> +	select BR2_PACKAGE_LIBVORBIS
>> +	select BR2_PACKAGE_FAAD2
>> +	select BR2_PACKAGE_MPG123
>> +	help
>> +	  Logitech Media Server client
>> +
>> +	  https://code.google.com/p/squeezelite/
>> +if BR2_PACKAGE_SQUEEZELITE
>> +config BR2_PACKAGE_SQUEEZELITE_RESAMPLE
>> +	bool "Enable resampling function"
>> +	select BR2_PACKAGE_LIBSOXR
>> +	depends on BR2_PACKAGE_SQUEEZELITE
>> +	help
>> +	  Enable resampling function
>> +endif
> 
> Please add some newlines here and remove "depends on
> BR2_PACKAGE_SQUEEZELITE":
> 
> [...]
> 	select BR2_PACKAGE_MPG123
> 	help
> 	  Logitech Media Server client
> 
> 	  https://code.google.com/p/squeezelite/>
> 
> if BR2_PACKAGE_SQUEEZELITE
> 
> config BR2_PACKAGE_SQUEEZELITE_RESAMPLE
> 	bool "Enable resampling function"
> 	select BR2_PACKAGE_LIBSOXR
> 	help
> 	  Enable resampling function
> 
> endif
> 
> comment "squeezelite needs a toolchain w/ wchar, threads"
> [?]
> 
OK

>> +comment "squeezelite needs a toolchain w/ wchar, threads"
>> +	depends on BR2_USE_MMU
>> +	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
>> diff --git a/package/squeezelite/squeezelite.mk
>> b/package/squeezelite/squeezelite.mk
>> new file mode 100644
>> index 0000000..4defa31
>> --- /dev/null
>> +++ b/package/squeezelite/squeezelite.mk
>> @@ -0,0 +1,27 @@
>> +####################################################################
>> ############
>> +#
>> +# squeezelite
>> +#
>> +####################################################################
>> ############
>> +
>> +SQUEEZELITE_VERSION = v1.8
>> +SQUEEZELITE_SITE = https://code.google.com/p/squeezelite
>> +SQUEEZELITE_SITE_METHOD = git
>> +SQUEEZELITE_LICENSE = GPLv3
>> +SQUEEZELITE_LICENSE_FILE = LICENSE.txt
>> +SQUEEZELITE_DEPENDENCIES = alsa-lib flac libmad libvorbis faad2
>> mpg123 libsoxr
> 
> Remove libsoxr here. It's added conditionally below.
> 
OK

>> +ifeq ($(BR2_PACKAGE_SQUEEZELITE_RESAMPLE),y)
>> +SQUEEZELITE_MAKE_OPTS += -DRESAMPLE -DRESAMPLE_MP
>> +endif
> 
> Add SQUEEZELITE_DEPENDENCIES += libsoxr and remove -DRESAMPLE_MP here:
> 
> ifeq ($(BR2_PACKAGE_SQUEEZELITE_RESAMPLE),y)
> SQUEEZELITE_DEPENDENCIES += libsoxr
> SQUEEZELITE_MAKE_OPTS += -DRESAMPLE
> endif
> 
OK

>> +define SQUEEZELITE_BUILD_CMDS
>> +    $(TARGET_MAKE_ENV) $(MAKE) OPTS="$(SQUEEZELITE_MAKE_OPTS)" \
>> +		CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D) all
>> +endef
> 
> Did you tried Thomas comment here:
> "Have you tried using $(TARGET_CONFIGURE_OPTS) instead of manually
> passing CC and LD ?"
> 
Yes, I tried, but make fails.
So I back to it.


>> +define SQUEEZELITE_INSTALL_TARGET_CMDS
>> +	$(INSTALL) -D -m 0755 $(@D)/squeezelite
>> $(TARGET_DIR)/usr/bin
>> +endef
>> +
>> +$(eval $(generic-package))
> 
> Best regards
> J?rg Krause

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v10 1/1] squeezelite: new package
  2015-09-22 12:46   ` kei
@ 2015-09-22 12:59     ` kei
  2015-09-22 13:19       ` Jörg Krause
  0 siblings, 1 reply; 7+ messages in thread
From: kei @ 2015-09-22 12:59 UTC (permalink / raw)
  To: buildroot


On 2015/09/22, at 21:46, kei <kei-k@ca2.so-net.ne.jp> wrote:

> Dear Jorg.
> 
> On 2015/09/22, at 21:08, J?rg Krause <joerg.krause@embedded.rocks> wrote:
> 
>> Dear Hiroshi Kawashima,
>> 
>> please see my comment below...
>> 
>> On Di, 2015-09-22 at 19:38 +0900, kei-k at ca2.so-net.ne.jp wrote:
>>> Signed-off-by: Hiroshi Kawashima <kei-k@ca2.so-net.ne.jp>
>>> ---
>>> package/Config.in                  |    1 +
>>> package/squeezelite/Config.in      |   27
>>> +++++++++++++++++++++++++++
>>> package/squeezelite/squeezelite.mk |   27
>>> +++++++++++++++++++++++++++
>>> 3 files changed, 55 insertions(+), 0 deletions(-)
>>> create mode 100644 package/squeezelite/Config.in
>>> create mode 100644 package/squeezelite/squeezelite.mk
>>> 
>>> diff --git a/package/Config.in b/package/Config.in
>>> index 5158371..2a47420 100644
>>> --- a/package/Config.in
>>> +++ b/package/Config.in
>>> @@ -33,6 +33,7 @@ menu "Audio and video applications"
>>> 	source "package/opus-tools/Config.in"
>>> 	source "package/pulseaudio/Config.in"
>>> 	source "package/sox/Config.in"
>>> +	source "package/squeezelite/Config.in"
>>> 	source "package/tidsp-binaries/Config.in"
>>> 	source "package/tovid/Config.in"
>>> 	source "package/tstools/Config.in"
>>> diff --git a/package/squeezelite/Config.in
>>> b/package/squeezelite/Config.in
>>> new file mode 100644
>>> index 0000000..119ade1
>>> --- /dev/null
>>> +++ b/package/squeezelite/Config.in
>>> @@ -0,0 +1,27 @@
>>> +config BR2_PACKAGE_SQUEEZELITE
>>> +	bool "squeezelite"
>>> +	depends on BR2_USE_WCHAR # flac
>>> +	depends on BR2_TOOLCHAIN_HAS_THREADS # alsa-lib
>>> +	depends on BR2_USE_MMU # mpg123
>>> +	select BR2_PACKAGE_ALSA_LIB
>>> +	select BR2_PACKAGE_FLAC
>>> +	select BR2_PACKAGE_LIBMAD
>>> +	select BR2_PACKAGE_LIBVORBIS
>>> +	select BR2_PACKAGE_FAAD2
>>> +	select BR2_PACKAGE_MPG123
>>> +	help
>>> +	  Logitech Media Server client
>>> +
>>> +	  https://code.google.com/p/squeezelite/
>>> +if BR2_PACKAGE_SQUEEZELITE
>>> +config BR2_PACKAGE_SQUEEZELITE_RESAMPLE
>>> +	bool "Enable resampling function"
>>> +	select BR2_PACKAGE_LIBSOXR
>>> +	depends on BR2_PACKAGE_SQUEEZELITE
>>> +	help
>>> +	  Enable resampling function
>>> +endif
>> 
>> Please add some newlines here and remove "depends on
>> BR2_PACKAGE_SQUEEZELITE":
>> 
>> [...]
>> 	select BR2_PACKAGE_MPG123
>> 	help
>> 	  Logitech Media Server client
>> 
>> 	  https://code.google.com/p/squeezelite/>
>> 
>> if BR2_PACKAGE_SQUEEZELITE
>> 
>> config BR2_PACKAGE_SQUEEZELITE_RESAMPLE
>> 	bool "Enable resampling function"
>> 	select BR2_PACKAGE_LIBSOXR
>> 	help
>> 	  Enable resampling function
>> 
>> endif
>> 
>> comment "squeezelite needs a toolchain w/ wchar, threads"
>> [?]
>> 
> OK
> 
>>> +comment "squeezelite needs a toolchain w/ wchar, threads"
>>> +	depends on BR2_USE_MMU
>>> +	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
>>> diff --git a/package/squeezelite/squeezelite.mk
>>> b/package/squeezelite/squeezelite.mk
>>> new file mode 100644
>>> index 0000000..4defa31
>>> --- /dev/null
>>> +++ b/package/squeezelite/squeezelite.mk
>>> @@ -0,0 +1,27 @@
>>> +####################################################################
>>> ############
>>> +#
>>> +# squeezelite
>>> +#
>>> +####################################################################
>>> ############
>>> +
>>> +SQUEEZELITE_VERSION = v1.8
>>> +SQUEEZELITE_SITE = https://code.google.com/p/squeezelite
>>> +SQUEEZELITE_SITE_METHOD = git
>>> +SQUEEZELITE_LICENSE = GPLv3
>>> +SQUEEZELITE_LICENSE_FILE = LICENSE.txt
>>> +SQUEEZELITE_DEPENDENCIES = alsa-lib flac libmad libvorbis faad2
>>> mpg123 libsoxr
>> 
>> Remove libsoxr here. It's added conditionally below.
>> 
> OK
> 
>>> +ifeq ($(BR2_PACKAGE_SQUEEZELITE_RESAMPLE),y)
>>> +SQUEEZELITE_MAKE_OPTS += -DRESAMPLE -DRESAMPLE_MP
>>> +endif
>> 
>> Add SQUEEZELITE_DEPENDENCIES += libsoxr and remove -DRESAMPLE_MP here:
>> 
>> ifeq ($(BR2_PACKAGE_SQUEEZELITE_RESAMPLE),y)
>> SQUEEZELITE_DEPENDENCIES += libsoxr
>> SQUEEZELITE_MAKE_OPTS += -DRESAMPLE
>> endif
>> 
> OK
Ah, NO.
-DRESAMPLE_MP is ok here as I explained.
You can not agree ?


> 
>>> +define SQUEEZELITE_BUILD_CMDS
>>> +    $(TARGET_MAKE_ENV) $(MAKE) OPTS="$(SQUEEZELITE_MAKE_OPTS)" \
>>> +		CC="$(TARGET_CC)" LD="$(TARGET_LD)" -C $(@D) all
>>> +endef
>> 
>> Did you tried Thomas comment here:
>> "Have you tried using $(TARGET_CONFIGURE_OPTS) instead of manually
>> passing CC and LD ?"
>> 
> Yes, I tried, but make fails.
> So I back to it.
> 
> 
>>> +define SQUEEZELITE_INSTALL_TARGET_CMDS
>>> +	$(INSTALL) -D -m 0755 $(@D)/squeezelite
>>> $(TARGET_DIR)/usr/bin
>>> +endef
>>> +
>>> +$(eval $(generic-package))
>> 
>> Best regards
>> J?rg Krause
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v10 1/1] squeezelite: new package
  2015-09-22 12:59     ` kei
@ 2015-09-22 13:19       ` Jörg Krause
  2015-09-23  1:50         ` 川島 浩
  0 siblings, 1 reply; 7+ messages in thread
From: Jörg Krause @ 2015-09-22 13:19 UTC (permalink / raw)
  To: buildroot

Dear Hiroshi,

On Di, 2015-09-22 at 21:59 +0900, kei wrote:
> On 2015/09/22, at 21:46, kei <kei-k@ca2.so-net.ne.jp> wrote:
> 
> > Dear Jorg.
> > 

[snip]

> > OK
> Ah, NO.
> -DRESAMPLE_MP is ok here as I explained.
> You can not agree ?
> 

Sorry, I did not receive an explanation.

Best regards
J?rg Krause

^ permalink raw reply	[flat|nested] 7+ messages in thread
* [Buildroot] [PATCH v10 1/1] squeezelite: new package
  2015-09-22 13:19       ` Jörg Krause
@ 2015-09-23  1:50         ` 川島 浩
  0 siblings, 0 replies; 7+ messages in thread
From: 川島 浩 @ 2015-09-23  1:50 UTC (permalink / raw)
  To: buildroot

Sometime your address results delivery error like this?

The original message was received at Tue, 22 Sep 2015 21:46:02 +0900
from ms-omx12.plus.so-net.ne.jp [10.240.84.162]

  ----- The following addresses had permanent fatal errors -----
<joerg.krause@embedded.rocks>
   (reason: 550 5.7.1 Service unavailable; client [202.238.84.152] blocked using dnsbl.inps.de)

  ----- Transcript of session follows -----
... while talking to embedded.rocks.:
>>> RCPT To:<joerg.krause@embedded.rocks>
<<< 550 5.7.1 Service unavailable; client [202.238.84.152] blocked using dnsbl.inps.de
550 5.1.1 <joerg.krause@embedded.rocks>... User unknown
>>> DATA
<<< 554 5.5.1 Error: no valid recipients
Reporting-MTA: dns; ms-omx02.plus.so-net.ne.jp
Received-From-MTA: DNS; ms-omx12.plus.so-net.ne.jp
Arrival-Date: Tue, 22 Sep 2015 21:46:02 +0900

> 2015/09/22 22:19?J?rg Krause <joerg.krause@embedded.rocks> ?????
> 
> Dear Hiroshi,
> 
> On Di, 2015-09-22 at 21:59 +0900, kei wrote:
>> On 2015/09/22, at 21:46, kei <kei-k@ca2.so-net.ne.jp> wrote:
>> 
>>> Dear Jorg.
>>> 
> 
> [snip]
> 
>>> OK
>> Ah, NO.
>> -DRESAMPLE_MP is ok here as I explained.
>> You can not agree ?
>> 
> 
> Sorry, I did not receive an explanation.
> 
> Best regards
> J?rg Krause

^ permalink raw reply	[flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-09-23  1:50 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-22 10:38 [Buildroot] [PATCH v10 1/1] squeezelite: new package kei-k at ca2.so-net.ne.jp
2015-09-22 10:39 ` 川島 浩
2015-09-22 12:08 ` Jörg Krause
2015-09-22 12:46   ` kei
2015-09-22 12:59     ` kei
2015-09-22 13:19       ` Jörg Krause
2015-09-23  1:50         ` 川島 浩

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox