[Buildroot] [PATCH] package/rng-tools: systemd: support extra options

[Buildroot] [PATCH] package/rng-tools: systemd: support extra options

[Benoît Thébaudeau]

Add a DAEMON_ARGS configuration variable in order to make it possible to
pass custom extra options to rngd. This environment variable must
defined in /etc/default/rngd if needed, like with the SysV init script.
This file does not have to be present if not needed.

Signed-off-by: Beno?t Th?baudeau <benoit.thebaudeau.dev@gmail.com>
---
 package/rng-tools/rngd.service | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/package/rng-tools/rngd.service b/package/rng-tools/rngd.service
index 3bdc4c1..c0bcffe 100644
--- a/package/rng-tools/rngd.service
+++ b/package/rng-tools/rngd.service
@@ -2,8 +2,9 @@
 Description=Hardware RNG Entropy Gatherer Daemon
 
 [Service]
-ExecStart=/usr/sbin/rngd -f
+ExecStart=/usr/sbin/rngd -f $DAEMON_ARGS
 SuccessExitStatus=66
+EnvironmentFile=-/etc/default/rngd
 
 [Install]
 WantedBy=multi-user.target
-- 
2.1.4

[Buildroot] [PATCH] package/rng-tools: systemd: support extra options

[Maxime Hadjinlian]

Hi Benoit, all

On Wed, Oct 21, 2015 at 12:43 AM, Beno?t Th?baudeau <
benoit.thebaudeau.dev@gmail.com> wrote:

> Add a DAEMON_ARGS configuration variable in order to make it possible to
> pass custom extra options to rngd. This environment variable must
> defined in /etc/default/rngd if needed, like with the SysV init script.
> This file does not have to be present if not needed.
>
> Signed-off-by: Beno?t Th?baudeau <benoit.thebaudeau.dev@gmail.com>
> ---
>  package/rng-tools/rngd.service | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/package/rng-tools/rngd.service
> b/package/rng-tools/rngd.service
> index 3bdc4c1..c0bcffe 100644
> --- a/package/rng-tools/rngd.service
> +++ b/package/rng-tools/rngd.service
> @@ -2,8 +2,9 @@
>  Description=Hardware RNG Entropy Gatherer Daemon
>
>  [Service]
> -ExecStart=/usr/sbin/rngd -f
> +ExecStart=/usr/sbin/rngd -f $DAEMON_ARGS
>  SuccessExitStatus=66
> +EnvironmentFile=-/etc/default/rngd
>
>  [Install]
>  WantedBy=multi-user.target
>
Everything's fine by me on this patch, just a quick question, would it be
nice to have a default file with an empty DAEMON_ARGS ? Maybe that would be
easier for users to understand ? Since it's used by both init system.

Other than that
Reviewed-by "Maxime Hadjinlian <maxime.hadjinlian@gmail.com>"

--
> 2.1.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20151104/816eec58/attachment.html>

[Buildroot] [PATCH] package/rng-tools: systemd: support extra options

[Thomas Petazzoni]

Dear Beno?t Th?baudeau,

On Wed, 21 Oct 2015 00:43:28 +0200, Beno?t Th?baudeau wrote:
> Add a DAEMON_ARGS configuration variable in order to make it possible to
> pass custom extra options to rngd. This environment variable must
> defined in /etc/default/rngd if needed, like with the SysV init script.
> This file does not have to be present if not needed.
> 
> Signed-off-by: Beno?t Th?baudeau <benoit.thebaudeau.dev@gmail.com>
> ---
>  package/rng-tools/rngd.service | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Applied, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH] package/rng-tools: systemd: support extra options

[Benoît Thébaudeau]

Hi Maxime, all,

On Wed, Nov 4, 2015 at 10:02 AM, Maxime Hadjinlian
<maxime.hadjinlian@gmail.com> wrote:
> On Wed, Oct 21, 2015 at 12:43 AM, Beno?t Th?baudeau
> <benoit.thebaudeau.dev@gmail.com> wrote:
[...]
>> diff --git a/package/rng-tools/rngd.service
>> b/package/rng-tools/rngd.service
>> index 3bdc4c1..c0bcffe 100644
>> --- a/package/rng-tools/rngd.service
>> +++ b/package/rng-tools/rngd.service
>> @@ -2,8 +2,9 @@
>>  Description=Hardware RNG Entropy Gatherer Daemon
>>
>>  [Service]
>> -ExecStart=/usr/sbin/rngd -f
>> +ExecStart=/usr/sbin/rngd -f $DAEMON_ARGS
>>  SuccessExitStatus=66
>> +EnvironmentFile=-/etc/default/rngd
>>
>>  [Install]
>>  WantedBy=multi-user.target
>
> Everything's fine by me on this patch, just a quick question, would it be
> nice to have a default file with an empty DAEMON_ARGS ? Maybe that would be
> easier for users to understand ? Since it's used by both init system.

The issue is that empty files lying around in Buildroot would be one
more thing to maintain. They would also be useless apart from the
implicit documentation aspect, because users wanting to put something
in there would have to create their own file in a rootfs overlay.
Buildroot's users are probably advanced enough to know where and what
to look for if they need something.

> Other than that
> Reviewed-by "Maxime Hadjinlian <maxime.hadjinlian@gmail.com>"

Thanks.

Best regards,
Beno?t