Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Jörg Krause" <joerg.krause@embedded.rocks>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] musl: add a sys/queue.h implementation
Date: Tue, 01 Dec 2015 21:17:28 +0100	[thread overview]
Message-ID: <1449001048.1893.30.camel@embedded.rocks> (raw)
In-Reply-To: <1448924535-8093-1-git-send-email-sergio.prado@e-labworks.com>

Hi all,

On Mo, 2015-11-30 at 21:02 -0200, Sergio Prado wrote:
> Musl does not provide a 'sys/queue.h' implementation, and this has
> been
> a problem for packages that depend on it.
> 
> So lets create a package called sys-queue that will install
> 'sys/queue.h'
> in the staging directory when enabled.
> 
> Musl toolchain and external toolchain packages will depend on this
> package, so that 'sys/queue.h' will be always installed when
> compiling
> with a musl based toolchain.
> 

Maybe we can handle this similiar to the gettext integration and define
a BR2_NEEDS_SYS_QUEUE for toolchains not providing a queue library.

Packages that need a queue implementation can use 'select
BR2_PACKAGE_NETBSD_QUEUE if BR2_NEEDS_SYS_QUEUE' in their Config.in
file and add a '$(if $(BR2_NEEDS_SYS_QUEUE),netbsd-queue)' to their
dependencies in the .mk file.?

This means we have a package 'netbsd-queue' with the sources of the
NetBSD project you proposed. Note, there exists more implementations of
the queue library, e.g. OpenBSD, Apple, so I would prefer to use the
name of the implementation as there is no *the* sys/queue.h.

Furthermore, we allow a package to use, for whatever reasons, to select
a different queue implementation.

On the other hand, maybe it is to confusing for the package maintainer
to have different options for a queue library, so we just provide a
default package named 'sys-queue' using the sources of NetBSD?

Best regards
J?rg Krause

  parent reply	other threads:[~2015-12-01 20:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-30 23:02 [Buildroot] [PATCH] musl: add a sys/queue.h implementation Sergio Prado
2015-12-01  4:38 ` Baruch Siach
2015-12-01 10:17   ` Sergio Prado
2015-12-01 10:29 ` Thomas Petazzoni
2015-12-01 10:44   ` Sergio Prado
2015-12-01 11:00     ` Thomas Petazzoni
2015-12-01 21:14       ` Sergio Prado
2015-12-01 20:17 ` Jörg Krause [this message]
2015-12-01 20:34   ` Arnout Vandecappelle
2015-12-01 21:15     ` Sergio Prado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1449001048.1893.30.camel@embedded.rocks \
    --to=joerg.krause@embedded.rocks \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox