Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] musl: add a sys/queue.h implementation
Date: Tue, 1 Dec 2015 12:00:54 +0100	[thread overview]
Message-ID: <20151201120054.7fb61926@free-electrons.com> (raw)
In-Reply-To: <CANu7NGv0XVv-7H_p3R=QM477bNmZCZEMUrPU-VKWk0afmQ93Ww@mail.gmail.com>

Sergio,

On Tue, 1 Dec 2015 08:44:59 -0200, Sergio Prado wrote:

> > Rather than bundling the queue.h file, can we download it from some
> > location ? For example, you could use
> > http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/sys/queue.h?rev=1.30.
> 
> One of my first questions was if we should keep queue.h inside Buildroot or
> download it from somewhere. And you say we could keep it inside Buildroot,

Hum, are you sure your question was whether we should download it or
keep it inside Buildroot? I think your question was more "is it
possible to keep it inside Buildroot?", to which I answered yes,
indeed :-)

But anyway, doesn't really matter. I personally believe it's better to
download stuff when we can rather than bundling it. Hopefully others
will agree with me.


> > Do we really need this package to have a prompt? I think it could
> > remain a hidden package, no?
> 
> Since it is not included in the package/Config.in, it is still hidden,
> right? At least I can't find it when searching inside menuconfig. I created
> this file just as a matter of documentation, but I can remove if it is not
> necessary.

A Config.in that is not included anywhere is not useful at all, so it
shouldn't exist.

> > > +# source included in buildroot
> > > +SYS_QUEUE_SOURCE =
> > > +SYS_QUEUE_VERSION = 1.70
> >
> > Where is this version coming from ?
> 
> From the source code.
> http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/sys/queue.h?rev=1.70

Alright, so it can be used in <pkg>_SOURCE. You will have to overwrite
the EXTRACT_CMDS however, because it's not a tarball. See jquery.mk for
example.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2015-12-01 11:00 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-30 23:02 [Buildroot] [PATCH] musl: add a sys/queue.h implementation Sergio Prado
2015-12-01  4:38 ` Baruch Siach
2015-12-01 10:17   ` Sergio Prado
2015-12-01 10:29 ` Thomas Petazzoni
2015-12-01 10:44   ` Sergio Prado
2015-12-01 11:00     ` Thomas Petazzoni [this message]
2015-12-01 21:14       ` Sergio Prado
2015-12-01 20:17 ` Jörg Krause
2015-12-01 20:34   ` Arnout Vandecappelle
2015-12-01 21:15     ` Sergio Prado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151201120054.7fb61926@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox