Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] pifmrds: Fix Makefile to prevent link usage in static build
@ 2016-02-26  8:31 Eric Limpens
  2016-02-26 21:55 ` [Buildroot] [PATCH v3] pifmrds: add patch to correct linking " Arnout Vandecappelle
  0 siblings, 1 reply; 3+ messages in thread
From: Eric Limpens @ 2016-02-26  8:31 UTC (permalink / raw)
  To: buildroot

This patch fixes an autobuild error during a static build:
http://autobuild.buildroot.net/results/f61ae46ba4d4fc3af3784d1f612a8c1cc7de3314/

Signed-off-by: Eric Limpens <limpens@gmail.com>
---
 .../pifmrds/0003-Makefile-fix-static-link.patch    | 25 ++++++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100644 package/pifmrds/0003-Makefile-fix-static-link.patch

diff --git a/package/pifmrds/0003-Makefile-fix-static-link.patch b/package/pifmrds/0003-Makefile-fix-static-link.patch
new file mode 100644
index 0000000..322a748
--- /dev/null
+++ b/package/pifmrds/0003-Makefile-fix-static-link.patch
@@ -0,0 +1,25 @@
+Makefile: Fix static linking
+
+This patch fixes
+http://autobuild.buildroot.net/results/f61ae46ba4d4fc3af3784d1f612a8c1cc7de3314/
+
+
+Signed-off-by: "Eric Limpens" <Limpens@gmail.com>
+
+
+diff -purN pifmrds-0bf57f9ce0d954365a38d8af8e7be6f28521c3f2.orig/src/Makefile pifmrds-0bf57f9ce0d954365a38d8af8e7be6f28521c3f2/src/Makefile
+--- pifmrds-0bf57f9ce0d954365a38d8af8e7be6f28521c3f2.orig/src/Makefile	2016-02-26 08:06:43.102962592 +0100
++++ pifmrds-0bf57f9ce0d954365a38d8af8e7be6f28521c3f2/src/Makefile	2016-02-26 08:27:11.069148203 +0100
+@@ -1,10 +1,10 @@
+ CC = gcc
+ 
+ app: rds.o waveforms.o pi_fm_rds.o fm_mpx.o control_pipe.o
+-	$(CC) $(LDFLAGS) -o pi_fm_rds rds.o waveforms.o pi_fm_rds.o fm_mpx.o control_pipe.o -lm -lsndfile
++	$(CC) $(LDFLAGS) -o pi_fm_rds rds.o waveforms.o pi_fm_rds.o fm_mpx.o control_pipe.o -lsndfile -lm
+ 
+ rds_wav: rds.o waveforms.o rds_wav.o fm_mpx.o
+-	$(CC) $(LDFLAGS) -o rds_wav rds_wav.o rds.o waveforms.o fm_mpx.o -lm -lsndfile
++	$(CC) $(LDFLAGS) -o rds_wav rds_wav.o rds.o waveforms.o fm_mpx.o -lsndfile -lm
+ 
+ rds.o: rds.c waveforms.h
+ 	$(CC) $(CFLAGS) rds.c
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH v3] pifmrds: add patch to correct linking in static build
  2016-02-26  8:31 [Buildroot] [PATCH 1/1] pifmrds: Fix Makefile to prevent link usage in static build Eric Limpens
@ 2016-02-26 21:55 ` Arnout Vandecappelle
  2016-02-28 22:04   ` Thomas Petazzoni
  0 siblings, 1 reply; 3+ messages in thread
From: Arnout Vandecappelle @ 2016-02-26 21:55 UTC (permalink / raw)
  To: buildroot

From: Eric Limpens <limpens@gmail.com>

This patch fixes an autobuild error during a static build:
http://autobuild.buildroot.net/results/f61ae46ba4d4fc3af3784d1f612a8c1cc7de3314/

Signed-off-by: Eric Limpens <limpens@gmail.com>
[Arnout: clean up commit message and patch log]
Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
v3: clean up commit message and patch log [Arnout]
---
 .../pifmrds/0003-Makefile-fix-static-link.patch    | 23 ++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 package/pifmrds/0003-Makefile-fix-static-link.patch

diff --git a/package/pifmrds/0003-Makefile-fix-static-link.patch b/package/pifmrds/0003-Makefile-fix-static-link.patch
new file mode 100644
index 0000000..ecd7c4f
--- /dev/null
+++ b/package/pifmrds/0003-Makefile-fix-static-link.patch
@@ -0,0 +1,23 @@
+Makefile: Fix static linking
+
+Since libsndfile uses funtions from libm, the -lm should be specified
+after libsndfile for static linking.
+
+Signed-off-by: "Eric Limpens" <Limpens@gmail.com>
+
+diff -purN pifmrds-0bf57f9ce0d954365a38d8af8e7be6f28521c3f2.orig/src/Makefile pifmrds-0bf57f9ce0d954365a38d8af8e7be6f28521c3f2/src/Makefile
+--- pifmrds-0bf57f9ce0d954365a38d8af8e7be6f28521c3f2.orig/src/Makefile	2016-02-26 08:06:43.102962592 +0100
++++ pifmrds-0bf57f9ce0d954365a38d8af8e7be6f28521c3f2/src/Makefile	2016-02-26 08:27:11.069148203 +0100
+@@ -1,10 +1,10 @@
+ CC = gcc
+ 
+ app: rds.o waveforms.o pi_fm_rds.o fm_mpx.o control_pipe.o
+-	$(CC) $(LDFLAGS) -o pi_fm_rds rds.o waveforms.o pi_fm_rds.o fm_mpx.o control_pipe.o -lm -lsndfile
++	$(CC) $(LDFLAGS) -o pi_fm_rds rds.o waveforms.o pi_fm_rds.o fm_mpx.o control_pipe.o -lsndfile -lm
+ 
+ rds_wav: rds.o waveforms.o rds_wav.o fm_mpx.o
+-	$(CC) $(LDFLAGS) -o rds_wav rds_wav.o rds.o waveforms.o fm_mpx.o -lm -lsndfile
++	$(CC) $(LDFLAGS) -o rds_wav rds_wav.o rds.o waveforms.o fm_mpx.o -lsndfile -lm
+ 
+ rds.o: rds.c waveforms.h
+ 	$(CC) $(CFLAGS) rds.c
-- 
2.7.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH v3] pifmrds: add patch to correct linking in static build
  2016-02-26 21:55 ` [Buildroot] [PATCH v3] pifmrds: add patch to correct linking " Arnout Vandecappelle
@ 2016-02-28 22:04   ` Thomas Petazzoni
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2016-02-28 22:04 UTC (permalink / raw)
  To: buildroot

Dear Arnout Vandecappelle (Essensium/Mind),

On Fri, 26 Feb 2016 22:55:57 +0100, Arnout Vandecappelle
(Essensium/Mind) wrote:
> From: Eric Limpens <limpens@gmail.com>
> 
> This patch fixes an autobuild error during a static build:
> http://autobuild.buildroot.net/results/f61ae46ba4d4fc3af3784d1f612a8c1cc7de3314/
> 
> Signed-off-by: Eric Limpens <limpens@gmail.com>
> [Arnout: clean up commit message and patch log]
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> ---
> v3: clean up commit message and patch log [Arnout]
> ---
>  .../pifmrds/0003-Makefile-fix-static-link.patch    | 23 ++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>  create mode 100644 package/pifmrds/0003-Makefile-fix-static-link.patch

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2016-02-28 22:04 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-26  8:31 [Buildroot] [PATCH 1/1] pifmrds: Fix Makefile to prevent link usage in static build Eric Limpens
2016-02-26 21:55 ` [Buildroot] [PATCH v3] pifmrds: add patch to correct linking " Arnout Vandecappelle
2016-02-28 22:04   ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox