From: Kinsella, Ray <ray.kinsella@intel.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 1/3] package/radlib: kconfig and makefile
Date: Thu, 7 Apr 2016 11:04:02 +0000 [thread overview]
Message-ID: <1460027041.3176.5.camel@intel.com> (raw)
In-Reply-To: <57058BC3.1070105@mind.be>
Hi Arnout,
On Thu, 2016-04-07 at 00:20 +0200, Arnout Vandecappelle wrote:
> Very quick feedback, not a detailed review.
>
> First of all, the three patches should be squashed into one,
> because all three
> are needed to have a functional package. Otherwise, the build would
> be broken
> between the patches.
>
Confused, just doing what I was asked in the previous review.
Can you offer a little more guidance on how I should structure.
Agree that you need all the pieces for a functional package.
On Tue, 2016-03-29 at 20:07 +0200, Thomas Petazzoni wrote:
> Hello,
> So you're doing three different things. Which calls for three
> different
> patches.
>
> I'll do a full review once you send it with git send-email, because
> the
> line wrapping makes it really hard to follow.
next prev parent reply other threads:[~2016-04-07 11:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-06 13:19 [Buildroot] [PATCH v4 0/3] package/radlib: new package ray.kinsella at intel.com
2016-04-06 13:19 ` [Buildroot] [PATCH v4 1/3] package/radlib: kconfig and makefile ray.kinsella at intel.com
2016-04-06 22:20 ` Arnout Vandecappelle
2016-04-07 11:04 ` Kinsella, Ray [this message]
2016-04-07 15:25 ` Arnout Vandecappelle
2016-04-07 16:36 ` Kinsella, Ray
2016-04-10 14:59 ` Arnout Vandecappelle
2016-04-11 8:45 ` Kinsella, Ray
2016-04-06 13:19 ` [Buildroot] [PATCH v4 2/3] package/radlib: Renamed configure.in to configure.ac ray.kinsella at intel.com
2016-04-06 22:22 ` Arnout Vandecappelle
2016-04-07 12:04 ` Kinsella, Ray
2016-04-06 13:19 ` [Buildroot] [PATCH v4 3/3] package/radlib: reworked autotools with pkg-config ray.kinsella at intel.com
2016-04-06 22:36 ` Arnout Vandecappelle
2016-04-07 12:03 ` Kinsella, Ray
2016-04-07 15:39 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460027041.3176.5.camel@intel.com \
--to=ray.kinsella@intel.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox