[Buildroot] [PATCH 0/3] sstrip: drop host variant and deprecate target variant

[Buildroot] [PATCH 0/3] sstrip: drop host variant and deprecate target variant

[Julien Floret]

Host sstrip is not used anymore.
What's more, sstrip is not maintained and potentially harmful.

Julien Floret (3):
  sstrip: get rid of host variant
  Config.in: Add BR2_DEPRECATED_SINCE_2016_08
  sstrip: mark as deprecated

 Config.in                |  4 ++++
 package/sstrip/Config.in |  1 +
 package/sstrip/sstrip.mk | 12 ------------
 3 files changed, 5 insertions(+), 12 deletions(-)

-- 
2.1.0

[Buildroot] [PATCH 1/3] sstrip: get rid of host variant

[Julien Floret]

Host sstrip is not used anymore.

Signed-off-by: Julien Floret <julien.floret@6wind.com>
---
 package/sstrip/sstrip.mk | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/package/sstrip/sstrip.mk b/package/sstrip/sstrip.mk
index fe57b3c19b21..685ea09fbd77 100644
--- a/package/sstrip/sstrip.mk
+++ b/package/sstrip/sstrip.mk
@@ -6,7 +6,6 @@
 
 SSTRIP_SITE = svn://svn.openwrt.org/openwrt/trunk/tools/sstrip
 SSTRIP_VERSION = 20154
-HOST_SSTRIP_BINARY = $(GNU_TARGET_NAME)-sstrip
 
 define SSTRIP_BUILD_CMDS
 	cd $(@D) ; \
@@ -18,15 +17,4 @@ define SSTRIP_INSTALL_TARGET_CMDS
 	$(INSTALL) -D $(@D)/sstrip $(TARGET_DIR)/usr/bin/sstrip
 endef
 
-define HOST_SSTRIP_BUILD_CMDS
-	cd $(@D) ; \
-	$(HOSTCC) $(HOST_CFLAGS) -include endian.h -include byteswap.h \
-		-o sstrip src/sstrip.c
-endef
-
-define HOST_SSTRIP_INSTALL_CMDS
-	$(INSTALL) -D $(@D)/sstrip $(HOST_DIR)/usr/bin/$(HOST_SSTRIP_BINARY)
-endef
-
 $(eval $(generic-package))
-$(eval $(host-generic-package))
-- 
2.1.0

[Buildroot] [PATCH 2/3] Config.in: Add BR2_DEPRECATED_SINCE_2016_08

[Julien Floret]

In preparation for new deprecated features/symbols.

Signed-off-by: Julien Floret <julien.floret@6wind.com>
---
 Config.in | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Config.in b/Config.in
index 9fa74157a4be..820b1f0945db 100644
--- a/Config.in
+++ b/Config.in
@@ -385,6 +385,10 @@ config BR2_DEPRECATED_SINCE_2016_05
 	bool
 	default y
 
+config BR2_DEPRECATED_SINCE_2016_08
+	bool
+	default y
+
 endif
 
 config BR2_ENABLE_DEBUG
-- 
2.1.0

[Buildroot] [PATCH 3/3] sstrip: mark as deprecated

[Julien Floret]

sstrip is unmaintained and potentially harmful, as Yann explained in
commit 6a6962fd82ca ("build/sstrip: deprecate for 2014.05").

Signed-off-by: Julien Floret <julien.floret@6wind.com>
---
 package/sstrip/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/sstrip/Config.in b/package/sstrip/Config.in
index 12a5941c54aa..c458f8eab1b0 100644
--- a/package/sstrip/Config.in
+++ b/package/sstrip/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_SSTRIP
 	bool "sstrip"
+	depends on BR2_DEPRECATED_SINCE_2016_08
 	help
 	  Small utility that removes a few bytes from an executable that
 	  strip leaves behind.
-- 
2.1.0

[Buildroot] [PATCH 0/3] sstrip: drop host variant and deprecate target variant

[Thomas Petazzoni]

Hello,

On Thu, 16 Jun 2016 16:41:12 +0200, Julien Floret wrote:
> Host sstrip is not used anymore.
> What's more, sstrip is not maintained and potentially harmful.
> 
> Julien Floret (3):
>   sstrip: get rid of host variant
>   Config.in: Add BR2_DEPRECATED_SINCE_2016_08
>   sstrip: mark as deprecated

Series applied, thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com