* [Buildroot] [PATCH] warpboard: linux.fragment: Do not use CONFIG_BRCMFMAC as built-in
@ 2016-07-29 13:45 Fabio Estevam
2016-07-29 16:23 ` Jörg Krause
2016-07-30 10:17 ` Thomas Petazzoni
0 siblings, 2 replies; 5+ messages in thread
From: Fabio Estevam @ 2016-07-29 13:45 UTC (permalink / raw)
To: buildroot
Selecting the driver CONFIG_BRCMFMAC as built-in causes some probe issues
as we cannot guarantee that the brcmfmac driver will be probed after the
rootfs has been mounted. The brcmfmac driver retrieves the firmware and
nvram file from the rootfs, so the rootfs should be mounted first.
To avoid such issues let the CONFIG_BRCMFMAC be built as module, which is
the original option in imx_v6_v7_defconfig.
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
board/freescale/warpboard/linux.fragment | 1 -
1 file changed, 1 deletion(-)
diff --git a/board/freescale/warpboard/linux.fragment b/board/freescale/warpboard/linux.fragment
index 736b9cd..892d0cb 100644
--- a/board/freescale/warpboard/linux.fragment
+++ b/board/freescale/warpboard/linux.fragment
@@ -1,2 +1 @@
CONFIG_CFG80211_WEXT=y
-CONFIG_BRCMFMAC=y
--
1.9.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] warpboard: linux.fragment: Do not use CONFIG_BRCMFMAC as built-in
2016-07-29 13:45 [Buildroot] [PATCH] warpboard: linux.fragment: Do not use CONFIG_BRCMFMAC as built-in Fabio Estevam
@ 2016-07-29 16:23 ` Jörg Krause
2016-07-29 16:29 ` Fabio Estevam
2016-07-30 10:17 ` Thomas Petazzoni
1 sibling, 1 reply; 5+ messages in thread
From: Jörg Krause @ 2016-07-29 16:23 UTC (permalink / raw)
To: buildroot
Hi Fabio,
On Fr, 2016-07-29 at 10:45 -0300, Fabio Estevam wrote:
> Selecting the driver CONFIG_BRCMFMAC as built-in causes some probe
> issues
> as we cannot guarantee that the brcmfmac driver will be probed after
> the
> rootfs has been mounted. The brcmfmac driver retrieves the firmware
> and
> nvram file from the rootfs, so the rootfs should be mounted first.
>
> To avoid such issues let the CONFIG_BRCMFMAC be built as module,
> which is
> the original option in imx_v6_v7_defconfig.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> ?board/freescale/warpboard/linux.fragment | 1 -
> ?1 file changed, 1 deletion(-)
>
> diff --git a/board/freescale/warpboard/linux.fragment
> b/board/freescale/warpboard/linux.fragment
> index 736b9cd..892d0cb 100644
> --- a/board/freescale/warpboard/linux.fragment
> +++ b/board/freescale/warpboard/linux.fragment
> @@ -1,2 +1 @@
> ?CONFIG_CFG80211_WEXT=y
> -CONFIG_BRCMFMAC=y
Shouldn't this be "CONFIG_BRCMFMAC=m"?
J?rg
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] warpboard: linux.fragment: Do not use CONFIG_BRCMFMAC as built-in
2016-07-29 16:23 ` Jörg Krause
@ 2016-07-29 16:29 ` Fabio Estevam
2016-07-29 16:34 ` Jörg Krause
0 siblings, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2016-07-29 16:29 UTC (permalink / raw)
To: buildroot
Hi J?rg,
On Fri, Jul 29, 2016 at 1:23 PM, J?rg Krause
<joerg.krause@embedded.rocks> wrote:
>> --- a/board/freescale/warpboard/linux.fragment
>> +++ b/board/freescale/warpboard/linux.fragment
>> @@ -1,2 +1 @@
>> CONFIG_CFG80211_WEXT=y
>> -CONFIG_BRCMFMAC=y
>
> Shouldn't this be "CONFIG_BRCMFMAC=m"?
CONFIG_BRCMFMAC=m is already selected in imx_v6_v7_defconfig, so
that's I why I simply remove this option from linux.fragment.
Regards,
Fabio Estevam
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] warpboard: linux.fragment: Do not use CONFIG_BRCMFMAC as built-in
2016-07-29 16:29 ` Fabio Estevam
@ 2016-07-29 16:34 ` Jörg Krause
0 siblings, 0 replies; 5+ messages in thread
From: Jörg Krause @ 2016-07-29 16:34 UTC (permalink / raw)
To: buildroot
On Fr, 2016-07-29 at 13:29 -0300, Fabio Estevam wrote:
> Hi J?rg,
>
> On Fri, Jul 29, 2016 at 1:23 PM, J?rg Krause
> <joerg.krause@embedded.rocks> wrote:
>
> >
> > >
> > > --- a/board/freescale/warpboard/linux.fragment
> > > +++ b/board/freescale/warpboard/linux.fragment
> > > @@ -1,2 +1 @@
> > > ?CONFIG_CFG80211_WEXT=y
> > > -CONFIG_BRCMFMAC=y
> >
> > Shouldn't this be "CONFIG_BRCMFMAC=m"?
>
> CONFIG_BRCMFMAC=m is already selected in imx_v6_v7_defconfig, so
> that's I why I simply remove this option from linux.fragment.
>?
I see! I did not realize it is a fragment.
J?rg
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] warpboard: linux.fragment: Do not use CONFIG_BRCMFMAC as built-in
2016-07-29 13:45 [Buildroot] [PATCH] warpboard: linux.fragment: Do not use CONFIG_BRCMFMAC as built-in Fabio Estevam
2016-07-29 16:23 ` Jörg Krause
@ 2016-07-30 10:17 ` Thomas Petazzoni
1 sibling, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2016-07-30 10:17 UTC (permalink / raw)
To: buildroot
Hello,
On Fri, 29 Jul 2016 10:45:30 -0300, Fabio Estevam wrote:
> Selecting the driver CONFIG_BRCMFMAC as built-in causes some probe issues
> as we cannot guarantee that the brcmfmac driver will be probed after the
> rootfs has been mounted. The brcmfmac driver retrieves the firmware and
> nvram file from the rootfs, so the rootfs should be mounted first.
>
> To avoid such issues let the CONFIG_BRCMFMAC be built as module, which is
> the original option in imx_v6_v7_defconfig.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> board/freescale/warpboard/linux.fragment | 1 -
> 1 file changed, 1 deletion(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-07-30 10:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-29 13:45 [Buildroot] [PATCH] warpboard: linux.fragment: Do not use CONFIG_BRCMFMAC as built-in Fabio Estevam
2016-07-29 16:23 ` Jörg Krause
2016-07-29 16:29 ` Fabio Estevam
2016-07-29 16:34 ` Jörg Krause
2016-07-30 10:17 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox