Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Vlad Zakharov <Vladislav.Zakharov@synopsys.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] stella: fix compiler search in configure script
Date: Wed, 24 Aug 2016 16:47:37 +0000	[thread overview]
Message-ID: <1472057256.4369.25.camel@synopsys.com> (raw)
In-Reply-To: <87d1l7qn2y.fsf@dell.be.48ers.dk>

Hi Peter,

This patch was adopted in upstream Stella project:
https://sourceforge.net/p/stella/code/3315/
and will come up in next Stella release.

So it need to be reverted after update to upcoming Stella release.

Thx.

On Wed, 2016-08-17 at 20:15 +0200, Peter Korsgaard wrote:
> > 
> > > 
> > > > 
> > > > > 
> > > > > > 
> > > > > > "Vlad" == Vlad Zakharov <Vladislav.Zakharov@synopsys.com> writes:
> ?> In configure script there are some tests that are looking for
> ?> a suitable compiler. For this purpose script tries to compile
> ?> and link some C++ code that is hardcoded in the body of script.
> 
> ?> The problem is that only linker flags ($LDFLAGS) are passed to the
> ?> compiler when the script is compiling test code. Therefore some
> ?> necessary command line options can be lost and this would lead to
> ?> errors.
> 
> ?> This exactly happens to ARC:
> ?>???1. -matomic option is lost as it compiler option,
> ?>???2. test code compilation fails,
> ?>???3. the script decides not to use arc-buildroot-linux-uclibc-g++,
> ?>???4. scipt checks host compiler (x86_64-linux-gnu-g++ in your case),
> ?>???5. package is being built for x86_64, not for ARC.
> 
> ?> About last 2 steps - I don't know why configure script should try
> ?> to build stella for host machine. As for me an error should be
> ?> raised and a build should be stopped. But this is up to stella
> ?> developers.
> 
> ?> Current patch adds compiler options ($CPPLFAGS) when compiling
> 
> You are actually passing CXXFLAGS. Committed with that fixed.
> 
> Don't forget to submit the patch upstream!
> 
-- 
Best regards,
Vlad Zakharov <vzakhar@synopsys.com>

  reply	other threads:[~2016-08-24 16:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-11 10:20 [Buildroot] [PATCH] stella: fix compiler search in configure script Vlad Zakharov
2016-08-17 18:15 ` Peter Korsgaard
2016-08-24 16:47   ` Vlad Zakharov [this message]
2016-08-24 16:57     ` Thomas Petazzoni
2016-08-24 21:39     ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1472057256.4369.25.camel@synopsys.com \
    --to=vladislav.zakharov@synopsys.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox