[Buildroot] [PATCH 1/2] nginx-naxsi: depends on BR2_PACKAGE_NGINX_HTTP

[Buildroot] [PATCH 1/2] nginx-naxsi: depends on BR2_PACKAGE_NGINX_HTTP

[Johan Oudinet]

This package adds XSS and SQLi protection to Nginx HTTP server.
So, it makes sense iff the HTTP part of nginx is enabled.

Signed-off-by: Johan Oudinet <johan.oudinet@gmail.com>
---
 package/nginx-naxsi/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/nginx-naxsi/Config.in b/package/nginx-naxsi/Config.in
index 5ae5497..e9907aa 100644
--- a/package/nginx-naxsi/Config.in
+++ b/package/nginx-naxsi/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_NGINX_NAXSI
 	bool "nginx-naxsi"
+        depends on BR2_PACKAGE_NGINX_HTTP
 	# uses pcre, so nginx needs to be built with pcre support
 	select BR2_PACKAGE_PCRE
 	help
-- 
2.7.4

[Buildroot] [PATCH 2/2] nginx-dav-ext: depends on BR2_PACKAGE_NGINX_HTTP_DAV_MODULE

[Johan Oudinet]

This package adds missing WebDAB commands to NGINX. So, it makes sense
iff Nginx is compiled with the WebDAV support.

Signed-off-by: Johan Oudinet <johan.oudinet@gmail.com>
---
 package/nginx-dav-ext/Config.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/nginx-dav-ext/Config.in b/package/nginx-dav-ext/Config.in
index bf197dc..8761e2f 100644
--- a/package/nginx-dav-ext/Config.in
+++ b/package/nginx-dav-ext/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_NGINX_DAV_EXT
 	bool "nginx-dav-ext"
+        depends on BR2_PACKAGE_NGINX_HTTP_DAV_MODULE
 	select BR2_PACKAGE_EXPAT
 	help
 	  NGINX WebDAV missing commands support (PROPFIND & OPTIONS).
-- 
2.7.4

[Buildroot] [PATCH 1/2] nginx-naxsi: depends on BR2_PACKAGE_NGINX_HTTP

[Thomas Petazzoni]

Hello,

On Mon,  5 Dec 2016 15:28:24 +0100, Johan Oudinet wrote:
> This package adds XSS and SQLi protection to Nginx HTTP server.
> So, it makes sense iff the HTTP part of nginx is enabled.
> 
> Signed-off-by: Johan Oudinet <johan.oudinet@gmail.com>
> ---
>  package/nginx-naxsi/Config.in | 1 +
>  1 file changed, 1 insertion(+)

Thanks, I've applied both patches. However, I had to fix two things:

 - The indentation was wrong: you used spaces while Config.in entries
   are indented with one tab.

 - You forgot to add references to the autobuilder issues being fixed
   by those patches.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com